From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D58EC636CC for ; Wed, 8 Feb 2023 16:01:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D41D6B0071; Wed, 8 Feb 2023 11:01:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 582C76B0072; Wed, 8 Feb 2023 11:01:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4716F6B0074; Wed, 8 Feb 2023 11:01:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 34D836B0071 for ; Wed, 8 Feb 2023 11:01:19 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F1F2080E2D for ; Wed, 8 Feb 2023 16:01:18 +0000 (UTC) X-FDA: 80444589036.29.EC0B1B7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf07.hostedemail.com (Postfix) with ESMTP id 750DC40014 for ; Wed, 8 Feb 2023 16:01:13 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ABZad9E2; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf07.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675872075; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1DaopZDdlwao209mQiW1EFcILq+SNU2i7Dq7AU/IXvY=; b=SrxpLyDmmNmSosmk3tp6LCCFteshJok8Onz2+ckGToVMIF10tTuAO6l4V/qts/7wikl26G xb8dKgIlYW1q4T1udMjwlyYiCIu4S4qh6sjOCH9Ec1WjGGnTDJeeOUF0lXD5+KggvfMmk/ DmGf3bRqiTY1zYwg5mGKZBtuLum98jU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ABZad9E2; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf07.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675872075; a=rsa-sha256; cv=none; b=0Q67oEfDSFhWXRFDzXKvvHL61uqnK8f+aykMWAXaVybtoWAKjKemNnMxIcVb5ICwR/sVSw 3jvgdS/8eoY01s6SN1xuI72GICFoR04ZGiQ+LM4pB3NhD8+uEcZLM7WUaVa+gIO7UpaF/z fXWdpsDG7NbHmxYt7i3qhxJiXxN/q4o= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1DaopZDdlwao209mQiW1EFcILq+SNU2i7Dq7AU/IXvY=; b=ABZad9E2tqcSahpgS49GerIChy TjdG6srT8y6qMko0eIT6HOKkSbHg7y/Hp3zKJukjgwfft387vsFtUmmOVrPcYuQZicTzOvgtxI177 Sop4U663UuT+HF0PnkUOP+hTmBOqkwy0EfnDkPGZZTW7UkVf7LKssjqgf6Mb6UFZRaTzqnnBlFTBp To2hDXS6o4cbMjmnYMGC/6goKqTSxiWya6ak+TltW+c94IszKu5Pl89jlVM4FUpT9zs5EGtUp1GGQ gVaLKdpV8R57Sm9MrTvxoEXNHdaumZUP09fSyefshk+IRBkHbcErRISnzb61wS0MlndIq9Su/XTLr y1CNSgJw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPmsX-00GB4B-MP; Wed, 08 Feb 2023 16:01:06 +0000 Date: Wed, 8 Feb 2023 08:01:01 -0800 From: Luis Chamberlain To: Matthew Wilcox Cc: hughd@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, p.raghav@samsung.com, dave@stgolabs.net, a.manzanares@samsung.com, linux-kernel@vger.kernel.org Subject: Re: [RFC 2/2] shmem: add support to ignore swap Message-ID: References: <20230207025259.2522793-1-mcgrof@kernel.org> <20230207025259.2522793-3-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 750DC40014 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: a1ay88cn4c9xieitu7urpjmuaq1ny4x7 X-HE-Tag: 1675872073-781396 X-HE-Meta: U2FsdGVkX1/yx2mDNAvu414ahNukNe9FfhU0W2qZQ2cW9RUHFu4ookXCvq7/hbZIZGOmD8XS2jQYI9/MuTWIj2lJfSsECBC40cySXLLv30VeIiREJNZGgBpbLGkDtlU1fw/zkTer70NxTfhGdia0FXxCgflS3mVrp21daMJieK2HbCcBChJLjAJm94dumntUT532VCozCFNT2div9VNs9kZs3Rw0yWLC0fcOKyLCHqQrWaGp6bEqVFuAfRTfM+eemQhWTlwlD/iR8+bpnONhgAVl38GMPFHeab/iMN1fCjBHn/eyIO7Y7a9yZHt+UQ9hqCPVTK54M3CaJb3aWRFxl7c6BL7l3P0CddW9idvbo6i4FnOIDHmV56BzCp5ZFht24w3rjrcCy7Ezs4w0fHknm/fxea0ww1VBnXUdaI+WUhiMCicVrrWhHoIstWwIROMV08FDt+aIBV1elatOpzrxTUNI0V40U6D+P30EhosZXvndhm2zql0K7OrWszp9Ar/R5pkYqTXvk92NJIIiJPLTfQodrtYDDAecUeuKqdCklHwfvuOY5UxQQ/bRHEMxIt30kMUh3uVA8lQmDFmBr3OnJ7HV7odD/Pay0z0EXPBBk4ipWEFSg/jFNjx0ANWtgjhpafxohOGxLdn1V6P2yPdZVn0aQ5E6r7EBAzRz3pLOpGN8eyyqwbVYHd09vp0ff9DhfLbSqlzbYllbZM+hb5Cl/fuftaHvTC4meUvw6Err369k1kXWzzEOpE5/P+x/YBQQKmM372mWtnr/VSESoz3aJOSb01PFJikjiKZk6myAPI+H62NASbNjEpLzVpC5Az5umbJKP8yZtlZeZzK6Op/EsshGftsxp+9ZSxb4h+HtKlthL2qX/MP6+ylc0xXbZEFe6JUKqaTh5pn+e1Uv9fMs6Fv8ZUjiEhQYO9Xqq2v3V1wg/jwRp/2QwD5fchcuL56W+N2/zSSqZmYA0d2pmCb COk4AOtV /0ObU7/WZotU4ZPOt4Y6CvYs5a26K5z8VuBG7tvoilaqmcGvC4t66k8A7I2QzfY/9DilkUlBYrNFyfQfAXFy2BXAs1U74sW7LqvHRJq+U/L+CL7Xp6wHx7mU4UybAEbTOI9r+ZRwI/R7XdBspGUsL8deE9/Ge6FBpzJHIursSY3v+Q7Awv78ttcmneHP3yYuaJOOGU3DZNR6EwRy7F0o0feosvf8Qz/Eli+3uD7ZVLPcpeEXr4PdETF8FG1Z/EYNGR3V3H2bUT97CWTi7oIMrzGlLHAzYHzOUAjXeiJpuWPwYidEo4R3seqqxzcQHkxOW3BGt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 07, 2023 at 04:01:51AM +0000, Matthew Wilcox wrote: > On Mon, Feb 06, 2023 at 06:52:59PM -0800, Luis Chamberlain wrote: > > @@ -1334,11 +1336,15 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc) > > struct shmem_inode_info *info; > > struct address_space *mapping = folio->mapping; > > struct inode *inode = mapping->host; > > + struct shmem_sb_info *sbinfo = SHMEM_SB(inode->i_sb); > > swp_entry_t swap; > > pgoff_t index; > > > > BUG_ON(!folio_test_locked(folio)); > > > > + if (wbc->for_reclaim && unlikely(sbinfo->noswap)) > > + return AOP_WRITEPAGE_ACTIVATE; > > Not sure this is the best way to handle this. We'll still incur the > oevrhead of tracking shmem pages on the LRU, only to fail to write them > out when the VM thinks we should get rid of them. We'd be better off > not putting them on the LRU in the first place. Ah, makes sense, so in effect then if we do that then on reclaim we should be able to even WARN_ON(sbinfo->noswap) assuming we did everthing right. Hrm, we have invalidate_mapping_pages(mapping, 0, -1) but that seems a bit too late how about d_mark_dontcache() on shmem_get_inode() instead? Luis