From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33524C636CC for ; Wed, 8 Feb 2023 17:22:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F9766B0071; Wed, 8 Feb 2023 12:22:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A93C6B0074; Wed, 8 Feb 2023 12:22:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 397EB6B0078; Wed, 8 Feb 2023 12:22:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2AD2E6B0071 for ; Wed, 8 Feb 2023 12:22:00 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F359D40F24 for ; Wed, 8 Feb 2023 17:21:59 +0000 (UTC) X-FDA: 80444792358.07.09CC9FD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id AE585140029 for ; Wed, 8 Feb 2023 17:21:56 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tSIp+M+D; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675876916; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hW5i73pe8pnUfUYDL1bt63KL1qTJ5SbNKkdlGg3uo4g=; b=5hqM737znTxhHJ3MfviEgsulhGuS6PBM0URNs0xkLLwKof2pn7fx6upSktl2eLWUk2OSvI cZ1xKTbL+gQeOVWnvYtNlCq9H/yptLNkab06yh/7N30AHZ6qhgaPWlSHbTUkzMKizpMGCc E5rePCqzN4ja4SiQH3fWiTM1PdBXC8I= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tSIp+M+D; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675876916; a=rsa-sha256; cv=none; b=pff4Uko+VFqK+7kXNgUnsLxEOya8Y6ZmDUaXzzW77idabrjks/3W+MbQrV75NAVlBz8KDK AdnBhTV6/+yatb+NpUErpeol79b2Th/UuBhVb+t5ownkhzCcV1Bb0D3tQeLbgc1y3GpJ3R /GrWl0kp6H3Hklk5Hl9EX1cNC7NAFX4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hW5i73pe8pnUfUYDL1bt63KL1qTJ5SbNKkdlGg3uo4g=; b=tSIp+M+Dh97ieUihW36Xe3Tg1N czULo45mLjiF0C6oMWsgo7vv2TYg6wM7AtlLz3Y8XwQRHFzA2AIPQXD5NniJDOYcPWmDHyzVxuFQo Ux0ioFgtU7MetMymkrkZ7y9pXX3vb2wXN+QZlAcy1a4ybiaOZfQsqSKj5/2K077o/Wx4j8Q06alP2 UWsNMf6LWKGpw/esuaGwaOx69uVMTn6CNA6WbXTY2wYLw2HjTIpDuoqqr0hBqlwnTmZz266TRcPak sEML8oQe5uhLP2bymeBTf776sY4Ev/QyK3Y/r0g4Wt0+ByW1qjuaxYjSQCsoJy6/hNo/sX3RWbzeU nm4gXSJw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPo8O-001PQr-0w; Wed, 08 Feb 2023 17:21:28 +0000 Date: Wed, 8 Feb 2023 17:21:27 +0000 From: Matthew Wilcox To: David Howells Cc: Christoph Hellwig , Jens Axboe , Al Viro , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzbot+a440341a59e3b7142895@syzkaller.appspotmail.com, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v12 01/10] vfs, iomap: Fix generic_file_splice_read() to avoid reversion of ITER_PIPE Message-ID: References: <20230207171305.3716974-1-dhowells@redhat.com> <20230207171305.3716974-2-dhowells@redhat.com> <176199.1675872591@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <176199.1675872591@warthog.procyon.org.uk> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: xf1x9p9ifbne6qwyaucpomhtwwbmzr3m X-Rspamd-Queue-Id: AE585140029 X-HE-Tag: 1675876916-921991 X-HE-Meta: U2FsdGVkX19c/ssCXF3nEAeAp97Dj5NbD7kLlNDUKCEF5HrM3K/Z78yUW0Txc3d/ieJQixxJ3rXshT6B7rQU1a9Dcm+/4etMJwo2PlI33W6XNeLiTHytDgDh6ceGZ8iOmIMbxmN15pWj0WaYIbKMExdsuekLzmQa8wXw93EWUiR3ee5yWkosepMdYKNd2bDKE73ZISXu4CYFnaoH9B3qsObD86DaJV6HzD3GdCra64oG4+ivJH0V7BXsxtnAgkrVuZo6NKVRTZ6ZQKTNVHWUT9AwNGVloWcE+t6ZJTvIjzrKNQY2hGIelixXAlaIZ2wwZ4g5YeeGamuX/r3WOn1sEApJU5uIdJrNYW/eVwrcTZhVOHr5assKZEEByTaYn8Ub2KM1mkDyMj9AMizYlMtTrVZUpvDNEXx9o/apxTv5oms59oGR8e++/sCPT/4T4ps9QCyU1p6PKUUgozGvnnFX6GvESfT0g/p6cO9MT8kTHwPeLWJDv60pmXOXsAlnc2AwyuQlKfBRULK6Ko5OgrEBbd5QRs5qNhvYdJQmNXXN3il6Pb2DzN6zaBJIuj0Ny+uVDLH6HNa/LXPZEcVl7CCbCbzmZ4a/ZONhgKYD0pLY93VfsM/JqZJoCmcOLa5bAX0HKbmvhGuQVCtCYOPreA3Z55/EO8WLmUMRhMXfhoTNGYt1AZnWmlMT/oQtxdCyA06wSZXMQNc9PEZCnxbGR0EcnznZFzR/E3oPi6awLXM8kGZKm31EXtF/ZHzmpttNbcxdrtt30y3E+Wfhb0hMtST+PO7F3rXa1wAQe7iKvmS6vdKUZBuZa6OiSbTtw4bn0Spib7+wZBUswq6CsR2hhdQK9m5nVUonQuMLjLOG6+G22sgiJvbMbXJGCWUpqHYprwpluqYvJxU9zKtYn+DytIuL7uqEFROXH5QlJhek3P4CpdOqRRA1Ooo13qKriBpJp+VxhUnqeTWTiAD6Fn7EvdO +zk6nPbC FNdvqWjblFVd3rEuyXWxyYE1u9CI3y5OK9pbSZIZ+lDD77KEY0FwaEyXG2KtzN5eGMCg6WprqraP3M6OYF9p8/Neh7vby0Wid0+h2y5FhrMRgz0Diji6iOe02D8RRJchlohhf+VlG3kqF9mCpg7AIEUDj0/swj8gG61PkuSEJaJTZ+Bbwjh7WybvubFWpO3vzSby8yjjK3p1yiCN3ZBZ6Qj2wbgZHgABBtoHfslAhE6C2jQRlDr0zA87fLxb9RwFKSZfDMwXQlQST9JGJOdY4yqjJ2EVTL1eKdtHf5GRXI8TSvkyMJyqGqW8lrlCq0NcKrp1gSbg90ZIua5Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 08, 2023 at 04:09:51PM +0000, David Howells wrote: > @@ -2688,7 +2689,7 @@ ssize_t filemap_read(struct kiocb *iocb, struct iov_iter *iter, > if (unlikely(iocb->ki_pos >= i_size_read(inode))) > break; > > - error = filemap_get_pages(iocb, iter, &fbatch); > + error = filemap_get_pages(iocb, iov_iter_count(iter), &fbatch); What's the point in iov_iter_count() anyway? It's more characters than iter->count, so why not use it directly?