From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D598C05027 for ; Sun, 12 Feb 2023 14:48:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 861B46B0073; Sun, 12 Feb 2023 09:48:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EA796B0074; Sun, 12 Feb 2023 09:48:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B1A36B0075; Sun, 12 Feb 2023 09:48:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 582E06B0073 for ; Sun, 12 Feb 2023 09:48:01 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B514A803D0 for ; Sun, 12 Feb 2023 14:48:00 +0000 (UTC) X-FDA: 80458919520.27.049D749 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 0178380002 for ; Sun, 12 Feb 2023 14:47:58 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QXngzYQo; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676213279; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PMQbSliZHqd3rrG8KatpZFV1uAn8UGHI9jI0yRbA02E=; b=oBLoLzZZo5ktw5VvVPsPj3HoPKRJeeXt/BFmaafW4vv4kPk6dK33yZX8/BrInUd+wTPXhx /b1Gb2b1PJX+21fYFlE6z9SmQGyRxH9qMtBhS0a9gw0sl4rDQoRnTQcn8LFHhKSdlmhScS sqiKk3RB75mzv1ezh8UsAW9c7+TeyO0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QXngzYQo; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676213279; a=rsa-sha256; cv=none; b=AfsycZa5SGcAwiBrRETDYLeuNWpXPnrUWFWbrUC9rOO12519hAhv9KqqwYQmiWK/2ZgcoG ZhADCEK8sD9HwZb9crFf6n/N0+CftH7+LV3e5oUUveHfhw3shP1YZlGkhENuVi80Zy5gaI wbip52LCxZlJU2+m7kKn0KIOpz42V3w= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D3FFF60C86; Sun, 12 Feb 2023 14:47:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C2BBC433EF; Sun, 12 Feb 2023 14:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676213277; bh=p8vea+Viq5T3HBJIG/rvWJdkWif69BStqXp2D3hTyL0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QXngzYQovn7F4x3f1kNvFy7yRu1FjOfMayfHfTEscWM3IMrcsvzBmh6sPpHROpD3t 1nL8rP87l6XKbcncHY1GLGXdf+FgtBmNB9stZSrWBsL/X5SXHfmlHaszDqk+Pf7HaG T4Z+ccXrAjTTsaOnPj+HyQGVhWwFu0QXrs5opSMdG445COrmyTvA8IROHCBv3BY6Nu lNM4FZEXiKLMR1kmOx6whh4Wjr/AVJT2vBxNT4kQeqABbMDGwEXpRb8GXFTVjWayHn WOKu2zk4j0SVV44jB+VnPs6nOnj5zfeRjyk8U2kA2MaEcwgVg8kqwC+d/7heZT8RCB c61irGKs6joXQ== Date: Sun, 12 Feb 2023 16:47:42 +0200 From: Mike Rapoport To: Matthew Wilcox Cc: Jonathan Corbet , Andrew Morton , Bagas Sanjaya , David Hildenbrand , Johannes Weiner , Lorenzo Stoakes , Mel Gorman , Michal Hocko , Vlastimil Babka , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] docs/mm: Physical Memory: add example of interleaving nodes Message-ID: References: <20230212095445.1311627-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0178380002 X-Stat-Signature: uj9w4xwntxawztjci8mfwd6wzezdnyd8 X-HE-Tag: 1676213278-630032 X-HE-Meta: U2FsdGVkX1+dTzmfe4+kUOBsGfqhHf0LE8BPn4th7VK/KaPWTs5SEkEpN63jKkOEOR2joC/udoaQ2rnmJF0Rn92TF+fQld4FDG5c5X6vsgw8HoLFRaJnTMprx6eD8QDN2FIdI5qYV/tuiHeI1hSfcderXwuchdq2/5F66MmUDusBregOwzoEApdlY2C/Tqy4skqI7rwOPVEtEBNyaj2cd7TVikcncdg0NXA2zllDzdBLq3PqLjhdfS58EziEwfHUPAOcW0GJvHXn2TscwEUy7V3yHCz2NVuIMBonLyScrXXbsqg5HjVqMGGWp5J5yuJNQF0wEPpIP2reSB6M2g1TvNoWKcB6uFSh0F9+64Taow6x9/4cX9Uq8iRupqdcl/0WWHUrTmZaFcKaVCLrYtMsFi+4rpGOHlnGXSB3I5lMAxIBGKrYRnoFjYQ47NT+hTG9yzloep8VMyVpTk/lclKCSTkynoPicoxUH2CKqqegxrtK0/Zo0huB1PT4UKiZCIxFTsnuZ+0oNWoGh6ajfrc6aWZxW5Thh1h9LFjNQi1PHaTjIjVWu65ild2AeSZe3Zri8wnm6zrWRWm3uaLYB+nr/v9O1JFCzjHII1LMEgqrAeNZt03DRic0+9zoOBKWuqmuru4h6khsDPKKddVs7J+Q2cMGxlLrbmt6vJ4TorL32pWBH/sYqnPMDycVvU9YadCPW2L88t3yek06PK38zs1MUIa476kY/fD9ZopM2WA4z2EoPLfDuA73PfsR2h/9iCbmUZ0ZpHtiReF5f5H4Y/8Up26zdQ4eJKDwDoqwEnRg+g3unilHsqS8mk9jNnhzG+GqtbZ9dyS5hy5iPcS1HTrcb4HqqDxlVcw+qMIevxD9O+a7Wtb4OLL+g1P6fABY+fKnvJIHF0E6bSapRsiJgVphQXfwX19d4VvMjdf8J4nkfhSa9v0Hjow0G/z+G9Vm9Jasf/AY8wgNWWidsk+Ji/H Np7YVaCe 43ZPVZMbUMt0NIiyrGh90R1V4yFtxohSFicXI8cfTZEhRaE1edGzDcc7J/poY3Rn5u09UwUltKaRnUoizQ/4LG0NvSg6Y5RQzgTLW4LpElX5ihTzHv6QPo1/q5lrA/UBGcDKIuG0oikF+bzGil+LFVG/z5S5WRzxwakRMNmWkMN+2immY1FY3UD2FoM0KtyT22OmaFSEz7iY8QO1+z2Lm6zEWFVy9TD6ZVGPTzbjlSzxx6HWig78a/3GCQ7nf5EluM7Ut3GjJ+9f5xnWg7GTCtnrli2LAOuA1eSwDXOx0JYgbyps80Azaypbnqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 12, 2023 at 11:50:08AM +0000, Matthew Wilcox wrote: > On Sun, Feb 12, 2023 at 11:54:45AM +0200, Mike Rapoport wrote: > > +Note, that memory banks may belong to interleaving nodes. In the example > > +below an x86 machine has 16Gbytes or RAM in 4 memory banks, even banks > > +belong to node 0 and odd banks belong to node 1:: > > s/or RAM/of RAM/ Thanks > The "Note," is superfluous, you can just write: > > Memory banks may belong to interleaved nodes. Ok > And I think we prefer the newer form "GiB" for new documentation. I've used Gbytes in previous examples, so I'd prefer to keep it consistent We can swipe s/Gbytes/GiB/g later. > > + > > + 0 4G 8G 12G 16G > > + +-------------+ +-------------+ +-------------+ +-------------+ > > + | node 0 | | node 1 | | node 0 | | node 1 | > > + +-------------+ +-------------+ +-------------+ +-------------+ > > + > > + 0 16M 4G > > + +-----+-------+ +-------------+ +-------------+ +-------------+ > > + | DMA | DMA32 | | NORMAL | | NORMAL | | NORMAL | > > + +-----+-------+ +-------------+ +-------------+ +-------------+ > > + > > +In such case node 0 will span from 0 to 12 Gbytes and node 1 will span from > > +4 to 16 Gbytes. > > s/such/this/ (and I'd use GiB again) -- Sincerely yours, Mike.