From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A3ECC636D4 for ; Sun, 12 Feb 2023 11:50:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A974D6B0073; Sun, 12 Feb 2023 06:50:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A44746B0074; Sun, 12 Feb 2023 06:50:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 932E16B0075; Sun, 12 Feb 2023 06:50:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 87DEC6B0073 for ; Sun, 12 Feb 2023 06:50:33 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 54BC7C0D32 for ; Sun, 12 Feb 2023 11:50:33 +0000 (UTC) X-FDA: 80458472346.05.E84E38E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id DF10C160003 for ; Sun, 12 Feb 2023 11:50:28 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rmaO8vWm; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676202630; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F/oUvUqcxxSsH3QTIuSHpDyRj938YvYs4yZVYvuW6Rc=; b=hiv3hRBki67G0uFQXlv6ojO5dZ5+LGp7TEsl3d+ST7LTK4DIw7mx19wSNeIGRdoaXZTx+n ukOKK7VjPPAdXzPwUUy76NNsp0N6p/Pk0R7f2r6OqTSR9W7NvX4jfvH3ncVHr53wIgEI0M I+ek0prqEX4CvfKf7u6WXvPUtQD3XB8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rmaO8vWm; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676202630; a=rsa-sha256; cv=none; b=BB11kjRflbvw56zwYMewgGsBogMqpyg6Pw7m7u7aVAm9N+JNRpQwzH392utdXohFgve+ia ejeJNK2QG1+hQYRP6UTMvcenbSv8B9cOPlnpNoQFeTNYO8r4NFoIVUa0DIkmfBwtrctBGa CI4HHlZFPZzt/38E9UF0ZBUMC6JuV/I= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=F/oUvUqcxxSsH3QTIuSHpDyRj938YvYs4yZVYvuW6Rc=; b=rmaO8vWmZ2RMO07OUH3V7ba7S8 P1CwTAdZQunhfRFsb2o20pzOAlNCcBth+jahyoTS0xevTa+vwncTRpg9rVHO8blya2jZbbjmlQnca lk4pIV887StNb+63EpDyZaZG47FSqzQSTAUXG0raiMj0p3IsrvvzWr17tOl/dA6qRWIRBE0Wh/VaO qhKEh+fo9F6kaeaEHEOl/t6zBISbcYe+taXuuCiReEgJayAy2ZBtIKkZGQWbOKVRqp7EegNcEd+VW ZhvPfav/OSx8HIul7vfUkYWKNG9XWiv48YJ8hLaaT/jDNhPB0srzyLOCwG+Ekys+nqbjbEJw+4beY qhPJc5Hg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRArw-004pM7-BH; Sun, 12 Feb 2023 11:50:08 +0000 Date: Sun, 12 Feb 2023 11:50:08 +0000 From: Matthew Wilcox To: Mike Rapoport Cc: Jonathan Corbet , Andrew Morton , Bagas Sanjaya , David Hildenbrand , Johannes Weiner , Lorenzo Stoakes , Mel Gorman , Michal Hocko , Vlastimil Babka , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] docs/mm: Physical Memory: add example of interleaving nodes Message-ID: References: <20230212095445.1311627-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230212095445.1311627-1-rppt@kernel.org> X-Rspamd-Queue-Id: DF10C160003 X-Stat-Signature: yjdmr6uy6g77jgriqsx9993zf4z8o36u X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676202628-769914 X-HE-Meta: U2FsdGVkX19vmRPPT/WhI/M2yAJSV8jlDj15pIcM8pgNm5hqkzpdc5uaNi8L8AX4Waj9RXcDPq2HOXWEjxUtP1lc19xGmKGtLJtBLQhZSh7A3r/b7Eu6AwQqw5aJaS9QOFKpu93+60hprbih6gdT5Fu8H4u7DuGyfrKJHMCzHq0GckNZ2dj0sPeiZm2mCYbdvvpLgcUeFZghbKW2FU49S/UZpZYPpZyrb4JJJ7mns+NeIrgdMm97Y7u+Vpn0REJMZCEYF2TdR4mCQ6/uC7woGB8fAWvFB4iX4SZtileyC6ElUZabM5CpYaVon+RAs/gr+fVHET8LCL+JueE07Sc8HkxWZs/68OSlFo1KhHRDVMHoKnoKLByLfP7JZaItlLOIj+Gv7jmMBlnuUWVmZpb0BtM2J+zu0tgUbxNlAwUgtEq6+y7npOGqWoIY8jMBCcgFlaD55nhEMwrNQSXiG9V4HEULZipr7QHlqdvm/MgNxlkdecZSY+eDD9oQ6kZtUmY6GNYlAm4uzuLIyfKnunsEid1/UPRzWKCvZsuqxQAINGo8oH7V/aaFrwoYdRpgyCiePCQLbkX3RQIRQ2s6QnwBvBoYwhVHYEWZh+s2PzCWY8sySkUKHqcMazJq360CTxYNcuza8nYpYAjm8epFv3YdrPO4Ipl6XPPr2+VIYp2dsdA4Qea9qrnl0ETSqewmj63S2zl2Ch1QjdtoEq/nTuuqEoGn0MOJ/Z26QebDI7tx2MqKehFav6t9e8KM+LZVP9ly7gQDasrfNQ6Lq5vwN1Yu83Iuhu8t/hmwsCvjizfF4aiOeEVYzHB30UhD0qiKgbji08vvLerG5bSQY714mLmxTuhn2qEUY0avx+gjmEl+DVpHAJSZGjyNMq5oE6/VuPTRCu+yu1H7oiBrX2PwcjBzWan3N7DzKHotuZ7jioGOKRP8sP17X32yKL/4b1q/QPPKyB8+Kjntufo+HOO+NlE RK8Fg2fJ fOO5ciMc4Epbol2MF7kGgU1hX6S6uhldcSdo3a94BNuLxu8EZjQZw4GCCiV1exRchot2FSx/X6lXwAkifStopXBrKwqPMjFp8E+C8F2fIy7/leb45Y8A7oUILBjOtZYwp05fkRSZH8jI2XiU4oo2XWp2nxdZZ/GGLOqQ2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 12, 2023 at 11:54:45AM +0200, Mike Rapoport wrote: > +Note, that memory banks may belong to interleaving nodes. In the example > +below an x86 machine has 16Gbytes or RAM in 4 memory banks, even banks > +belong to node 0 and odd banks belong to node 1:: s/or RAM/of RAM/ The "Note," is superfluous, you can just write: Memory banks may belong to interleaved nodes. And I think we prefer the newer form "GiB" for new documentation. > + > + 0 4G 8G 12G 16G > + +-------------+ +-------------+ +-------------+ +-------------+ > + | node 0 | | node 1 | | node 0 | | node 1 | > + +-------------+ +-------------+ +-------------+ +-------------+ > + > + 0 16M 4G > + +-----+-------+ +-------------+ +-------------+ +-------------+ > + | DMA | DMA32 | | NORMAL | | NORMAL | | NORMAL | > + +-----+-------+ +-------------+ +-------------+ +-------------+ > + > +In such case node 0 will span from 0 to 12 Gbytes and node 1 will span from > +4 to 16 Gbytes. s/such/this/ (and I'd use GiB again)