From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37588C636D7 for ; Sun, 12 Feb 2023 16:26:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4F7E6B0073; Sun, 12 Feb 2023 11:26:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FF9D6B0074; Sun, 12 Feb 2023 11:26:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89FCA6B0075; Sun, 12 Feb 2023 11:26:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7A83D6B0073 for ; Sun, 12 Feb 2023 11:26:35 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3BC6D14126A for ; Sun, 12 Feb 2023 16:26:35 +0000 (UTC) X-FDA: 80459167950.10.6C0231E Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf25.hostedemail.com (Postfix) with ESMTP id 6D839A0019 for ; Sun, 12 Feb 2023 16:26:33 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WHZ1dOpc; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676219193; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u+HdSis97kzGA6M3/tFi3etQsaKiS1sBdXWfVQh5vJw=; b=AxNRv88/aa/RYWwTF3BLBUAodQe/iVkEn7tEfgAVAYep4GuFlygO1yqu9yZdP1R8o1BPP7 jEpo+56uWB54yqBXtkdEwZ9b2YPycFO817MVZEs+9aq2ynnhbzF3TPCx5qgs4+tzeVZGM/ DJoOKRIkHBTLZRFQO2qu5lG7qWuVDic= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WHZ1dOpc; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676219193; a=rsa-sha256; cv=none; b=lBDhMg0Y8PGt5+in5UXhNiqTZTUeYeo6wjEADoRSoxF1QywHE3QTFS2OuGt+LsvfG8LRJ5 XV4AiwIjSCRR7P68l7j5kyYJeQjSTkpdB5EOLq2PiUmlhdqExBEBSikIt9cj785D1EO0Zi Z5/t/fqKJt9Jkk2mdbtDnu9hAUG/Ijo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A62E8B80D33; Sun, 12 Feb 2023 16:26:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD8E1C433D2; Sun, 12 Feb 2023 16:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676219190; bh=PHaVWIiDiKuPiyj9CpZVeYgSGEpSXGrmMvcZSQN2a1w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WHZ1dOpcNlciKJV60ceMatG/ln4gwqhaZjp3ZE5RHjwYiIsNbKgPfiLOmHrkEtBNT 0LBqZ54vZ15wL/dO9fbXmNbGA5IZXywhsLgmuVeT8Mxh6nsVQ2XXz5mIslqXmGe9/g AzIa8vrmuhuYMA0WsrKUzqY1iJ2X6VnzRjkJW1xeJOjb+i+e+3nJ6w3tM54rnCLk9r bZn+yK6CEohAWfFi7LJuH0EYEVZLCz4dM4UGrtoZL997U+pcfquEEXsVB3fsWZbkQi 9pDJGG+mrF8objq54yFjgqFeB5zDvEOjRdynh9jYkrT7/GybhbLGr2AHJa/rTTFxa0 QsuwvU4Larsqw== Date: Sun, 12 Feb 2023 18:26:06 +0200 From: Mike Rapoport To: Guenter Roeck Cc: Andrew Morton , Arnd Bergmann , Brian Cain , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Greg Ungerer , Guo Ren , Helge Deller , Huacai Chen , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Palmer Dabbelt , Rich Felker , Richard Weinberger , Russell King , Stafford Horne , Thomas Bogendoerfer , Vineet Gupta , WANG Xuerui , Yoshinori Sato , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, x86@kernel.org, Huacai Chen Subject: Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM Message-ID: References: <20230129124235.209895-1-rppt@kernel.org> <20230129124235.209895-5-rppt@kernel.org> <20230212161320.GA3784076@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230212161320.GA3784076@roeck-us.net> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6D839A0019 X-Stat-Signature: 6z41us384r4sou9zyr1xrhbfspw7bfxe X-Rspam-User: X-HE-Tag: 1676219193-707158 X-HE-Meta: U2FsdGVkX1/GvywbuY887mbbwEBH5/nB9ds53JhC8kGWMuh7Myz3Vd3Eo0RZLkXVuoKWApMiPjPaBlBUqu1d+5RXtutzLDigT1z/d618qlMLjBZeMKIbuIZm7Wjli+xqdnlU959y5nbJZsxLY/fzhCDWvsU8U91T/4otzSe8ZjUerXbH39Eyt93xk66TWr/lS92dZ8dD1uY0Q9y8CW4gd1RSgnK70uynaDP5J3axs4QylPsFymQYmlR/6m7iFbe4juHtT72QH364TA8cQlrSyRaO6n+hT0FGSqleKULm84r0ByiRdUeeOvMJPDQ2SNpXWRvLU00q/AwAPL4UtpKnMwfv+S3n5QQkFlDcAITiYlofY5BXhCBEyjuEOaRSDKBMpLgvg4TSvhh+JxC+PfUqTXhn3oSy2xb0NhU/eAzT1UBbaEHSG9zRm7u1t3QsVGSnO4dFK0OZZN16jibTrBHBl+2SBQIdtr3USQ8+h7fNaN4o3H4OE1zMP8cb0FmL9vhoZvpnYf8qH8zeLe9D9DMuQffnc98a0opOwb1XoNOeP9uSnp4G8zLUYPgJgrlVcgn/YbnKDRYsyulFplr4IJJHvqlC5pqSDU0vIynbhtMtOPIAbI6IU7A+leXTONsWV61IHzJvbRCJuM9+C0eGKhTb264AA/QKN8G3EsHfqca7AT6dnV9XdhTRXz8EDpKujBDLh4iw1l0lE8u3r94vla80ecKtn3gPoVeRanobUlmcOoTi7/awpvF7FLG5dHtAfAkluqFlASbNZTPOVc06hxKiEBOy4qoPuOloEQ/CbliojddzdXJ5SCHWig6Fq9zSX7sHJwic3WzXM3wLQWz4ZLQwqzvOFiBRZCWrImWt567S+/hWVh733W4oYl9h4D0EJhPwjKDRaMUAKtqehxjDiNb4Rnql+ZpXcZbJvIWLq/TTsv0VwVLCfQ1N51WyjfFrYKMws0KINjI5j/Qe9Y/6N1O Be/o91Wu YNrMQwcN2t3u8XdqM0HYWgzPBImCn+eyfPOLSeospkrr0P31ddHBNu9CFPDAzL2hSGO/O5+QmDDU9KT5V6/WTxP7jpAU9BL1b2vTpfPeLbClOZLhsfwnv5McFNaDSThYUAhOva8p44XO2wLFYkOHkAhbR4oLvIeBJRbu2vwtI2G+Gy3mtOpNiQahvE2jjJTqwEcjRgwPkrB3lLd6HraukG5XLy7S0FfLWWmSqqJbDyFO1AXSNXR/bqWGs75BnLPPBNJNC4MYeqTymxVsrRPYH+xf9eOpJr2VXThbX904mmkM9+0hbk7oAtiqmmUt24FGZNM7rRMM5/Q6aDg4J6P4TLwm4++t/KdOKEWb3SwtUnrYf17MSCVqAgixZI9FBxJEKEtALWbQDmSnSL4hx38lu2S52tOk5m4OVgGzL2/ThH/V4fvPRgEQ5S8mOIWoGGe5SAnZGvMUyswQ49WA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Guenter, On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote: > On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > > > Every architecture that supports FLATMEM memory model defines its own > > version of pfn_valid() that essentially compares a pfn to max_mapnr. > > > > Use mips/powerpc version implemented as static inline as a generic > > implementation of pfn_valid() and drop its per-architecture definitions. > > > > With this patch in the tree, sh4 and sh4eb qemu emulations no longer boot. > Reverting this patch fixes the problem. Can you please test with only partial revert for arch/sh? > Guenter -- Sincerely yours, Mike.