From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC47BC636D7 for ; Mon, 13 Feb 2023 08:28:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 541576B0071; Mon, 13 Feb 2023 03:28:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F1E36B0074; Mon, 13 Feb 2023 03:28:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E0656B0075; Mon, 13 Feb 2023 03:28:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2EF396B0071 for ; Mon, 13 Feb 2023 03:28:31 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EA708801DA for ; Mon, 13 Feb 2023 08:28:30 +0000 (UTC) X-FDA: 80461591980.23.DF75C70 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf26.hostedemail.com (Postfix) with ESMTP id 5874114000F for ; Mon, 13 Feb 2023 08:28:29 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=yNP7CW38; dmarc=none; spf=none (imf26.hostedemail.com: domain of BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676276909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wxlJQMevKqE2XAdU0egXxg4nlul2OuANdQckNSG1zd4=; b=wwwT3Yyg4w1Co1CiE/VfUTm0R4NvwkUxMoXAmT5mVWe2uw67dZmrNyELx2YfgyCkzWRH6N tQWgB+mAW6rMjUlur0k0Brujif1Kqtz6j/o1ApXbVEI9Rr6UMZYh2i6my1YbFZCWORgnRO cwMroreV+Toab2CWy4ZghgmTspzTQSA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=yNP7CW38; dmarc=none; spf=none (imf26.hostedemail.com: domain of BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676276909; a=rsa-sha256; cv=none; b=FQPFQ75RzRbQK2lxQoo+VR24wzP82HpU3kUDxJElAURg/n7QYyvhhM81c4xnAhp+WMSB7X U404eXRz37GAfnqKOUr9J/uHMnK32kClSgbsSLrOcUsi9axQ2iBDUHnad6xs94LiQQNQgJ ygdq7DI1tslB+NikN9dxiM6nNx+U2iw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wxlJQMevKqE2XAdU0egXxg4nlul2OuANdQckNSG1zd4=; b=yNP7CW38zlbi1rHHEcCfMou0KT pBdi8juRpMvwvwsEnP/Vq/QjAnZo10E1WpG1u3TH7OSoKL7pzU2oVLEHQM3CSA3zt9Feeenmh3lAi iFfsju82cjg5khya8v2Lfszhk4v7UCJG+LLjjOo+AKw/LwLf1DWVfay/EP55rh1FTTrcOK6QTRjgn RFtVVbLyeVK5Rap9dFg2+X5Br058dC8Yic3ksaaE3Q1dO5rIzAwHcVqK/sZsRa79HQAJZVCIBxRp3 2Fa9GMSUf/i4TNMahqlxJmbm+PiQ5er+7uIK+08KaTkUMgQ0vuWb760ZEXkSx4RdsVMsA0vFJMHPo ts/Z9qPw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRUC7-00DazA-3L; Mon, 13 Feb 2023 08:28:15 +0000 Date: Mon, 13 Feb 2023 00:28:15 -0800 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v13 03/12] splice: Do splice read from a buffered file without using ITER_PIPE Message-ID: References: <20230209102954.528942-1-dhowells@redhat.com> <20230209102954.528942-4-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230209102954.528942-4-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 5874114000F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: pji7wpfmbtxk9g9qnaypemzazgkoiqmh X-HE-Tag: 1676276909-344753 X-HE-Meta: U2FsdGVkX1+XyZSdggtWlP4tWGOJUuJiqdJR3yojJ5gI/gZDB8b6c2jkBD4VjMI9LuN33/H6N+LxTjkgI7sZg8RTFST3lHxkmnBSWF/jlyyk/b9UpobCIZcbR8J6gH4Uhu3Aqc18tRdVESHXySHbEpAj8PxO7N1kJ/xXnTdTvpOkBA/nuLxftOkwh0VP1eY2nWzCP0q0T/7fO1nZwKfbVZl4+7sq54qetwSUKl9EpkVnTD4Ln96Zzx+vvcKy+zV8QRHDo+bFIxnhMFPJsNXkeKqZcY5StC6Cid/Wh3a+PnC9ZBxBB8Vtzx0JbZ+rlUS1PzuQN6zgI+aBB9WFGhW7lTpSEQ26QJ6nVTEB6c0NQDQlqkrCTC1bu0+pGqb98x0rmeZCndaqZVGAXChrjyccM3iCxPdzUdMZ3MHeF8FiCNEeNv0LT5WX5r9CLT2cmikPJ0FQmMwZoRFUQUpr8Sx9J/JoSTAJIN6Pi1K3hmhqxNlISJCjOWBeugcwintJy47Oi4mG8n2FdJKKdTFINaQFdARJcUPkdPcXC83xojkbOHSJB/POoBtoxbmLvMsKfPVRBbVbzxVQEhpDK3b9XG7uJyjRc05Q5/BJfXwfT4Gs0vZV9gcMNhm3V5H/2y/h5F25WLIxodHFCfxQN1V5Twi8nHVirysBJDSUDKbdGwsUx9cmNS165SajuYpwjZWpm0S9WC+yKdXoHtmcPbST3feZPmxIFi3u/yO6Aj/BQa4IwCyofbrHyJZjMwklpV3h87u5VNELYQBCNVuKs2GozYNxlmw/HhNXACsgpc3NTbsUSg2OiroIirHmXxjnp7SmtW8ENxTT9lA8r206/zg2fy6ATJL0uuL95hovv/drekXComG9RDF+yYgKvHX1lJxdxEK/LJlJdUVNuOEkor6QSyFfL+TlgBx19Y3nHfI8Y8PgvpKg1PlgoeU9/Lqons9E+WnKEUOzGAIFKFoVQ9w7gp2 Apw8U32s 2sJ5GgOGWbvPaogexWQNTt7kwTQdvIfQrWPKtYOXpXFMI9jMmXozC4mdTSMTFKGyMDto6cq8wmKODvULoDRB0kHUY2lCS3vOe8cvyjMg5RPgdEmwIMWXjKax1H9/izmsmTJpLdea8Rjtm50LLcf8JA/9fCj10xjZXcr5n+jpe1Dux/ymExRu//p2o3mT9G34PEIo3IIfXSikfGyIDilwegxSc9pm9Q7TaAk7KIIfV6Yu04GzE5aXjC04MT7vpgRsIO+YBstu5UhtzcBo/DeaD59dHKjpyFKdy9X33OuuAGlNoC+vn+5E43JtJMh+hzbbPVApn83+WM6AvykWygVuxuh3JLNlMxPJor1XiiZHmX0ge4SrrAFZnBN1mPYHLjh0j3vPRTBEnAdkf9JquLjUhNUUtmDs8rhJQFu4XTvqAEUO5YENes6R/vMI5msM+oF/bsPWPAiTQlu9/SQ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > The code is loosely based on filemap_read() and might belong in > mm/filemap.c with that as it needs to use filemap_get_pages(). Yes, I thunk it should go into filemap.c > + while (spliced < size && > + !pipe_full(pipe->head, pipe->tail, pipe->max_usage)) { > + struct pipe_buffer *buf = &pipe->bufs[pipe->head & (pipe->ring_size - 1)]; Can you please facto this calculation, that is also duplicated in patch one into a helper? static inline struct pipe_buffer *pipe_head_buf(struct pipe_inode_info *pipe) { return &pipe->bufs[pipe->head & (pipe->ring_size - 1)]; } > + struct folio_batch fbatch; > + size_t total_spliced = 0, used, npages; > + loff_t isize, end_offset; > + bool writably_mapped; > + int i, error = 0; > + > + struct kiocb iocb = { Why the empty line before this declaration? > + .ki_filp = in, > + .ki_pos = *ppos, > + }; Also why doesn't this use init_sync_kiocb? > if (in->f_flags & O_DIRECT) > return generic_file_direct_splice_read(in, ppos, pipe, len, flags); > + return generic_file_buffered_splice_read(in, ppos, pipe, len, flags); Btw, can we drop the verbose generic_file_ prefix here? generic_file_buffered_splice_read really should be filemap_splice_read and be in filemap.c. generic_file_direct_splice_read I'd just name direct_splice_read.