From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA756C636CC for ; Mon, 13 Feb 2023 07:54:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 115D66B0071; Mon, 13 Feb 2023 02:54:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C70B6B0074; Mon, 13 Feb 2023 02:54:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED0EA6B0075; Mon, 13 Feb 2023 02:54:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DC41D6B0071 for ; Mon, 13 Feb 2023 02:54:46 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 92705140B9C for ; Mon, 13 Feb 2023 07:54:46 +0000 (UTC) X-FDA: 80461506972.11.0C36787 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf22.hostedemail.com (Postfix) with ESMTP id B6DB8C0002 for ; Mon, 13 Feb 2023 07:54:44 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="P/NLBLn1"; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676274885; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jZwgIxUe04sNqXZPGkqLSv0SZ4sgNgdDmcRTEZrvDwQ=; b=Ahgidhr2icfJs8L68x7hFkAzNnwwkgnwkJmuL/s2LOxCVSIM/czO4OSPewa4q/3LeM0HrQ cGdXh4RmZr7b6u1zPinrHxxfSy9UwfxBaglNn41w+oS4RKjYUGRBH+f99p5n+ZhbujtNq9 umQuQvMPQTF21ZQo5peQ9YWXcrvxc10= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="P/NLBLn1"; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676274885; a=rsa-sha256; cv=none; b=0P/EEPXSI+hoHk9MdvhhgkEkYpmce39b/NdubHvalWHgYrDWWXldAc8spLDAXVcWvCvoqp jI2bFg0a4geVX8SIDth5mGyRDpfYwO0PczH6B7jFODHFoz90Qn0AXnxvQvK7NKc4uP5MTc nPkjz/xRXhmQK+Hak5WbyulsGjnr+L4= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 16B7EB80E01; Mon, 13 Feb 2023 07:54:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3884FC433EF; Mon, 13 Feb 2023 07:54:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676274881; bh=6metnuiv9QkmKFu+JTHLVBvZLre3nFtuNi3AR7PlA78=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P/NLBLn1QBccO0iLmwEVdjTRTOu/1JTVdr0CvbgYz4ThLcAoENpkQwi1mRk7/P19V Brn+rbVYSD8LBBQWtetps+o6x9tV427CYirqerxd+gmGggehAz5OXTZeiD3MkT7U29 s/as2HenQlPGtPPTTf3fp/G4jLA+MmtrrPcey6hAK36CzGgOAg/0LtwnODYIfT0DI9 MUeph4dw/P2V8jMyhN9SftHlhcEV/JNhGKIKb6cMv7netYSdbt356AlVVkhPoiPUvd r4aExWVaj3CL3McIngU/VdH3ENcuJwfiC6rBQVcgRCzZo3MtbE8U1j5N/4s5pn2pxp sfCWQJUUPJk8Q== Date: Mon, 13 Feb 2023 09:54:17 +0200 From: Mike Rapoport To: Guenter Roeck Cc: Andrew Morton , Arnd Bergmann , Brian Cain , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Greg Ungerer , Guo Ren , Helge Deller , Huacai Chen , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Palmer Dabbelt , Rich Felker , Richard Weinberger , Russell King , Stafford Horne , Thomas Bogendoerfer , Vineet Gupta , WANG Xuerui , Yoshinori Sato , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, x86@kernel.org, Huacai Chen Subject: Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM Message-ID: References: <20230129124235.209895-1-rppt@kernel.org> <20230129124235.209895-5-rppt@kernel.org> <20230212161320.GA3784076@roeck-us.net> <15a2c023-fdfa-9543-ac36-a846e5f8a000@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15a2c023-fdfa-9543-ac36-a846e5f8a000@roeck-us.net> X-Stat-Signature: jje4gbu3nr681dh1tyueg44cs5r3wx6u X-Rspam-User: X-Rspamd-Queue-Id: B6DB8C0002 X-Rspamd-Server: rspam06 X-HE-Tag: 1676274884-128200 X-HE-Meta: U2FsdGVkX18BkU4bPAzdq3K/3sYlSY6egznrZmsXYDG8CYpOK36GZPJoIOjKSYU8EMB4531/eZ0uJOmpIzORzO5ho1I/u+xD8cM8CoUSOQdGk9iLsEu9m2GkdvXQxvBM7MUtERvO/2VLPjs2zWwZjddyUBiSUR2kukpMhnLEy+W4AkaNkDhAJogKG/AG7ZgXPfmbz39B4DWmdnuaxa8FG9y/AAk5lPtScz4NIAdQuJ1tIsK/bpepnTaJaDXgYzDuqnX6aeUN/zPnbfRL8DVE3eyS/liFX1JagbhtfJBdPggMYkL1nZcVM7d68Be5mcnwfdPV0e7BOcTwkv6ADeiBB/dhMmOfkD9CsDkT4SWBXsjUyxSGeDWLVfOjzIDyAKbAkRMwD19CCFBgB62f/Aj6VXPnzWfStvnbZ6FHm4XZ/an0tsR1gtvzDEkCbC4U5t39dC+FwOGSvNK5BKgapiHbXJalO9EqmqKuLvZLxeD7D2uGZjSX+tgZ1OCqwVZfoB8WnW8fCgHzNg7LtoSdSAD51rayyk/ZzzIc8CIuR1443fyoaXIt2ieA4RBTKQbsTQFOeCgjuE38W36BxZfgXad9knzIeeBDS3nCWBKyyQg9qJYPPcFcF7me7nOlzH9Ok9XXKc0wOX6cXMaFPRVVdymnuLHU7Jg4pZY+JrD9nwmnUHc92vssccWrLzvdYaaqBABmeCTHVjg9zi9glFHDAYqaVTg9m3kR62Ma+PTzi9qxC6qPlUFK2DW8GBNyouOpJ/rBUuTVSQmrq8827ZncgGr6x48FZny6aZQBr6BBkbeGvoEnfCWhcT7BzeAqMqO3Xu8OyKP80HNXQQwg7x8pgBNGdT5kJqmdyUrHFGanwPcUjuHzS9UmTC6eSWAmPavXLqrzBSNp4R4t5N0/TZdLPWYVXEbuGWwnEjKubXVhNMCSIUA+JZKi87MqrMtIrNBrzuunRZuWIDjDK4aH2uxI61E dJZ2ltdy EPa/93dUSSPqcLhvbP4aISN21AYrRJ+/WbbRieK0TfsYeTcR2U+sVX+vtHFVst0V8vCdCgu9uM1xcW659Sv1AT+TjHDOIaz+gqi9q6R3YIsm/BalL32ro1LMSwN7X+LceZuHcbYHQdIjNquawP5sY0E8OBQnc660n2uKHzfjPldYxnSfjGG+Zc+aS00nlDy3kTx68Mi4yctBV9K7B54FsxGWzot1j75Yrez+801luHevcjcIdVqUC8f1Q7dzIycg83YBafQ63siY/RVsCVdy185JK5v8tKW47hHvg+P4E7WHVxZWJjZTb553c35Sm81KhOS4Ra2MCujqUGJkhthExHZ2dZsb7mDH10LXrKoa+ALTim4mZycGyxr4nK+kQ0P6LZT2s3fTxAIY4KoDy9JiGLYiFBqL9QzPxlZ3x1pw1w+Wxg7zGjK+FdYyqFpxnJtcjcwR5E2niX9unNoY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Andrew, On Sun, Feb 12, 2023 at 10:37:15PM -0800, Guenter Roeck wrote: > On 2/12/23 17:26, Mike Rapoport wrote: > > On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote: > > > On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: > > > > From: "Mike Rapoport (IBM)" > > > > > > > > Every architecture that supports FLATMEM memory model defines its own > > > > version of pfn_valid() that essentially compares a pfn to max_mapnr. > > > > > > > > Use mips/powerpc version implemented as static inline as a generic > > > > implementation of pfn_valid() and drop its per-architecture definitions. > > > > > > > > > > With this patch in the tree, sh4 and sh4eb qemu emulations no longer boot. > > > Reverting this patch fixes the problem. > > > > This should be a better fix than a revert: > > > > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > > index 506784702430..bf1b54055316 100644 > > --- a/arch/sh/mm/init.c > > +++ b/arch/sh/mm/init.c > > @@ -301,6 +301,7 @@ void __init paging_init(void) > > */ > > max_low_pfn = max_pfn = memblock_end_of_DRAM() >> PAGE_SHIFT; > > min_low_pfn = __MEMORY_START >> PAGE_SHIFT; > > + set_max_mapnr(max_low_pfn - min_low_pfn); > > nodes_clear(node_online_map); > > Confirmed, this fixes the problem for me. What is your preference for this and m68k fix? Fixups on top of mm-stable or v3 of the entire series? > Thanks, > Guenter -- Sincerely yours, Mike.