From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CFAEC64EC4 for ; Mon, 13 Feb 2023 10:19:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 256DA6B0075; Mon, 13 Feb 2023 05:19:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 206706B0078; Mon, 13 Feb 2023 05:19:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CEFC6B007B; Mon, 13 Feb 2023 05:19:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EFF456B0075 for ; Mon, 13 Feb 2023 05:19:08 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 90066A1398 for ; Mon, 13 Feb 2023 10:19:08 +0000 (UTC) X-FDA: 80461870776.01.1C6AAAC Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id 69610180012 for ; Mon, 13 Feb 2023 10:19:06 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=4raiYwiG; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676283547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=szHm+HvGboe4zElnYyIS9I3M5ezn3gwosKJMm81UK2o=; b=AdWc67I8SS3pcJDzagh10D5HyT0AN7WU1OimrcXZIrbNHTGldDbrZiY7ERNyJP+ASoauZc 6o0+ZSSoZjbEHp7ofBONcYkwj32qC8av5GCXnqmCE+JEMjO02ku5bE0Yh66eqsTzy3eD2K 3wuEk7Lk6A+7BWcajc6stkixUkKvfhg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=4raiYwiG; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676283547; a=rsa-sha256; cv=none; b=IlXX2ImmZMnU3BQfZVwayRh9UZiGLphbY5Q2VO1PzlCOD6um+x6H6xwGQG+B721Fhv6EIZ ce87a/BBF3A2ZaPGWHKsCb7eXwcburC9MKXFhTTF3wTD1fui5zkJJxaMCIH/r5TUbUkK+d yJNBgDeKCUliUbkzHLawrEEan0hakbg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=szHm+HvGboe4zElnYyIS9I3M5ezn3gwosKJMm81UK2o=; b=4raiYwiGmbF9QTaprA787JVha+ ukzcXidyJqobihaG/aamGI8SdzEgpBKzI/9gN/rpadv+v6tiT8tIG5Xf8uy0yZjcIemuSJdtSww81 VXerBX49HpFpDZGzSKhOiuKuBhmIppBB9Qn68/e5+Wj+u1wzKRu68uSz2VD8wkUwRyvAwZ/V9hrgN l8vf+RbafdbnIOiIcLmjV2BpEKg8U7/xKx+VfpZ3Qjwq09lGXGBNsLCuMP6V1V48I8xnznuaOgd+K mmF4NKBzOxh4rDqsoLngtbV4HWWmf3ivQW08PNJOEMdwo6zVNbxrPQjU8HyldQyrMhMK2rb7LfaAe g0C5HWPg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRVue-00E5Ci-0Q; Mon, 13 Feb 2023 10:18:20 +0000 Date: Mon, 13 Feb 2023 02:18:19 -0800 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v13 03/12] splice: Do splice read from a buffered file without using ITER_PIPE Message-ID: References: <20230209102954.528942-1-dhowells@redhat.com> <20230209102954.528942-4-dhowells@redhat.com> <1753989.1676283061@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1753989.1676283061@warthog.procyon.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 69610180012 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: g4csydxbgytkahrhpuk6n1m9nunz9n7b X-HE-Tag: 1676283546-979196 X-HE-Meta: U2FsdGVkX19lfTgyHVhQhFzwObx2A+Su3aiiK/3GyebruuqoVBNMEAZu+vMNKuuJXL6ojNow+0JSZNzn5wXGjoYyZQPUB8/qcxJf0hsqpqquzTPJnNiPDkJODK05EvfpdapNg/B8SD8VqudT8/SkMqLMZxS5Tyk4C/gY1vog0vhnVkn48pRqaYYW6h8hX3Tf0RLeEJa6w7lZL0aiPHsqDRnin68K5ptJ7Y3T1Vr/PnUali78PAncZ32YVpXu/WAqOGpGOmIx4l3LcNzl41KflvcYbrX4AqxagnB23JiRPNr1rN4+JR+1C5yKr0PalboJLdoJeZ4oesX02GMjDm1gd3yhI5jkl7Ydh7qJseMjCrlgoT/vXETN2YrxnTaBehXqaPXPDtyPaT2t1LdrNpSMoXKn8jmeo+j4VWn357hZxpGoMIJElxbv0uJL0uAUvZlL+Ug9AlKRMlhBhI7diXLeAKGhk2/Q6xNmcZoDiilcHid14iugLXyBNFZMbJGcf9NiZipB8BnMf72Td8hIROnH0jsc6i225Gf5u4G7ffCsdOUE2qpdYg9VUvx/3lfG2r9KxJ862ucfYMsTKBxIrEKCCntf43nez5QuqQBFJM+134hrsahWa4xsHHt7LlgyBUYydqIQXFvLWZnL4lIpqfBajnrg/LBuXMYiTOAWwIOsTTGClk0LmM42vhf0mErCdHUSbZCvWAm/BUpItrvNfuZ0m2tZEJ4/Rcy6R1jYZXfxaaUJsk4VlGiV05fnKYLqHdZFSXxqBzD+y2gxRAPrnRIL8llO6SG6HoNUAKIvCpnPSRpfaTAM/kzqTICrCWNvMVYvT3kJW7T/hAJMqVhSAfWJ5HX+YQW1GzDh8LbVknw7uVLW4e8XvPt98NVC+ZG+yy9HqrY2eZh98sn+ZrMQSO3nFCgow9WMfYIKjKve164MyWZ/vnceq6fJP19sxYtL8cLe0XpzBHGLNWbnCYzoQGt KCNwY1wl sLk5/+NmJ8xtjRXjP3OWbniIwUeBOlQYdOZiKOs306weXfUACuXQz/CjmCI4KKsf0aQN036VbuHxdEhqK6tsTU34EdC1oyrDzs4jC0wlWhGRrSYerNOugdbV/fxBbUlzCadfBdzfcy+ENkcWCoPFNAktjrDHJRrUhnKlC8w7Iyagwnk76+nuuFvwFIiXL4AV2B8kRPi6YfwvWweSpATxYZ8VnIpZ6i4WKom2VFngAJo9pwa93WigoV0ylDq9cWcDXOOo02Ksn+iAuu4HXk1J5rT7kMF66HiHck/qTC8/eWtRoGgFBabzG1cnBepc96C1P85DgSiWgvhEKFUXnxixUHVilQezKjtr3EAiZlRzVYFRdbHk6S3nkoyQAJt1PmtT6wrFoinLKTj9oICLstSudGoaVpP2OaafsVN8uyux7nc4+NwXoTwEj1k49iTnzwnp3vvOc9oHaiJ3UWKmnifwfqevYb3MVlWYLlkBS7LI4EnzoXwJlzJ9pprt73NTHfJDRiWPt3PREVdku6bYsoEuJimInaMOxUUYFehOQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 13, 2023 at 10:11:01AM +0000, David Howells wrote: > Christoph Hellwig wrote: > > > Also why doesn't this use init_sync_kiocb? > > I'm not sure I want ki_flags. Why?