From: Christoph Hellwig <hch@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@kernel.org>,
David Hildenbrand <david@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Logan Gunthorpe <logang@deltatee.com>,
Hillf Danton <hdanton@sina.com>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Christoph Hellwig <hch@lst.de>,
John Hubbard <jhubbard@nvidia.com>
Subject: Re: [PATCH 2/4] splice: Provide pipe_head_buf() helper
Date: Mon, 13 Feb 2023 06:45:37 -0800 [thread overview]
Message-ID: <Y+pNEbQklWdlo2tk@infradead.org> (raw)
In-Reply-To: <20230213134619.2198965-3-dhowells@redhat.com>
On Mon, Feb 13, 2023 at 01:46:17PM +0000, David Howells wrote:
> Provide a helper, pipe_head_buf(), to get the current head buffer from a
> pipe. Implement this as a wrapper around a more general function,
> pipe_buf(), that gets a specified buffer.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
There's also a bunch of spots in existing code that should use this
helper.
next prev parent reply other threads:[~2023-02-13 14:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 13:46 [PATCH 0/4] iov_iter: Adjust styling/location of new splice functions David Howells
2023-02-13 13:46 ` [PATCH 1/4] splice: Rename " David Howells
2023-02-13 14:44 ` Christoph Hellwig
2023-02-13 13:46 ` [PATCH 2/4] splice: Provide pipe_head_buf() helper David Howells
2023-02-13 14:45 ` Christoph Hellwig [this message]
2023-02-13 13:46 ` [PATCH 3/4] splice: Use init_sync_kiocb() in filemap_splice_read() David Howells
2023-02-13 14:46 ` Christoph Hellwig
2023-02-13 15:24 ` Matthew Wilcox
2023-02-13 13:46 ` [PATCH 4/4] splice: Move filemap_read_splice() to mm/filemap.c David Howells
2023-02-13 14:47 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+pNEbQklWdlo2tk@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=hdanton@sina.com \
--cc=jack@suse.cz \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).