From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09037C636CC for ; Mon, 13 Feb 2023 14:45:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 820EE6B0071; Mon, 13 Feb 2023 09:45:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D0D26B0073; Mon, 13 Feb 2023 09:45:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C0596B0075; Mon, 13 Feb 2023 09:45:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5DD266B0071 for ; Mon, 13 Feb 2023 09:45:52 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 08A7BAB178 for ; Mon, 13 Feb 2023 14:45:52 +0000 (UTC) X-FDA: 80462542944.19.A21C256 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id 5763240010 for ; Mon, 13 Feb 2023 14:45:50 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=MgfIzSGS; spf=none (imf27.hostedemail.com: domain of BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676299550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HBHZ8z1bM75Bh4e3Q6UBsBCeil4l6wSmZINn4agj1IY=; b=QB0RUK04HlXtSH+yxvziAJt/sntlFiN9YjWGWnYr5AoHn+6ImnNojrhuokN1ds+MunBBPZ 2QeVPRknqfTOjYD2oqUXf1ilfsMYfwnkwVN3tweWYJO1lpsV0O3ghHu0BxxnE/KChDbxEs Di7IAL7If2rMQKJzhNsTsUYlk+M1nZs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=MgfIzSGS; spf=none (imf27.hostedemail.com: domain of BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676299550; a=rsa-sha256; cv=none; b=b2Gjzi0VFPmCug1b22P07yrFaFmxECow+ymcF7ymOYykNp/03wn5VyKFkq5EJQdFQp3zUp q/U5GLaCliIhisi2GV7wroo0YeKQCWEmEgC9AbZi1xVDYYIUXQ/VWDO0dBmRe60cYcyLDy 2P4906YrO2/1VykfX5wHVE8BhSEVL0E= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HBHZ8z1bM75Bh4e3Q6UBsBCeil4l6wSmZINn4agj1IY=; b=MgfIzSGSw/BoxaCoi0mx7j7AHC Z+MvlrozYPzbRcS7kmj0RwEaBDyD/5G6bBzXGBSt+6vgwf6/b6/K4fEbndd/gvctc99Ts740FYM+W vBUMLbJWQLzkbKRlXCeysKMFB7T0GttZDsJd8zikc0Kl2YSMk/+Ss7jFBw9xUS3z4yEVUow125rN5 ACaZmDrxegK2oVNldpkHQ+UNnpl1C4jHK4op1qHq1+SHz3GQ9EFr1T54K1cXdvWP8E+CsqWWe+bkD Cp96ffMGIwAREiUe1I6KdlCWg14bGVKuIjtnhRvbQ0gBZyWSnw477MW9hjwf+QIfIdXR21eWziPmd mZAsQM5Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRa5J-00F1uW-Lq; Mon, 13 Feb 2023 14:45:37 +0000 Date: Mon, 13 Feb 2023 06:45:37 -0800 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH 2/4] splice: Provide pipe_head_buf() helper Message-ID: References: <20230213134619.2198965-1-dhowells@redhat.com> <20230213134619.2198965-3-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230213134619.2198965-3-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 5763240010 X-Stat-Signature: z1adikeuu9jzxw1yiz8joaiqid4s474h X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676299550-505867 X-HE-Meta: U2FsdGVkX1+EPHuHha8x4FDX1LdNQS8E1hmplrlkJ8FSlZ33jMX7dV1oF8Ckm2YQFz8r0XZQ9Jxy9LrWDa0iWPRGXe39B6n0mix/cxbW2imi0ObQdS/TlnEL0XBdUabTYgTR6JzBIRVizYH1PULuur7rvJxacSElF2dGJnUWUwEX3SmaeesET4YCcaL294DYU8kdAn6kBZ9C+v2lF8ThBYvW3ds5Yd1L8nV6YOVk/AhxEo/5qvkJdT7rOkPfU69ZqZEYbWsR9YJ1PaWR5TEC0YvGL4eSU2AdPIzea3L4ibrsabeMLZ5DiY36RnIRhPOgD/0zahzgkblEwCAk5fQ80upgYvTbyTBQPe024XAONOcbvMaR5EFsiKbvLKbzB3AKjLtjJ8ZECQn2xyod3+BMczHlpiEXPa3qg1PuOPJ3PrKRnocMRL3ITM50jOyq58A9zAILDuT+uMxIq1kDfg1jBY0S38q5nUg1Pd0OwjSws1dpQkpOyCJfK9iCUof8Eu5qC8GfDu2w0ZlYme1r+8zxVu/xid/19ZgfoU2t/tj9SqqBG6U2rGDaTpicAqb+fvnmGO/u3EOXYfzD9Y01jmFAYvRB6rUeG40I60a8s7zH+TdxhFcrunuPNARSTha36pkC0+aTUCvxqYmtBA0u4lvV3gziSOxg7ehTdotxIU6hMskX5FJ4OdBXjTCycZWdAgo+XRKA5INOKGMC5r1a7Jn6MRAtO6MeSni54FJ8ZxNmj57IoDhK+OfouxqSGsScNtQOXIA8y3EHv2ub/O2HySWvePy1oQn482crpCS4JCN4ffSx5gdmRYqdSy/4gjz4UtiYVYuOpaMK0kVNO3Jtvqh1/52do/HlpDD17fDG+U2nS2sKvG7xFjMcZ1wb0d/8iTjdXe4kPAQIsRnIMPxCyoLoco0kGtuzp0yM8OmQGycQ3SyjBoEQ11kkUCuI1BFDhTp9rngjchOa7yG4/6U+4jp C665efPP OChyB3QiWHuZgi+2x2vQ+9IQDvXdloA+WZdXujnOAVhpo2Yi3RW5TPg1ivUZ6nquTcOp8vwaHJS6nQIYq3Dco74ewoJrDaCZFZBWsnNhw+AllI6eEQy6jurhxs/ZoFRD7wBdUuEs9EVnumhe2FSB6DaOHyBuVbDCOqBDe9qfoIkFNWxbjnTHCZdlBHr/qcvvOnQcBsgCi/BgbaYtCid9iU3HV4YwgsiZnDfAHRAanD0Id5WW9+kxtHMeVrPegZnotQi4bDVMUseTeJYeEDF7xF93cV4+0/h2tVNJY7IXBtjFkvpQXqmvhVDfhhrvD0ZlZXCJWo/SeAErDPjSFPQgTV5AjQZ8sFFlJhtULUhqahnO6RPkubwhT9d4MRwAiF6wJ4r0/7Db0EkcQiVkq+Mow/DzgpRDkJ3+yMJpzksFOYCwoRaxx7QFY4TWKz7qRCVR6cBsKL3l2DbNBiCM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 13, 2023 at 01:46:17PM +0000, David Howells wrote: > Provide a helper, pipe_head_buf(), to get the current head buffer from a > pipe. Implement this as a wrapper around a more general function, > pipe_buf(), that gets a specified buffer. Looks good: Reviewed-by: Christoph Hellwig There's also a bunch of spots in existing code that should use this helper.