From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6993EC636CC for ; Mon, 13 Feb 2023 14:47:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAF676B0075; Mon, 13 Feb 2023 09:47:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E386C6B0078; Mon, 13 Feb 2023 09:47:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD9546B007B; Mon, 13 Feb 2023 09:47:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B9B4A6B0075 for ; Mon, 13 Feb 2023 09:47:16 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 874E916084F for ; Mon, 13 Feb 2023 14:47:16 +0000 (UTC) X-FDA: 80462546472.24.00DC3DA Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP id D5DFD40016 for ; Mon, 13 Feb 2023 14:47:14 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=2wnEBTPx; spf=none (imf04.hostedemail.com: domain of BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676299634; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GwM3qx/DdQS9UgXafWzl7uUJSiwXYXjhkusEvVBw2js=; b=YY+SJBcJBDYlpyEQUYullQBhL6SsrK4/yUL56gSKRIj21/1T6Fm57DNMr8wpSGury7d7IA aTR+67ilIAyv50akxOELpl4HgWdNTyD2i92sfHnGVt8uEFWnBz7ua4snO/TCXpz0rr9Hvk mM2mXu0AbB4kErt1stNBTrXnZxoo0ZA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=2wnEBTPx; spf=none (imf04.hostedemail.com: domain of BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676299634; a=rsa-sha256; cv=none; b=AVAmPGYvBtywweBPsXWSLz6MKhgBKR+//r3SQJ3fH612ttuex9FRfyf6PJT5v2uRLjlh6S TVRRo2+sVJBW1z1jeGFcIVZMtm0R3pKlQFBZD+v2gqJdEaR/UQpf6Llx5kFcPBb3WoReIq VFt5dwIWSPagEbq+0nlQyQCBeemCsoA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GwM3qx/DdQS9UgXafWzl7uUJSiwXYXjhkusEvVBw2js=; b=2wnEBTPxhSR9eYVZ7ZHOQwtJIN qDwh6bKhXxqJxckVIO2zKnC+8aw+293kn1GyYh/GtHy7hr+26kjcUtFIRf25AX35jUhXKFrCpKNJg 0V+XUchr7YNsWZIitq8wCtUsFwCd+H1xU3o+/lr5JLCfR+D2JgLQtWZnK+yXN70uik/g3zvKZKpUU VI/+fLoRYUxe+S4VjUh/2kTR1Fklvg2ZEQ7QXmvHZ9l10W7TDLR5Rnck7GdCqutHOxATRWjFgumyr g7ZsKinFc0zK0xXnFwsMM3X59uh6ygTlgndGCBDbOtOGOcN+hnLiaByw7eV4fFdVfgIH9Nu5Z8g+9 kryy04RA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRa6d-00F28T-N7; Mon, 13 Feb 2023 14:46:59 +0000 Date: Mon, 13 Feb 2023 06:46:59 -0800 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH 3/4] splice: Use init_sync_kiocb() in filemap_splice_read() Message-ID: References: <20230213134619.2198965-1-dhowells@redhat.com> <20230213134619.2198965-4-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230213134619.2198965-4-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: ecw5b7uhfpy89bxictx6py7ry43hyaeb X-Rspamd-Queue-Id: D5DFD40016 X-HE-Tag: 1676299634-795993 X-HE-Meta: U2FsdGVkX18Yz7nDhgar6hZ1Xm+37vc9KNI9nJwlkrK7epQbZjPSliDDBIQeM3cVuv2QaKWC22yv5hiHAoq1I83A4ma+Eaxu2TOvxFVU1FcS1cSdz4ODvVcxEOuCb3nZWsWesU7/mi/zKs73qQAOlE+Uzqq+D8V9cLzqJtXFc/1mlW+s2/IpEUBAfRvd10fjcq2NMPhLpFLUQ/2tZqgi5/Kntm5ks/+aF5xMiBdaOGz6HcYqL9wjKS75W2BAwJyyNjhbqhBvedW3h2FKN7gYX0QnfWzSTzeyhzf1PYP1mt5NEd3cK1gM6RZWd+fGR5daxAm9EPAJbdzS+qg8jQ5/OD09+Y9wEFU2c2Yjmre7FRnFaA0KvydJvTtnpbZsLKhMcXiaHTic6oHYUwrE+vIk/niTLoPtTMGhtqsj5M1T5i+13DYtBNPACeHAqDmvjofoujFV5QypygMymJpFAk7TERRIZT6XFmkk+Ep7JkaZZlaGMTaZwzOrWyyvk5pUjP85TsHWliDsinvQSnLEO2r2qObBfK/FXiKp9LGaOffbHYbIjUv5HJmJymTUc4uEhYoKNNbwNF4+/PHV+vQ26mTaGFER+RqSmZrWN77pSOn3V2u7NtryPBFOvAMgsBKBlIZA2qvihL6Mmt1D7m8LfBUZXTVm+dZqwtdigvUKIEopmbomN5OI126Ieswb1O9PUKkKim/3vhbv/X7yrVVe7yrMXUxehu7smB55EJXX0ytqTsJSFugE18Z9GC9FHlGRnuQgPue/ytgv0G5TeK0QdNIhIilpJnnRLcd8T3PnUcv7cxNYinFhxALBlN4tQjggqjaOMWq5znsI0B92+L2/0CO+UaV/tFcgqM42YHbfWw9X8tjr4BBlxF8q4S4uYlM2GSUqlCrujpv+L7A4jt4RUxumyucHZj1kV45Bj2E8OatfedT0QB8g3lC7mTGiPXVeRrjbPTKzNdwlCZ0QY0VKTRf Iv7ilQn+ m+OTsn/qkhGsLFJNG8b2NTwkM+cGDc7r/+fDnzc3aXgGwSSFYlRfjneXwXcpQC8QHl0QgAGeIRXXqF27X3dcW+Jv9STU9D1+LJgT2XdIXk0gA/3xbo63IBSixCKL4l8IMPLmvjI1+RSHaLJ0Mh1Wz6E+DXkdxZjT1Cw1vu3xvL5kRyhUTEgNAhYovAbRuz/AFK9AlR6jLynMANag0C3cC1KLmwC3sSgdyubuYpsGXBsELyrhu6sqNzbiVHe1yqc18ZuONK8Uk03MACdmSne+vTZ7+DVcgCK59h8NOJ4nNGJTKLrYlM5AnmHiB+ZkVpXqQ4UkjvRRZ5x4/gfmQd+aWlB/3+hlRfEyASLyaaFLXA+XIhMxtSHGtKRv4wTceN9inDjIokwbeXsVC0kuxb00X/JBIYkc0DQhKS9HMYZ2y56tTCilSjG+vIJU3Uu5bSyn75KNYR9DWL68EoTg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 13, 2023 at 01:46:18PM +0000, David Howells wrote: > + init_sync_kiocb(&iocb, in); > + iocb.ki_pos = *ppos; > + iocb.ki_flags &= IOCB_NOWAIT; This clears everything but IOCB_NOWAIT. But even IOCB_NOWAIT should not be cleared here as far as I can tell.