From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2EB7C636CC for ; Mon, 13 Feb 2023 15:25:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FD6B6B0071; Mon, 13 Feb 2023 10:25:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AD7E6B0072; Mon, 13 Feb 2023 10:25:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDE286B0073; Mon, 13 Feb 2023 10:25:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DD3EB6B0071 for ; Mon, 13 Feb 2023 10:25:23 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AC4F780212 for ; Mon, 13 Feb 2023 15:25:23 +0000 (UTC) X-FDA: 80462642526.04.85D4DB6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 0E55440025 for ; Mon, 13 Feb 2023 15:25:20 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=j+65y77V; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676301921; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=is2NWtV2VTNxnUCu5cWYDtgITYpFKETTOtG4XpHoOLE=; b=kn1arvmikCul5wTzv7bBGK3KHXUg3UMARZM90mt6qKHa7jk5GD191UQJGzmZWOLB93ch6c EydA2YM/L+Vve1OqMPSUiCvFPM8YwkqHcbX5RZDQk0AxGHJLTAAnzj0qeKqMj1xbRYrxgq PzunzyEAhdE2Z/mb5JvFmBhZXrw9aH8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=j+65y77V; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676301921; a=rsa-sha256; cv=none; b=Zqon+kFjW44J7Mw4ZLnN0SK4C924gsF3T7Uj0IGmoD9y2dYr/EtKGqcPmpPADwyxQJthO2 PAM+CqbHPe7DsCezuS9whXJLvfxHELNs2Pq9NsY+5q+oLh2cxD5XWOIklxkW06WGPUBbpv ZwcSAfLprmdpT4ClpIW6KWGKlnbzcRQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=is2NWtV2VTNxnUCu5cWYDtgITYpFKETTOtG4XpHoOLE=; b=j+65y77VNVY+M53FFuWII8CE4C DGghunoeQbW1eo7fDwF07WCCdeeNhsTZRhelfjn7o9kkrXUi2WRvBK38IN/YIvgHjlNGvTFkSTkTd ADv9oo1MZ2P5HXu5rab6FYWS+ILR6JjQ5s/AWhw3hLuC4fNmX+bsoYIJwX832i+Vu8cxLMWCdCQrW wsaVBIFYKl7DwNTvKSeifxwOF3svaLT5rBnPbOouSsLcZaGhmUAKHnvuJZkdxFYZcrm+fQ04JWhMS S30idVBg+xaoUvVr8YCB9NbLtZI42Ge2WoPf/zsrranEiQGvRMYl1odRMM07aYzSP8CILWXJi5tJw a9EbcAfw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRahL-005seU-PI; Mon, 13 Feb 2023 15:24:55 +0000 Date: Mon, 13 Feb 2023 15:24:55 +0000 From: Matthew Wilcox To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH 3/4] splice: Use init_sync_kiocb() in filemap_splice_read() Message-ID: References: <20230213134619.2198965-1-dhowells@redhat.com> <20230213134619.2198965-4-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230213134619.2198965-4-dhowells@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0E55440025 X-Stat-Signature: mdzd3f7x6mrt7rqnuyu1toz6ushyanne X-HE-Tag: 1676301920-998807 X-HE-Meta: U2FsdGVkX1/gePS8c3IFSjcJ7BiQagBS+AP9EwfDgSX0P9MZiPEULdHFoVpjjYs5WEEOWjcpUcUP5ZKKSXxPwU/ZgMb6YA1rkE0xymdqPv0t7noC7eCHo0OOEeP0T/Ucq1IlJp+4EFmJ/8iUN/6X2bjXX52hvRpjWsgAouBnHpkLHXVUi81tWmicyXSGyz9gLG2AurIhbqbRi0CX0eVIXAIkKCYRADSOu2zkqh+O54nzvSRoQomtM88nEs2e7iV9zsi22rqv1YTzPLpQWL5i4kSEXok1EMWyU5WEEKn744cjhMr7NLB5uYkqAeujnJGk5XY/t2A74pDo94aJ5bEl5l+jb+gNYl4UUikKyl83PX5LcalpZL60u0Q3FNIrDuMY7+qETdPUqfcdq2wAos3GwgxVNscXhsx1yljVsoLxaMQaKudb0lMtvfjbGssFzMWmrlNTStdtpUlpN+Gxd6tHkkul1QeXb/So+hqbFDEG9Zbzdx2d/Z4PI0DgPoYw2QVktHbpkW8hqGcz/6dieSDFe+VzrohOEriMzF8O5NoLxuAfq91epHwHW9CA84ukVlbycFVddnwhCfY1NZl1ipI0DUgkB6Yg76UAChgXFH5HNQWfYqC0KRV5emOMSHjzaK+IfhB0A7fhjSW9sFRVvhNUPeyUd4gj8pZNxSLmPOvjnm9YpuN1X6Vaj3iqeVn56ZeXgb7Yg6O51l5bZ01WbChCdkeiyC9ow3tkvrHNfLOYdkVbWZRrCqfVSvxPgphTkhrWB/9cBOjATJGShKmirb1cHLDkpGeSOilfrlsF9j/RVu1EUH5Bj3ubZBP/MfgMffJmVZ2dkhuyH69z8i8S28K4+LuhOEfF3Cn1tUW6lNYbQ0yy/ntmKx98S3NkoSwVnJkC6PxoGhh0AFSNBfxO1yPzL7YX7f6ls3G5eO6KF4CU9Q2iZl+Vn7Uqgxe6c/4fGJTLLyUOuV1M4mY6gnaqOIq pHXJCFCy mNCKZUlzLWvscxs7mE7p5q15tgzWPendl8RFgyG4UPaLKUlJvFCfugw5GRcvHW/olgKxvPui18maWwr24dVSk1mYU/+lbUQKW+wJgxQm5yXGd51uxAKNAi9C4Qibg08tyMTwz2OVwtW0/A3z6UK7tftQztej3ny7bdpGwWYAUQWux7Vx7TvywgODQIZi61g8BdtCcLH0TFrYtzZs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 13, 2023 at 01:46:18PM +0000, David Howells wrote: > Use init_sync_kiocb() in filemap_splice_read() rather than open coding it > and filter out IOCB_NOWAIT since the splice is synchronous. If the user has asked for NOWAIT and the splice is going to be synchronous, shouldn't we rather return -EWOULDBLOCK here? Or does this not block? IOW, this either does the wrong thing, or it does something that's irrelevant.