From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5690C61DA4 for ; Tue, 14 Feb 2023 11:44:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DC7B6B0073; Tue, 14 Feb 2023 06:44:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 28C9A6B0074; Tue, 14 Feb 2023 06:44:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12EBC6B0075; Tue, 14 Feb 2023 06:44:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 005BB6B0073 for ; Tue, 14 Feb 2023 06:44:26 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C00A5160430 for ; Tue, 14 Feb 2023 11:44:26 +0000 (UTC) X-FDA: 80465714532.05.2CE52FD Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf27.hostedemail.com (Postfix) with ESMTP id 0830140010 for ; Tue, 14 Feb 2023 11:44:24 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hNu2bJp2; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676375065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o7d2IiBJx1hHXJ3DDKsOG0HNA14YLbMyddSQgFkrYxU=; b=sUYS9/gbUGHvai97Dg07bayBQwAUzRp/5d3eFHU0UNxy6qNkGGFAHJcp0Pr4BWEnXcQTkn H8HUKFWe5JjqAzrauJwmsxZsawptK88fGjm/2hEBBDUt5LCCIZiORv0cRND/d+C/Xbfn53 ioMjQ5hEsvCzJ5xrQVGq++h9ysRJMr0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hNu2bJp2; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676375065; a=rsa-sha256; cv=none; b=dh1PRZC/D2HHPAuqWRluDbxTtWqcitVKyhvxnq87HXY0pG0FtBuPMDQg6N+EGVeN6sNZf9 omCq+NwgN3DJzf6efkqdaf9z7hPcrzcgoH31I77oyIVIiJscWLnpBVIWpDKpTW8P+xkIyL gKbjGfQbgrblPxkOye/5P7sr4D+i+MQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3B4D7B81B7C; Tue, 14 Feb 2023 11:44:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE338C433D2; Tue, 14 Feb 2023 11:44:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676375062; bh=q0Ur6EqsdYguRoKZUYKbZ/d3FIdm1SPvTdEyMXa0spA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hNu2bJp2JUvI3QkRXK6/SQ2nkmC5w5Fh1H9YD4hrKbPoIN3Fq+ldd8hhjkhCWSvYI V39OEZBsYL2sKN83x9XQYBD0tGXpHtFfp6V5n6C1H944Q3aHNW15NaTJGlqXm2DRN+ ESU9rmmZZh2m384tQqLmUddopMCEgb8g1it0GuRfKO4r3SjqPqchr7f2wX+s8T4SYW GniPQw17Cnr1tpI41oVFCDJ79RHVFF7Zc2D/m8s/cHgmICuaWyTGaiTFxGcCUkD2re UzyPUbqN32MazJ0BKCInOtvMvVykL1QGAlQxIJuZY4b81wg0SKKCsS9dhV1sa88F5g F+ZGLpmnOMyNQ== Date: Tue, 14 Feb 2023 13:44:06 +0200 From: Mike Rapoport To: David Hildenbrand Cc: Qi Zheng , Qi Zheng , Vlastimil Babka , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Teng Hu , Matthew Wilcox , Mel Gorman , Oscar Salvador , Muchun Song Subject: Re: [PATCH] mm: page_alloc: don't allocate page from memoryless nodes Message-ID: References: <20230212110305.93670-1-zhengqi.arch@bytedance.com> <2484666e-e78e-549d-e075-b2c39d460d71@suse.cz> <85af4ada-96c8-1f99-90fa-9b6d63d0016e@bytedance.com> <67240e55-af49-f20a-2b4b-b7d574cd910d@gmail.com> <22f0e262-982e-ea80-e52a-a3c924b31d58@redhat.com> <4386151c-0328-d207-9a71-933ef61817f9@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4386151c-0328-d207-9a71-933ef61817f9@redhat.com> X-Rspamd-Queue-Id: 0830140010 X-Stat-Signature: sajfm7md8nftmdpxsaoctias64587wd7 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676375064-58441 X-HE-Meta: U2FsdGVkX19IVliOhwKFDG6dPLOFPuwDCmrTuLV/bSnjhdtIZuUAAX2vDoykgfTMxQdD+1WA3pIMVV07u6lrw54lejl9DTUdg6xu7SIg5yAwcd4ITkpQ0eQBthdn/om2Lv/x/IzjS+MKmZMEOie12OhpgDOhg1TLx7woTzeue3ksxB8ekDkYIMS7BOZlpUJS8iRGgp3CtrRqWDjzJ9jdJlBtWhZzlSGnc+8HsswQjQkVWYj+hkIQT8G5AWH4KWgq8sEbCSvvYUdqWM8IqB02W5Z5wdCnsEykynmpbT6e2DKzBsqg44yAY6oonQP+5CebmbyJZUbEnvXOywFNS257LxwPkj8aV/U6IDZ1bVIrKAbOpH/OQ0xzgtZ4WJ7keDfMKLrkaqN5KgxmMzBb446IDKSWah8rXE6ePBp/oTsszmx/n5ywX343Lh57efo5wb+qd9Doly+sboqhDpfKhbQbQH7r2Bvm89z6az58r+3gq5RPoxUqa2abZEOChB17NDKmDqY6Cu58gVidq/ZwrylYr6aEw1pL8/2ZL0RfRH+ZfKJ95Ad4/5KO5niE0dqDbNMM9TAKVKLlWc6zArvLU9w98/mnGkfUslXLhNSjxl3Xp6K0FnpsYfeO0+3TAb903dT9etHEZRpymR99v3UxCYO6OYMDr9GqtwR9KygIr8tllWdgUV9mItSe6OyHhrNRfBanhmMg2G3mrTk5StJ39tBuwBAl+S1g/yd1I7jlMvEhRLE1Y/9GNsxJjRGCKHnk2eutjOrxXm6tmK+tp0uJH8npO/CXuQrYTfWGFmwUJicPuMB7M6AhONMkIGQf4qtlwKTQ+ucyHXLtzRrF4slUg0gJ9GcTR8KpZcK9IYN74UPTTSZoV4NHijuXj6vja5cIV2myYApf9EBTb9MB3w6YpWfulIv3qgW3U/Qd7woUrJPj0i6SKBNNwONV1ZQdJIFTk/0n2drigXkIFxHss0i2dOU eMIZ+Oq3 WdUtGp1tg2SuS0l6QPlTznUiDnsUJsfE8KN6ReWBYj6Jd4BKyXq9cov+brW7QMDbUe7FUPwwGIXTAi6V9PBgYeuP/ZUgYbYDrmy2FTNk3TebVstI27NzW83UG1hKbaTr7VNrF3sxjKgnxjr3Yc0TDfros2F5H78MVF6Zj0m+LC/DNZzbDFGxE9Lpmhn/FeKznQQMgsHGJkcQMaFjeFufElSnsUE/FXEdMZxheb/MA+GGEi4MD8zLyqQQ7m0dr+qCgSTMPW9iWWCmfJCu+t98Gn7tvjiQv41GXuWQGy6UdRnaJTCH8/19JAtWDqbvmEu6hYLWht3QuXKo+8CQ1mPS5rMxk3WyiVE/Ovv+rQDF+YEIPetik0rvA5J8ByZ4cS3OWSB4DJS/nQoDYeNWJiR7pLq9BYJGIaJinp65VtbGUI7wtkSk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: (added x86 folks) On Tue, Feb 14, 2023 at 12:29:42PM +0100, David Hildenbrand wrote: > On 14.02.23 12:26, Qi Zheng wrote: > > On 2023/2/14 19:22, David Hildenbrand wrote: > > > > > > TBH, this is the first time I hear of NODE_MIN_SIZE and it seems to be a > > > pretty x86 specific thing. > > > > > > Are we sure we want to get NODE_MIN_SIZE involved? > > > > Maybe add an arch_xxx() to handle it? > > I still haven't figured out what we want to achieve with NODE_MIN_SIZE at > all. It smells like an arch-specific hack looking at > > "Don't confuse VM with a node that doesn't have the minimum amount of > memory" > > Why shouldn't mm-core deal with that? Well, a node with <4M RAM is not very useful and bears all the overhead of an extra live node. But, hey, why won't we just drop that '< NODE_MIN_SIZE' and let people with weird HW configurations just live with this? > I'd appreciate an explanation of the bigger picture, what the issue is and > what the approach to solve it is (including memory onlining/offlining). > > -- > Thanks, > > David / dhildenb > -- Sincerely yours, Mike.