From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AA4CC61DA4 for ; Tue, 14 Feb 2023 12:46:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD3526B0073; Tue, 14 Feb 2023 07:46:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A84656B0074; Tue, 14 Feb 2023 07:46:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9727A6B0075; Tue, 14 Feb 2023 07:46:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8711B6B0073 for ; Tue, 14 Feb 2023 07:46:36 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 66A1540619 for ; Tue, 14 Feb 2023 12:46:36 +0000 (UTC) X-FDA: 80465871192.08.CD38238 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id A3D384001A for ; Tue, 14 Feb 2023 12:46:34 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FjxqQOiR; spf=pass (imf01.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676378794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OuP7lTisAmOa9J3CkGeCZ8hyOvXrJnG2tWn+pUdpjI8=; b=JvnmZliAhSzTIAA/EeUk6KPU8szr2wjebe/tZf9DDV00UQ/obeQOf+MGILpQsD68TccDub 4JFI7zUpCTcE1NS7fgTjO2VD32ln38Esgpv312CvRf3F/XYkOL4dcB1o6gOkYbPamKzA89 QdAKfvHEaSw7pVBW404+B7yfsQuN3c0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FjxqQOiR; spf=pass (imf01.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676378794; a=rsa-sha256; cv=none; b=HD5OMK+/7Zu+EOlsdBO1P8RHvNy/tCDMuL94U5PaD0VtNQ8JkJU7UTstIaBlNNQBHB4FOL X8xpxnO6NHmObuHtuhL4ZEggHWwQnxAI7nqUP/TqR7j5XLbH+5NX4folXuVEKZvOMfzxwP OuPxLWk0KsOJ58ugPcq51RadsRwq9b0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9331761610; Tue, 14 Feb 2023 12:46:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5A2DC433EF; Tue, 14 Feb 2023 12:46:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676378792; bh=rvY4akbiWkPYp6q8TWHxBXJMkGaOh5UByiYweshK5tA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FjxqQOiRowx5Ag6MmnJWY6fYnMyjiQGyRcgh+5Pr68OuA7WEiVwZRZqvHobwGGilk DlwtE+gG9pN2nP2YsEX8CJ0A5YMyBJg5W7KG6ZXMc6aV1aN8swwKBHMB6L89uHZMYI E1WJmP03hDrL3JMXB/VI3kFB8Zl3IfxxfDZsgbay0LyW3YllOtgcbfQIxioWS75m8U x7KmzQ8vPmgoJ1HZKTcU0KxDQzBVw3CjFDRrDJgfnU8rF3I4HvAAGP6CpiGllUBmOH rW4O/sxWZXV26FCteWRJh/DLEq+X/27QKFLgbCIS4TCrQfExuCH/mL2X3+rJ5wcV7h 3ArohJk4pKGMw== Date: Tue, 14 Feb 2023 14:46:17 +0200 From: Mike Rapoport To: David Hildenbrand Cc: Qi Zheng , Qi Zheng , Vlastimil Babka , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Teng Hu , Matthew Wilcox , Mel Gorman , Oscar Salvador , Muchun Song , x86@kernel.org Subject: Re: [PATCH] mm: page_alloc: don't allocate page from memoryless nodes Message-ID: References: <2484666e-e78e-549d-e075-b2c39d460d71@suse.cz> <85af4ada-96c8-1f99-90fa-9b6d63d0016e@bytedance.com> <67240e55-af49-f20a-2b4b-b7d574cd910d@gmail.com> <22f0e262-982e-ea80-e52a-a3c924b31d58@redhat.com> <4386151c-0328-d207-9a71-933ef61817f9@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A3D384001A X-Rspam-User: X-Stat-Signature: qpz9mfoat6cay578apqopjo5apiaiwn5 X-HE-Tag: 1676378794-131405 X-HE-Meta: U2FsdGVkX19v6dsgfvN8Q4CPZ9+wjPl7lEz5URQcNAhMX0hK+vDECBuQtJ/A3YXHje9MLGpEHTjSNRaMCCcfbVvQwv4rtm6sr23xyqTQ6GSmX+itXbDctDZn3cXEgesLBW/HTTw3EDYT2Hy1Su+E/YvdjJM2ImJXgCwY9/dVVJO1oDHgxDJp9mraXREFEL3TUDIskpO1EgFnv5UfoehTA9cyllW6xyzMpyDaVMUvI75A+6OOgJ2xty9/Bb52FdLxcSlIlhtuMbNiegbQia+OZ5nlhF3AjOA/rb6Uir5pQSiw1GWZ+YlPqEInNSSPDq1VBWvxkeNgPBXHB//M82ROScsPZqZyZLgkx0tMuWRACUS+ZhNkUatUAjZZITAeGPYrmpvwUZPU+ZT9grrJgnJ2Wm6au9Jn685AfL6UuB8NHHRE7iiyz9XNGGkh8SQg6FELJ+UcA2GrWIUS5Q5AFBf2KcSTunuSeI4IARyZrsdI3mcYNnxHGr+Nb5LFZLj41MMk9zccul4m27Oyvvsh3HdZ6+EJxf9Qf+6tG+w532GAXe1bP2Eybt7NrlY8x3UoiVe9qi5eAVaxu/XVLN9S1KIBUEAw/btcWWiLq6/E27hXnL/jaYNPbhoXFvADW3LoTMBgi4nEwMLUXXw4AeP2zTbysYrCfaQ4cjDTWwYcfsBW6YymUczHeJpYKxRv2krEvaNJtKZhwX+hgsA/jpUI1e/lySiYoqRwTOLyw8K1u2cgxmu3BoQHt/n8c5D+KpPZy3MHHQhlP6i74o3aSenoFIeHmhkNGSzWbbcFFxBWiUR6hU+/OAnsxiboEqJ3qJvBBe7qalj4WalxZKWnNIPFiuonQI2tQwJE1dh2fSrZxTlIz4RCF8Lv3rDfJr+e/wNUvLyfTHFyNhWpti6sgnfU7OcJw/+5zxhcZYjiBHxX9RFezsiEPXrpJKZwmI/llymy2axSwnROGsVpfH7SZKoFzyz jdmscKyH 8RIgSLsFOS/XZypsid9n5TlH3Sb4HuHrxAWaEQPh5n+KqDsiJdidOf0gPKgY9QjxGtFam4KM+AShFuDu/DgJHxhSCNRrOlwt0offvC0mND2zG4bqPntu3kdTcnH8SI3QHspvnQEa28W3mFXopR+N3pZdDJvCeLnBWxeqX52c2GR+Fcyg4me8AstY+yLgx7plIpJA59jyBn7YPhJPpAMSF2GVFtbaQkRmqDu4B0K+IJ6pp5Ukt4N2lm2kpGSOJZuMheEvbbGmlcVz3OFD8cCkMyYoB8vxyT1QzlnVTlH4BM5L2nIu6woQa9+ncqRP/x9YpE0F7OWrQIJNLOmk5jtROcgjjx44o/EJK1Dl19lo2Naip4C+QX69eFvr++ncoLSsXzxcx7Uq+GEq6Oo2HJrG5/6Siv0AJB/Q3CjdUIv/E+Fxiovv4T7LXJJmKHZCd/6zTCoT2rtwkAh/PALZ/2plqRrDlUFzN9Jg07P+d2d2l54J+ZZxswXY92jIkrUrtVDzHb33sA7o7rCZyoS7M+sJywE5RIUAchtUQUs3E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Now added x86 folks for real :) The thread starts here: https://lore.kernel.org/all/20230212110305.93670-1-zhengqi.arch@bytedance.com/ On Tue, Feb 14, 2023 at 01:44:06PM +0200, Mike Rapoport wrote: > (added x86 folks) > > On Tue, Feb 14, 2023 at 12:29:42PM +0100, David Hildenbrand wrote: > > On 14.02.23 12:26, Qi Zheng wrote: > > > On 2023/2/14 19:22, David Hildenbrand wrote: > > > > > > > > TBH, this is the first time I hear of NODE_MIN_SIZE and it seems to be a > > > > pretty x86 specific thing. > > > > > > > > Are we sure we want to get NODE_MIN_SIZE involved? > > > > > > Maybe add an arch_xxx() to handle it? > > > > I still haven't figured out what we want to achieve with NODE_MIN_SIZE at > > all. It smells like an arch-specific hack looking at > > > > "Don't confuse VM with a node that doesn't have the minimum amount of > > memory" > > > > Why shouldn't mm-core deal with that? > > Well, a node with <4M RAM is not very useful and bears all the overhead of > an extra live node. > > But, hey, why won't we just drop that '< NODE_MIN_SIZE' and let people with > weird HW configurations just live with this? > > > I'd appreciate an explanation of the bigger picture, what the issue is and > > what the approach to solve it is (including memory onlining/offlining). > > > > -- > > Thanks, > > > > David / dhildenb > > > > -- > Sincerely yours, > Mike. > -- Sincerely yours, Mike.