From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E788FC05027 for ; Tue, 14 Feb 2023 18:55:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5065B6B0072; Tue, 14 Feb 2023 13:55:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B64C6B0074; Tue, 14 Feb 2023 13:55:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A50F6B0075; Tue, 14 Feb 2023 13:55:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2B9516B0072 for ; Tue, 14 Feb 2023 13:55:48 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 003E4140756 for ; Tue, 14 Feb 2023 18:55:47 +0000 (UTC) X-FDA: 80466801534.13.FA74EC3 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf22.hostedemail.com (Postfix) with ESMTP id 1E50EC0021 for ; Tue, 14 Feb 2023 18:55:45 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aN7KO+J6; spf=pass (imf22.hostedemail.com: domain of ebiggers@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=ebiggers@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676400946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3l9ykbZ/Ja+yUgMAeXgqaIP+Jrh//4wWz6qxtrXM/Gs=; b=7ieOMsj57wEoL7/Ukk1YsMpykK35k/ng2WrSs5Pzn79Suclya+gxdYRpj06r/E8URDJ6sR w8weFJIcVaOFx6F4gVW3cFsI4oyo1xhfAJd9c6jhguLCm+Ea1waaXoEPUXn2uIJzc45XIY 7bQHomhkhrYrlPPhenD5OX0brkH2XL8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aN7KO+J6; spf=pass (imf22.hostedemail.com: domain of ebiggers@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=ebiggers@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676400946; a=rsa-sha256; cv=none; b=c0iKOx5kj0EymVU5THtZOmvLri3yTAAZ0UuasUF3wHo0t9H5DjqWwuHStI9+K/d9/V/pF/ ExizSTB47j0Cdef4rWbhjGZ3rBJVIOq82Rqo1hEPHEKDMSxOY2FW6oAqImKEobmkHZS7/e irLIFj2Pnl0rKRt6uFFlZXJNT+sQA+s= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 103C1B81E35; Tue, 14 Feb 2023 18:55:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87A88C433EF; Tue, 14 Feb 2023 18:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676400942; bh=hsziXFWBEJIv+asnoJ5UADxji1cYX8chWCG9SQy3nKs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aN7KO+J6HDjSG+1TiGld0IWqnTfF53nr/7YFPZP0JIl6xRxdb3WVo6/OvtGEg80+q 6JgxsZHfd5d23by8g4Gts6przoa1EsCvyKutUw5uPWncnhXipwUsiO00c7rL96WivE m0uAiqKSmt3YTcSfUZZtyyUjDBQ20Bb3r2bUYBHr/9uJv79taE/puvcbIUh+M0oMTe 3KPVK6ea/Q29xm0Yyjald62dFCOtWpgbARfYa1nPmfNjpxeSjxzy7kuTiZSi22R56G R7faRSq9REkRPThewPKfrESbfwdWiAg1WVmS0K/VvAdzPyo9V75yDkowDy4wBg4K9L 5YG3g7vLzFQ+g== Date: Tue, 14 Feb 2023 18:55:41 +0000 From: Eric Biggers To: Munehisa Kamata Cc: surenb@google.com, hannes@cmpxchg.org, hdanton@sina.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mengcc@amazon.com, stable@vger.kernel.org Subject: Re: [PATCH v3] sched/psi: fix use-after-free in ep_remove_wait_queue() Message-ID: References: <20230214181335.3946674-1-kamatam@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230214181335.3946674-1-kamatam@amazon.com> X-Stat-Signature: miuuzm1ihnbwzoutxiwqawng8iye3ifb X-Rspam-User: X-Rspamd-Queue-Id: 1E50EC0021 X-Rspamd-Server: rspam06 X-HE-Tag: 1676400945-862824 X-HE-Meta: U2FsdGVkX18pWCdwKBwPF37yvT8p0/UrkexL8K6xQ0y0H0n9LE4wM6LUBY835BV8wd+WFhKJlYC2muOXCVYkoKFd7QSzKhO5p6GYfnWFZnHl2D7QKGTteYJ3VYqCW2da80qa83lCkmhmZoeVwBs6agc4qNi+v2sQkfAJU1kYigMDbEaLe0jQip8gBSnibvdXN+YfIGabyMv97TOIHSL985bY/pOrXWbAPwtRIxAE2FEAg+w7zM0h1cQCM17zNE8HLy7oZaewOeKj3XSW4d2OWqcGrg1YjUwaJ/kMlmXcixDW7bmnV1DvXPFrDwj/hhsfOSe72tRRjL+/KQz8OTaPAylk9IMILz3SMrFFL4tsLRsQRyGLE0k+cDha94GHusp0Ec0bAsJ5k4xsr5hmdT4uyoyhPWGtORqejIV/lia0gEgshmbFUSyiv8GDqnXkq0q76bPIPm5k08DkVbW6U5+1mK5qnseVBNoIsOcdmxeOyoFxSaONK4NvQ/BpZwWCL91SZu9rC3jAdwszc9Twa2hLx5fYVTr3qJTm/8K7kOySkRrbiuZFUFRLz9u8s+R5EQGZvRQGz10xkxKiOGaw4mk2v8vYVq50UL4dAAJaVW3kBUPFQWEXfoE0Eva0kqzXCrlEZyU4/zNFO5xm/6Ny1CvnLVcH/JSnhZShwW8OwDvpelxXeqHDltXhUvnrBK3SYDokB/Mj8gA6aw5pmujMhh7zCOiOamRMoSeSdaUNzm1CetUypVq6S15jozo4lThuQVMiAuK7DUJjJEWAu9KT3iaakNpHc+x0yGCLTahuQcsOk3CJWq3vvSQ0Dx3SAX2yccku2In7pmsLJQK4hx/m1Etk3TZH9ohmdrspmYSpdaTZFpzvIXzKv17wPUMUcgfE3VH54bdoWEFHrFvy7LVVyz7Tb9QnpsW0TUXEfjhMF4rE2wIsIzdOaNkzMztk3C7q98/aivwRSJoc1HsaUrEGnqu eOJT0Wn7 LbaLUx+kbzwAuGVhETs0d/If6NMmQcumWFhfDpYP+FdUy7co1bMgG1P3PoFMiobShDw+DP3CD1tnHKlUWWR2bxPzJFQMbWU6kBcZTXkYga09tqB0vt1MhyxN0D29z1YXGXkiyN/KP23unLIfsfi5KpaMkEYnWr3fgrjUzB8uZgQGOB0zYfpE/gwMi4IxBudvVkLYKumDE86myKpmso7bgx2VzoUbeBrumrEPhQdo3N6DiAhFWrL/Zk2nWCj87LDDh7Ea1t2844fQwFLdQ8ucDz6+fVauaLB6nyaZkPMwU7j6RG1Ocmqc9QNzgUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000085, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 14, 2023 at 10:13:35AM -0800, Munehisa Kamata wrote: > Using wake_up_pollfree() here might be less than ideal, but it also is not > fully contradicting the comment at commit 42288cb44c4b ("wait: add > wake_up_pollfree()") since the waitqueue's lifetime is not tied to file's > one and can be considered as another special case. If that comment is outdated now, then please update the comment too. We can do better than "not fully contradicting". - Eric