From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 961C9C636CC for ; Wed, 15 Feb 2023 06:24:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08A856B0074; Wed, 15 Feb 2023 01:24:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03A8F6B0075; Wed, 15 Feb 2023 01:24:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E44346B0078; Wed, 15 Feb 2023 01:24:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D46376B0074 for ; Wed, 15 Feb 2023 01:24:41 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9AC991A12D5 for ; Wed, 15 Feb 2023 06:24:41 +0000 (UTC) X-FDA: 80468537562.14.35CF51F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 0AE24201B0 for ; Wed, 15 Feb 2023 06:24:38 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=3OR5JmFd; spf=none (imf03.hostedemail.com: domain of BATV+22031c8ae556bc37188a+7115+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+22031c8ae556bc37188a+7115+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676442279; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SGKZr1LFtN6F69r+wq3YkG37Rjrl6skoofTy7kDFRIw=; b=Uogo2T1LhunXDcA7wAr6pdg9bkux6ik4+0ZpbRVoi0m0/R+cUUMp5h0VIN8HLENVhxiwtv 9S4LyXyY804nocVDmyt18mCjkatxrqAhOiaGFjYJK46NQP6keKyh5cobWRW2vDlAkOKRh3 jTOyIBBS1Qp6PfKheeeqiuLb795hFno= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=3OR5JmFd; spf=none (imf03.hostedemail.com: domain of BATV+22031c8ae556bc37188a+7115+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+22031c8ae556bc37188a+7115+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676442279; a=rsa-sha256; cv=none; b=u58Go0Gv+zFtAPzJ/WXrwk1mdZB960JTVNw+zgmDK3S/nXiOdIrSdjRFJ/LaRUaqT5A1q/ hBmRiD+OWEOkkk7qYyP4Z1t9hblFKYDDRuqeeFszM83/vACDLY25X5nPN5pm5jW3ydAPff ZAweY+4uqC+MqpXdMiMLscDk8d8Kme8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SGKZr1LFtN6F69r+wq3YkG37Rjrl6skoofTy7kDFRIw=; b=3OR5JmFdY4IGkJ/l/pgp90om0J Ju5dZedZ3MjMwpgQOLP3xiymIiGw4D24BfsZyFalIcSrBG8lURQRyiJJKdo33Bqxn3LAUWgltMA+s J/Cgm5/E5nANYUbi2OJO7WzSxhwSNcp/dN3pztwvUYPxZwFuavW6NfWoVum/yi+JoVStrAbHJZKMS aHCfhhNeaPnocYyp5Bfy04V1HG0FEAyHgf2IaXEPnyvD5jmo5OUYdq2H+ZqlHDc1nf51EsI9zLW8L wAUxH4TTk1c0+PVqwch9Tp3NkIBGzGk3QVnWqPLkVFmwR8Rs00FOrC9EdRif99BYJo/4ZndQcFJqU 4IN8xwgA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSBDV-004s2l-59; Wed, 15 Feb 2023 06:24:33 +0000 Date: Tue, 14 Feb 2023 22:24:33 -0800 From: Christoph Hellwig To: Dave Chinner Cc: Jan Kara , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, John Hubbard , David Howells , David Hildenbrand Subject: Re: [PATCH 4/5] block: Add support for bouncing pinned pages Message-ID: References: <20230209121046.25360-1-jack@suse.cz> <20230209123206.3548-4-jack@suse.cz> <20230214135604.s5bygnthq7an5eoo@quack3> <20230215045952.GF2825702@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230215045952.GF2825702@dread.disaster.area> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0AE24201B0 X-Rspam-User: X-Stat-Signature: fzrucdiuzoohzyfuoi67cgwfg4wx8jes X-HE-Tag: 1676442278-401052 X-HE-Meta: U2FsdGVkX18dD5dabh877jgAE8x48JUUzowTOE3uVY40Rnnt/44wCD4ugRQR0nMz/LrI2Z6NHZfi581oSrRxIlQOmg2VtYJCPeeOFzQ0jx6POeU644ZrVhXUQDAN58TUuttfCTnUXuRSGfddDFmjxg85ALpg2C/3gC936XjSi2mLD0ibeNNoswa1D5/tXU4bkLnmwc2WkKx/mMppxIrseZXvHj9cs+AlivVy2v1ZvzxGhKMEUuYkHW4Tkc8oY96YSGzBAZTX7hfWRsnX6numCeK/qGn5fUMSk4wZDaVitDJCtq+/LDEOKfRXAhJn6Nx6tAg/T3WFUyFOkovw6XwFOvCPeWZTwEJ3o/ndO1sPSZZAg0FPxvJkTZDdyPd0zSTCULVOItlmyXtIOPLrUfpNfDRzFUUT5HjZlzEOn9XtTEHIRMjfUrb7XIKseQPnV2hMzVt2OMkNU7yR/1AbtgHnX00YiBIHKmb3JjSZkdRvFheDPMhmzLvr3CenSW7LtwxDkLep0yDm7odk3cfc11/TPP4efqAN0D5mE5cfgz0mV5QsoV/03javPwUZ48gVTiWc9dUx/JPGa+Ja4tn/cocZ9WpqFUE5zCqMIVL4eKJ8tcCQenBgJ8r7PWdBvKPUcrv5rXrBg03brOo5LShSobLFXSn3Kd0zJkKmp3Harg1fGAW9Ik9vdDmK0fJoOWmVlDe8ePCpFCVs5k9QgGIXDwEGhXzt9hGV7MefrNG6TqLBEMgkfhDiq+6niKVtvmp1Rh/1eW+n2eyxvgssrsAakyz1fPqZHc3vmqHKKQULL7WYEYPgEe7tJkMvjoChqaDvaUUKZ5xZnYqYL4qg9rKg0SVmu+R9RLvmBkG2i76g12QLvObx8X8LdanndmFs2YNt0yUB9J/qNRv0tcRVV82BQNxil8QA1R/VfsLylDNKjtbDNjETS+2kfHrFe+NsE2ocS190IULEHAUEguO9kyrJRiL 3r0c+B7W Ulz3U/qhl1fAbTQfFnydFod7y3ryegoqyl45CrHaDozHOiQoD60rcFtUwpRu3Q6wH5bj5prUSyP2SdXXwYb0IJYsJwDmKruxlre5z2WCrsQc7YToeG89WeETw2cK76QVNuJdYDUvLww6vEEHrgv8w5bOsYVSFLRw6TacPN91p/a3S6/bec21JufX+4CR80dCjWxH7Dkfj1PTUIxcbWWg9XHhDbVru4K7jRXYrVpT0YKlj+SGsLkZRfCJHXJ8zsWy1XAqCDj/2mqi0K3a7sflzjNvOQf9LeB29z3V66geblS+wz2lQ3h4/pR7ywopisvXdVU8LYzjxE88UzK4V0oXMofqE+fy8Zj47XdCDLCrA3d+iaAWc6+6lSfiWKj/HMeWjbd0XjKRN7fyy3xrJSIIhJRzphA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 15, 2023 at 03:59:52PM +1100, Dave Chinner wrote: > I don't think this works, especially if the COW mechanism relies on > delayed allocation to prevent ENOSPC during writeback. That is, we > need a write() or page fault (to run ->page_mkwrite()) after every > call to folio_clear_dirty_for_io() in the writeback path to ensure > that new space is reserved for the allocation that will occur > during a future writeback of that page. > > Hence we can't just leave the page dirty on COW filesystems - it has > to go through a clean state so that the clean->dirty event can be > gated on gaining the space reservation that allows it to be written > back again. Exactly. Although if we really want we could do the redirtying without formally moving to a clean state, but it certainly would require special new code to the same steps as if we were redirtying. Which is another reason why I'd prefer to avoid all that if we can. For that we probably need an inventory of what long term pins we have in the kernel tree that can and do operate on shared file mappings, and what kind of I/O semantics they expect.