From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EF0FC636CC for ; Wed, 15 Feb 2023 15:42:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF48D6B0082; Wed, 15 Feb 2023 10:42:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA5046B0083; Wed, 15 Feb 2023 10:42:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D949F6B0085; Wed, 15 Feb 2023 10:42:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C962B6B0082 for ; Wed, 15 Feb 2023 10:42:08 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A577A8106D for ; Wed, 15 Feb 2023 15:42:08 +0000 (UTC) X-FDA: 80469942336.27.91CF00D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id 99C6920022 for ; Wed, 15 Feb 2023 15:42:06 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Y0PKbb2G; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676475726; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J1HP1AYxs+CPgeT/Uk3lsnz97zGE2SKFHAXmfCAw3bw=; b=rRntMGoamAD8DRZnk0bs2Y6vhOUaenRpQRCqUWo04j/ENs/yOUxLCm2p8g5alNbHYJKXk7 mn9TMckIaiRx4u3fxQynwpVR0WYeRRc0dHLaSkbhsXpCubqEuJdSdRrGHUU+DnbuS/kN06 yd2ruWcvgpb0i4vfIkKUtB2l4vNHA7I= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Y0PKbb2G; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676475726; a=rsa-sha256; cv=none; b=eSciqIMKJLrSQWEcN7WcosUYf/XxKGrX54IS803cIbFT7olg1co32SuPCJOeULlQhuBA3n qZ+P6pjojxdLMloXJTLKDecnMnPkveAstyLDn23nKvdByLEaxmeszS7CVN0vlaA/YqK0wP BAyojtwKAVo3kr8wPDR/RO5/SOcMhSM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=J1HP1AYxs+CPgeT/Uk3lsnz97zGE2SKFHAXmfCAw3bw=; b=Y0PKbb2GdfSnGd5GRhVnYZGNLK S2B4glLdiOEykJBOnN/nU8lvfvyNknik1yQ8cOcv9q2fIz9pbnNOYxDhnhIx7ZHeQiWzsjqZCuaTa JrddlddthRmAKYwpOF8TuJM0ngO8PaURDxPZTUMO46mwpNTH3bPdUohUwBwc/U4fCEkBEGeWl06U1 MDA2+xdslRl+t1aRvavQmvMMojmeVVeCG6meQe2Cgxk+Zc2cKz7EFOD2tmMciWoWjk8WhInFX08Ul 7aqG9lkcHfdkciRCtzifRVf33MBMXUGrjWkCu8rNNLTupObyC6B4bUQ05ytVIIVrpA/9Vmge97DkK ecTx6fwg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSJsY-007aAb-HO; Wed, 15 Feb 2023 15:39:30 +0000 Date: Wed, 15 Feb 2023 15:39:30 +0000 From: Matthew Wilcox To: Baolin Wang Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, sj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, naoya.horiguchi@nec.com, linmiaohe@huawei.com, david@redhat.com, osalvador@suse.de, mike.kravetz@oracle.com, damon@lists.linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] mm: change to return bool for isolate_lru_page() Message-ID: References: <3074c1ab628d9dbf139b33f248a8bc253a3f95f0.1676424378.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3074c1ab628d9dbf139b33f248a8bc253a3f95f0.1676424378.git.baolin.wang@linux.alibaba.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 99C6920022 X-Rspam-User: X-Stat-Signature: xgut4tp6nh4guhzc13ttr6q466qi31yd X-HE-Tag: 1676475726-962711 X-HE-Meta: U2FsdGVkX1/X0iYS5FzEeLjgWgEU+UhdgHlQ8xEPWuBFCsj8R3QefcFECyM79a73wTBJzLSUsxs8O+cmathMskW1yHDculTkrECSmLUyhL9OmS10TiNaJoSKQb1b0/ZY51WoKLIhS4PXVP7FMby/8hDVZQP1XT8/bvgCDfuOQAV88Enh09zxPXAGWQQ9EEl5lF9V/BU/6HPKDv2Del/7NJ8X+P1B63GXeA2kda8vYQeX82JO7zc+aEqGbLA5HhLTczfbvld2Zew5GyEZHjMtYYvBiGH3IDj7PNpCkrntaSOVvjLQLA5pBSgRcUd6IIXZFths9N4qewtykZtVeF6+/v3127jJUvfL+WerQL/l3ktZ0OBXj6EBreh6w2nwYCyA9NpjVReaPXcpHk479OlabEfNN13HxRF0dfJxBTls66FGfec46FbSAVhnFuGztt861zcz9e3XExK3drC25LM0b3UeoLfi3+RB7UQ3PIssfP+BU5pXVL1GmN13lnGH55ttX4w+46E650tQuV2N5AAYi1vlZ5sNlX5zwTrPLsS6gVv3tzX5xJvTTLPPMm1hS9dCh8x+MsiTzT9mZOBBV4cOyuRy0Xtj+RY5KYv43dnMaOfXsjjRraXRvcYdmZwp50XrgTW8UEPMnf6sIlKU8CrxY4SVX7pLHa6kwpHXvJAW/UZQz28S8y3wvBBs2vMkEdZa834gQU46e4qDPDB5R1UMk5G/r+cjGM1G5AZnnIJTxwr5k+mNRz7uzBh7jbPKVvuPiDm8hHYaCO+3SYWnIwFgfzVNiARJsQ6PjbfRhyX9XhS+8bUjMvx7xcJ9cTED2/f8u7aD1My75qE2aDPlWGXDc27oSMznQ6edBoJYGkNvxTe5bqdPyqu+5IkjJeX4IEgHOgpLBDruZOQVgqsr1bSJIghcjlEiZO0+6h1cCC/nSjk2UsP1euyYyKbZqp+OZ8gBKeHWn6t/8pxb7UyrD0p fZsep0Xp A10f2NLyTLjFuRTAeW25mimWPjJSxAT/FwYlBlN7hycR+DkDldc/B3bNqLVQYn30pC6RfeHZr/XuIQhBKFeOSpoOMMC4EAJKlK82bYGMBT04Zcua/poCdMU4mkyOo7c6syoiJPVUkz6DzsswqXnZXP53msjl5vukxEny4naby9CWmKnqx9qj0sb0nIEPBlJkRiCcF8hQ5uzjHvIecNzXVrkfjprqrDI22ajZTgbvzoRk8+L0EJqnNoaEGwmk4AaUIg5hEXK0zJEzM8zjNRzlEuHVP0YpqUdXaXGXa5MsW2yyaohP0F8z2FsB78w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 15, 2023 at 06:39:35PM +0800, Baolin Wang wrote: > The isolate_lru_page() can only return 0 or -EBUSY, and most users did > not care about the negative error of isolate_lru_page(), except one user > in add_page_for_migration(). So we can convert the isolate_lru_page() to > return a boolean value, which can help to make the code more clear when > checking the return value of isolate_lru_page(). > > Also convert all users' logic of checking the isolation state. > > No functional changes intended. > > Signed-off-by: Baolin Wang > Acked-by: David Hildenbrand Reviewed-by: Matthew Wilcox (Oracle)