From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B0BCC636D4 for ; Wed, 15 Feb 2023 15:44:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A38226B0081; Wed, 15 Feb 2023 10:44:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A0F4C6B0082; Wed, 15 Feb 2023 10:44:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FF1C6B0083; Wed, 15 Feb 2023 10:44:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7FF456B0081 for ; Wed, 15 Feb 2023 10:44:42 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 58828C0856 for ; Wed, 15 Feb 2023 15:44:42 +0000 (UTC) X-FDA: 80469948804.04.60408E1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id A263E2001F for ; Wed, 15 Feb 2023 15:44:40 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rczzgNYd; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676475880; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7O/CtBBPkdDhkIEeL0V0v4LD7N06poGA5q+c+AakFcc=; b=Iv3OrNCTOFV0LPffcXuPi+SJL5KMe2Z1a9dK2RWMcBAXzDFh6Va7VM0U7YcgFPzYXcpf0J zXKFy81hnLp2heOG4V0y1l6JSp615GxZjrqS6tS81fsvoxYBegH1DI6lri0U8Q8rP01il6 ZhDOfugW8crLCxAu6S9kK8wbwxCZnQ4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rczzgNYd; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676475880; a=rsa-sha256; cv=none; b=nFDo1HOD6hdbqbYd8rWe3hafg+4jskjNXin9wy5/8GnZxyggpwGiufMbV5mnYnm/M1Jkgf TI4T5QLGdTwk4mNj8OokCNPylUhqGtBIz05CrqFd6vDx0gzGHJPDA8jDlYukZHQzIIWQWP r3P9Oj8mYxx1sHTJvV+bAQvEwP/W57U= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7O/CtBBPkdDhkIEeL0V0v4LD7N06poGA5q+c+AakFcc=; b=rczzgNYdlPXgCEQdETnrU6Ozg6 L6yUQ9uF+/bH9BQwN2r450aDfHyyn9lQrbsH2MOdB1ogqJwqZ/QFp5qwCgymAVO5Eee0PwKED1DBu HJcrLfox+FTvNIBX6S/7yC+XSf+tXQvtOW+nN/7CI/yMuRINSWFosqtCjJCU3nZxjm2CJxeJ/U6Tw h8Zxl50dRjjPnQrEeOXSLYDgM8cehU/AL1DJiH9BZJun+0hqxQhjUbL4gOjgwLg/B+pj4ehal94D3 1ZHdcYnOiZc7X0YbcXH85C9Gf3259V0BY2uSUswvyDddtcFyQqOQv78EQf6wDlWwxGirygQItZnHF C6zPg+LA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSJxG-007aPM-Oh; Wed, 15 Feb 2023 15:44:22 +0000 Date: Wed, 15 Feb 2023 15:44:22 +0000 From: Matthew Wilcox To: Baolin Wang Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, sj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, naoya.horiguchi@nec.com, linmiaohe@huawei.com, david@redhat.com, osalvador@suse.de, mike.kravetz@oracle.com, damon@lists.linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/4] mm: change to return bool for isolate_movable_page() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: m9o1wr7or4bhqfi8ar6oo7k6kudjezxp X-Rspam-User: X-Rspamd-Queue-Id: A263E2001F X-Rspamd-Server: rspam06 X-HE-Tag: 1676475880-919447 X-HE-Meta: U2FsdGVkX18W5HgrPUTwy/ZLQjY/LHMs9vAa99lYZLwUCATRl1wxHKqfFdrmPkPNBO6JN5tYsYWlqOq8zw7qbOB3t64jMntBDj3Rd/RFW/6EgYPxph4vgmYE7Wmq2F5WnXPBnX4xH8jOOVPaAR05PznMruCkcstBuHFkuFYtXeIqYBqlWpMrz7zOqbboVHpIIIgPu6aBXn3IovpKSQKWA4hoJ+4np9EwrW6Z25c/a7xa/C0L1T3oBIcOME49xNdLTaWKYPWuvre6M45SeuHFCWr/qhsfgfffuB8+Fa2NRKEsFWuMlyTmLHOituE9LiKBH+yPluWikaJSmQThRPW+PFf4pErr7lsKrdHXR3aHczP6fUVwajxm2QLBwu5Gujj9+f0O2Pup6Pxy0oTQeHRB9JLCJkI/10OUxQf6tUQqL4PE4yA/Zl6hPBUGs+yielZQX8QvYKjeagjJtEuGVsgF2/py6tbBU2h+jBogYvSCFsmQt1GvjgN1uLxT+MeRX54dHH0hgVsPDRag+lfhp7JbVFgGIe5GaHO/HmUa/lucBz3VDc+1gDwI5zIND9nmRQUZKI2WChG5qkt2eE1JQTwV0vbTombrQeabQvFathdh8Q0xjAT/szTj/1X7zBviHZh0fIhHkckmPyFEUmW10cwvKxEMiYASwn8Z9CGTdsPyu4vlF8zne6YLTUfuoNwqYPzrLQZF/jwpVUcKx7M6AuVd29Cg7N96QCdqPQ9Dzue3nxSjQHnY+7nPxEVRa8AwWHDRA+4qAmnhbLfjAQK0dkhAOgE76BKhg3Kt3HsGargOXhZmKvDuS0KgGADQGz+TNCeGqvXnyo9TGMiOeE7W6uIV2W6AkuzZ/vt0FxteaL6yfZRhuLk0mbC+d9T2EGMuBlt81BDxYrQ6wUU5Qd08S2zVHr92QRQTWJd6zu1YF3+uWD1QSKdAlBel6O9Sg5Ag/hhqwIsVhDy95iP4TA5tcNR Fb26XlAz b7HrkfRhEvh9AhZ55bZ7Bgqlbl59kz3Pwce3n6o76vCPNfRe2j3LT1wzsW+ziooGHU6rWTYwfDz2ZDxEWtEyJ+HrUXIgTTtjNYulEpWLfVSoafIipY+gHj9zqiK0S0burI4NmQxBwfwH5+dnxLkB+sKrV1Eg1xhhLCvLkt+S9NxKhh8pSKdeJr+mchj8TAGqGkiWAVjDP4+oEGOdjnve0zHexAqRYfNo854qs7OX6ZILZQCB3OwgA/g2StvGdALhSrW3s57RdFg+fsPpWa5x9Ho7XYVpjZiAyELtzdNSD3Fkx8+Sotqrco8GfRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 15, 2023 at 06:39:37PM +0800, Baolin Wang wrote: > Now the isolate_movable_page() can only return 0 or -EBUSY, and no users > will care about the negative return value, thus we can convert the > isolate_movable_page() to return a boolean value to make the code more > clear when checking the movable page isolation state. > > No functional changes intended. > > Signed-off-by: Baolin Wang > Acked-by: David Hildenbrand Reviewed-by: Matthew Wilcox (Oracle) A couple of nits below, not worth respinning the patch series for: > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > index c88b96b48be7..6b252f519c86 100644 > --- a/include/linux/migrate.h > +++ b/include/linux/migrate.h > @@ -71,7 +71,7 @@ extern int migrate_pages(struct list_head *l, new_page_t new, free_page_t free, > unsigned long private, enum migrate_mode mode, int reason, > unsigned int *ret_succeeded); > extern struct page *alloc_migration_target(struct page *page, unsigned long private); > -extern int isolate_movable_page(struct page *page, isolate_mode_t mode); > +extern bool isolate_movable_page(struct page *page, isolate_mode_t mode); You can drop the 'extern' here. > +++ b/mm/memory_hotplug.c > @@ -1668,18 +1668,18 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > * We can skip free pages. And we can deal with pages on > * LRU and non-lru movable pages. > */ > - if (PageLRU(page)) { > + if (PageLRU(page)) > isolated = isolate_lru_page(page); > - ret = isolated ? 0 : -EBUSY; > - } else > - ret = isolate_movable_page(page, ISOLATE_UNEVICTABLE); > - if (!ret) { /* Success */ > + else > + isolated = isolate_movable_page(page, ISOLATE_UNEVICTABLE); > + if (isolated) { /* Success */ I would have dropped the "/* Success */" here. Before, commenting "!ret" is quite sensible, but "isolated" seems obviously success to me. Thanks for doing all this.