From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DA77C64EC4 for ; Wed, 15 Feb 2023 14:25:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 914136B0073; Wed, 15 Feb 2023 09:25:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C28B6B0074; Wed, 15 Feb 2023 09:25:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78A4B6B0075; Wed, 15 Feb 2023 09:25:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6AFD56B0073 for ; Wed, 15 Feb 2023 09:25:11 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 27DD6160162 for ; Wed, 15 Feb 2023 14:25:11 +0000 (UTC) X-FDA: 80469748422.30.60193C6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id 53C8E1C001C for ; Wed, 15 Feb 2023 14:25:09 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=BlpEO19R; spf=none (imf21.hostedemail.com: domain of BATV+22031c8ae556bc37188a+7115+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+22031c8ae556bc37188a+7115+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676471109; a=rsa-sha256; cv=none; b=DZv1e3nbwLYf6yHvNGXUW5RcPO8cU/W1GMaoEqGMnLJzxD3ii7pe943VpRJQgfxUh5mfTo iKdKPPLPs/JpY9vj4UYlW3L1dYjULs1KDat4K/s10jkNRNQKATA5SQlZMo5NzNmIs3GK5s /wRvtEB510+3/LIpxM1Yyk0WIIhJ5f0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=BlpEO19R; spf=none (imf21.hostedemail.com: domain of BATV+22031c8ae556bc37188a+7115+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+22031c8ae556bc37188a+7115+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676471109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9NoGUR70O0zSCDF7awBC8PY/0Nfb60M+m7+9Kbbdg7g=; b=uCm4IhtocvV23pNWNkYlVSdIf651Ao8ro93gMPTuRfgzR2jAc4TfcUNztH0MShnnmES+Ql RcyNMKMaMYj6nepj+V2ppIFoWymlsADhLLU07yvcpaMt3l18FcSrFxNS+ugpAifCy/R6n1 COzpim7X2W3Uit7IkHA2IfAEI3NrRGA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9NoGUR70O0zSCDF7awBC8PY/0Nfb60M+m7+9Kbbdg7g=; b=BlpEO19R+dBG07jw5IxBPhz2S2 Y3fNFYKWHzgpYk1Mpwnx3to/ur0AKtVSruwGS2XeVpLTIFd84jcf59fLHhs4uY/Fd6+CEc8MVtInF nPvc8Q2013EBQhuR3k+R+jC6DAY5yg/vsJiFgTo1Kjy0aJ1mQEUS0a2Yqoew1ArW4t0dxVQZad3Cl pk563FCHmr3eiNyXPPwtkWkVhCCRAETC4Ct5WjNsvyq9B16FKy0r3IMut6Yeuq9UQV+hnZut0L+M6 36DQFRuCK8zV9X6btdVnYkkV/EbPjLdcK6asnlai+GgxxrfIALwVONXp3C6ydqDuGOM8BUxEjY59P U2s9jG4A==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSIiM-006CaN-Ru; Wed, 15 Feb 2023 14:24:54 +0000 Date: Wed, 15 Feb 2023 06:24:54 -0800 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , Matthew Wilcox , Jens Axboe , Al Viro , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzbot+a440341a59e3b7142895@syzkaller.appspotmail.com, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v14 01/12] splice: Fix O_DIRECT file read splice to avoid reversion of ITER_PIPE Message-ID: References: <20230209102954.528942-1-dhowells@redhat.com> <20230209102954.528942-2-dhowells@redhat.com> <909202.1675959337@warthog.procyon.org.uk> <3057147.1676467076@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3057147.1676467076@warthog.procyon.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: 53C8E1C001C X-Rspamd-Server: rspam01 X-Stat-Signature: kmw7aao85hie3xiazoidrfgtttp9ftii X-HE-Tag: 1676471109-21875 X-HE-Meta: U2FsdGVkX18ovSK3X/HG65pAV1dtcqWZbvjP0sKb2lBGCLgDpz5EaksYM6M8lAPuZGGH0NcyOu0tKGZEjAnldI+GFgu9VPwab430Ol2AiuNUB5hnH5CtqF7T446EGRwCJWLmxV0hW4ZrxM25AM5jcxw5yALfUYu9LO3zbiPpfHCVKjx+Vp66b0Tiz/44M5BIFj5IgGhJW2uzKRq28UD/W2gtRwSeVZBkgeaZ3R3xgakq08T/YrYsobKJF5Q34z2i+/mHPW43qjfZoERBa77A27rtS8kzvJUm0DegVVWKI6VawA+CG5lmWnYy0bqnWHbsESNmy2VR6XmEGFrMtQly4ejdnw3C756ekbp9RFwc1gp2YKiIK5eVxl8gv7gazf8uACI9hNysmQ/w5rt19RGG+iUdWECjEF+/XrqFgHx/xqTlPUvsLLLk3zIPXDYiys6mVWzFbcyZuROtGaK/Tilgnb/h8lM05PmR7KgMDlHKgE0EPYtdtuk1yoTKmpUY7k1lzMW80e34sVcrT8YMCxpBkCRHWh0gwJ0tRO4n52PTsT0lSi95pr2Ut9x77rIZ0izJ/MM5yLVZ4BnnG5P6nCayvq276I7AM5gHFysj9mdqyV3LCJuyyFgbN4kUQr18nFGnJ0gfYYfdeq5zT/RDKMEbievhf3fgIRKuHoIt5afRMSNcetUMmAK/b+NJyg4FzU3ORXB3VkD0Uq4f3UzZQTFTC1c/2uyzohhmtVMjS6AVpbnVOmBCf5nnGPsH6QsoAY6EX1qhQLl2QNIs8Uu8XNRXD9xbolUYV2geMOo2Kfs383VUK2KYeWVzhfz7cRVo31ClsED0W3pjtZ76Fo2mNNjQLx9F7094zjN2EKNhrrRyREruRixBdMzKr7Bg5yRRESweXVIAYCgO+DVGhb4nKN2dTmJqY++q7ahyUM4K3Ues94hLC0dNHdNyUEqYMT7c/BAKmYNeFBcU6rFmq/KFxxw iY7EpD65 kFBmZk3vFbiOzVWjX9eBYfzXMbqWcrVFnPwcT8D9aq18Pt23ORsJ30qr51muwQSMcCiRcWguQSpHZ6+4ycyRCK7DsZ2cRQcr12iSPnOKORWBT7LxyZW7Qj0CrVJcZUtXHWOlWF9rH7AIW+az6h2CdSL8cyzp531KL8m5w83ZJZH3JEXkw1cJFuDjCdGOWYtBAN/p6b8XAKpHCOL8rRiDnZHI8tG4DECOAQLUPENESRIPDmNrSwB+G/sxOcpTzQciTLLYMNcvnqLP7AlnpcZ2jcBdHUjw6NWcphfIa8XqwZihhjvzRPCaYgOohbDE8lMowmSCgK+nRkT7IBslO3+mIm1WTVDybgSu60STtOY6/MBLiEEC/qkny3fhjBxAzdkmVi4tjxzwVeXyEtCqskug4sp4dNiKFJDauCSMIr9TlqLeu/n5oDMaiyruCsBiggo47gkp/gBCl614mNTsL2JoE+pAU+H3h5cZVCn/HuDTv4WnLC5NJBRJeiIFTmU3bbSvLws65oifBGcxrINZJXD/7LfYhUBC4sM4IHZ2QKcufmHkj+xg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 15, 2023 at 01:17:56PM +0000, David Howells wrote: > Probably not, but I don't want to fiddle with that right now. I can send a > follow up patch for it. Honestly, I think this rush for 6.3 inclusion is a really bad idea. This series fundamentally changes how splice reads work, and has only been out for about a week. It hasn't even been Cc'ed to Al and Linus which generally have a good knowledge of the splice code and an opinion on it. I think it is a good change, but I'd feel much more comfortable with it for the next merge window rather than rushing it.