From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C57D9C43217 for ; Wed, 12 Oct 2022 16:47:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11AF76B0071; Wed, 12 Oct 2022 12:47:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CB556B0073; Wed, 12 Oct 2022 12:47:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAD706B0074; Wed, 12 Oct 2022 12:47:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D47CF6B0071 for ; Wed, 12 Oct 2022 12:47:47 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 91DFB41290 for ; Wed, 12 Oct 2022 16:47:47 +0000 (UTC) X-FDA: 80012878974.07.A7C0983 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by imf27.hostedemail.com (Postfix) with ESMTP id 1C32440022 for ; Wed, 12 Oct 2022 16:47:45 +0000 (UTC) Received: by mail-wr1-f44.google.com with SMTP id bv10so23531631wrb.4 for ; Wed, 12 Oct 2022 09:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bkYwffHoTj+UGeb69vyYv3Vi6xsZterM+r8p4HSwk3k=; b=qt8qxQtSMmPSznXRe9pn8HRdFJaewZGwEj1d2XqeJIUx7fTdVWUet+16K0OFzpIWK6 Zk5upGfpxB93/w9tOsCA58VK11SJPgjbhNfiqAMe9K5nBOeFP7FusCxGHEYKFmUke4b/ tJRSixQsn1aCq2/YKwKNDqFFhAt4Xek2mA+DovqEa/pSJ4PqV0CNRLDTdYAol3bESito y+A4DoxRkyPPRL4gG+R3UHZhAkPHviiSgz6gRsD7K0aMdi4hn/ReQf9ke+vM6TW5GEuN wsHEWUBDeB5vZm1+IwtfJbyF4nfih/t790IREmOraOJFifaG+hVDFMpPjH/wX9142rvs XmsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bkYwffHoTj+UGeb69vyYv3Vi6xsZterM+r8p4HSwk3k=; b=TZIH4q7k8H8tSmO93ROqHNXCzg8v9Br4KcCTtWpPZ8p4OG0ms+1mFlxrJuYRE4W6PW 4/OPPBEwc0OWf+6io7i1/UsfIZHjCtv3kgs8/kIZwvmO6JUAAOKj4DLuh6PN8UzvCHYR wxZT8u0+nm8ZHu4KkohKcC0UFdkscTJ/Fs7rDsD/rGJRyvh1V8e9obLJCKPq4BmCscBT qPHjOFiH60vDFsAWyhvVoevAoPOGt/fP4nIcnl22IpGZNt/wN3s2eDSCZJzm+veUgtXy vERMQImVOIZZ7B7CbEW9kAc68je4QA/iJpJEGv86v/YI/zEwdY3T2XZp5893kHqCU7nM ZOSw== X-Gm-Message-State: ACrzQf0F3h4A9JtXBHWzT4eiD5huUyZMa2oEdFHNrbfQ8vY8PwnSm1uY CRc7GYq8MnZfad3B7JlRmPY= X-Google-Smtp-Source: AMsMyM5QG/hbTP0GgOdpLWkfLu7at/Wgl1M2fr1LZcGBYHj6q7svLrd3xOaQiLDwa/S213jc6sDvfA== X-Received: by 2002:a05:6000:10d1:b0:22e:3bc5:c91c with SMTP id b17-20020a05600010d100b0022e3bc5c91cmr18250079wrx.368.1665593264626; Wed, 12 Oct 2022 09:47:44 -0700 (PDT) Received: from localhost ([2a03:b0c0:1:d0::dee:c001]) by smtp.gmail.com with ESMTPSA id p22-20020a05600c065600b003c6c2ff7f25sm2056959wmm.15.2022.10.12.09.47.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 09:47:44 -0700 (PDT) Date: Wed, 12 Oct 2022 16:47:43 +0000 From: Stafford Horne To: Christophe Leroy Cc: Baoquan He , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, akpm@linux-foundation.org, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, Jonas Bonn , Stefan Kristiansson , openrisc@lists.librecores.org Subject: Re: [RFC PATCH 2/8] openrisc: mm: remove unneeded early ioremap code Message-ID: References: <9010e8719949cce376dc3f75a97b8bfb2ff98442.1665568707.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9010e8719949cce376dc3f75a97b8bfb2ff98442.1665568707.git.christophe.leroy@csgroup.eu> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665593266; a=rsa-sha256; cv=none; b=MRZW8tlorw8+ZnFxGhLjrsXsgMwqubwUR1dAIgt+LoJohu2w60c4IMGahLVNbcjMXyjaJt FaskEaF8Z/GFQcKuYzw3ZBKoodFAErJHkCchJYnzLuEPrcK1GHNp3HilBtv51QUxjvbMQU ePVyvrxNrUvUVhM9nygiLc505HQzP5M= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qt8qxQtS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of shorne@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=shorne@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665593266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bkYwffHoTj+UGeb69vyYv3Vi6xsZterM+r8p4HSwk3k=; b=fsmcIIRpxe7nrIrWiAvDRIUIJ3VWJTRW8Jbd4xlDsBBCV1BV7TXNder+j9VDvV/CVw80+0 fSJcyTxB8gieUpZtaGh2N2UB1RdsHXvmylWUa1u0LHNBb0mWRKqEZdSQQeQ9SrNrVHuWSj y9tPEYovAGHkw/dLtsOJ7JMR9bnqkqI= X-Stat-Signature: yg6rzocqqrkpgta1tma3r3f6jrgrzgmu X-Rspamd-Queue-Id: 1C32440022 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qt8qxQtS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of shorne@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=shorne@gmail.com X-Rspam-User: X-Rspamd-Server: rspam03 X-HE-Tag: 1665593265-495274 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 12, 2022 at 12:09:38PM +0200, Christophe Leroy wrote: > From: Baoquan He > > Under arch/openrisc, there isn't any place where ioremap() is called. > It means that there isn't early ioremap handling needed in openrisc, > So the early ioremap handling code in ioremap() of > arch/openrisc/mm/ioremap.c is unnecessary and can be removed. > > Signed-off-by: Baoquan He > Cc: Jonas Bonn > Cc: Stefan Kristiansson > Cc: Stafford Horne > Cc: openrisc@lists.librecores.org Thanks for picking this up. Perhaps add this link? Link: https://lore.kernel.org/linux-mm/YwxfxKrTUtAuejKQ@oscomms1/ But either way. Acked-by: Stafford Horne > --- > arch/openrisc/mm/ioremap.c | 22 +++++----------------- > 1 file changed, 5 insertions(+), 17 deletions(-) > > diff --git a/arch/openrisc/mm/ioremap.c b/arch/openrisc/mm/ioremap.c > index 8ec0dafecf25..90b59bc53c8c 100644 > --- a/arch/openrisc/mm/ioremap.c > +++ b/arch/openrisc/mm/ioremap.c > @@ -22,8 +22,6 @@ > > extern int mem_init_done; > > -static unsigned int fixmaps_used __initdata; > - > /* > * Remap an arbitrary physical address space into the kernel virtual > * address space. Needed when the kernel wants to access high addresses > @@ -52,24 +50,14 @@ void __iomem *__ref ioremap(phys_addr_t addr, unsigned long size) > p = addr & PAGE_MASK; > size = PAGE_ALIGN(last_addr + 1) - p; > > - if (likely(mem_init_done)) { > - area = get_vm_area(size, VM_IOREMAP); > - if (!area) > - return NULL; > - v = (unsigned long)area->addr; > - } else { > - if ((fixmaps_used + (size >> PAGE_SHIFT)) > FIX_N_IOREMAPS) > - return NULL; > - v = fix_to_virt(FIX_IOREMAP_BEGIN + fixmaps_used); > - fixmaps_used += (size >> PAGE_SHIFT); > - } > + area = get_vm_area(size, VM_IOREMAP); > + if (!area) > + return NULL; > + v = (unsigned long)area->addr; > > if (ioremap_page_range(v, v + size, p, > __pgprot(pgprot_val(PAGE_KERNEL) | _PAGE_CI))) { > - if (likely(mem_init_done)) > - vfree(area->addr); > - else > - fixmaps_used -= (size >> PAGE_SHIFT); > + vfree(area->addr); > return NULL; > } > > -- > 2.37.1 >