* [PATCH] mm/vmscan: delete rebundant word in comments
@ 2022-10-29 10:04 Shaomin Deng
2022-10-29 12:51 ` Bagas Sanjaya
2022-10-29 14:38 ` Matthew Wilcox
0 siblings, 2 replies; 3+ messages in thread
From: Shaomin Deng @ 2022-10-29 10:04 UTC (permalink / raw)
To: akpm, linux-mm, linux-kernel; +Cc: Shaomin Deng
Delete the repeated word "that" in comments.
Signed-off-by: Shaomin Deng <dengshaomin@cdjrlc.com>
---
mm/vmscan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 27a3f29c0181..2ad2fec6ed3f 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -7053,7 +7053,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)
/*
* There should be no need to raise the scanning priority if
- * enough pages are already being scanned that that high
+ * enough pages are already being scanned that high
* watermark would be met at 100% efficiency.
*/
if (kswapd_shrink_node(pgdat, &sc))
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/vmscan: delete rebundant word in comments
2022-10-29 10:04 [PATCH] mm/vmscan: delete rebundant word in comments Shaomin Deng
@ 2022-10-29 12:51 ` Bagas Sanjaya
2022-10-29 14:38 ` Matthew Wilcox
1 sibling, 0 replies; 3+ messages in thread
From: Bagas Sanjaya @ 2022-10-29 12:51 UTC (permalink / raw)
To: Shaomin Deng; +Cc: akpm, linux-mm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]
On Sat, Oct 29, 2022 at 06:04:31AM -0400, Shaomin Deng wrote:
> Delete the repeated word "that" in comments.
>
Meh...
On what comment?
Also, on patch subject, s/rebundant/redundant/.
> Signed-off-by: Shaomin Deng <dengshaomin@cdjrlc.com>
> ---
> mm/vmscan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 27a3f29c0181..2ad2fec6ed3f 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -7053,7 +7053,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)
Ah! You mean balance_pgdat().
>
> /*
> * There should be no need to raise the scanning priority if
> - * enough pages are already being scanned that that high
> + * enough pages are already being scanned that high
> * watermark would be met at 100% efficiency.
> */
> if (kswapd_shrink_node(pgdat, &sc))
Dunno if the comment above is right.
I have already say to fellow @cdjrlc.com people that you and your team
**IGNORE** patch reviews. If you don't reply to this review, I would like
to just say NAK.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/vmscan: delete rebundant word in comments
2022-10-29 10:04 [PATCH] mm/vmscan: delete rebundant word in comments Shaomin Deng
2022-10-29 12:51 ` Bagas Sanjaya
@ 2022-10-29 14:38 ` Matthew Wilcox
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2022-10-29 14:38 UTC (permalink / raw)
To: Shaomin Deng; +Cc: akpm, linux-mm, linux-kernel
On Sat, Oct 29, 2022 at 06:04:31AM -0400, Shaomin Deng wrote:
> Delete the repeated word "that" in comments.
I think you've misunderstood the comment. NAK.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-29 14:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-29 10:04 [PATCH] mm/vmscan: delete rebundant word in comments Shaomin Deng
2022-10-29 12:51 ` Bagas Sanjaya
2022-10-29 14:38 ` Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).