From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Shaomin Deng <dengshaomin@cdjrlc.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmscan: delete rebundant word in comments
Date: Sat, 29 Oct 2022 19:51:25 +0700 [thread overview]
Message-ID: <Y10hzXgvq+djdQEH@debian.me> (raw)
In-Reply-To: <20221029100431.10825-1-dengshaomin@cdjrlc.com>
[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]
On Sat, Oct 29, 2022 at 06:04:31AM -0400, Shaomin Deng wrote:
> Delete the repeated word "that" in comments.
>
Meh...
On what comment?
Also, on patch subject, s/rebundant/redundant/.
> Signed-off-by: Shaomin Deng <dengshaomin@cdjrlc.com>
> ---
> mm/vmscan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 27a3f29c0181..2ad2fec6ed3f 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -7053,7 +7053,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)
Ah! You mean balance_pgdat().
>
> /*
> * There should be no need to raise the scanning priority if
> - * enough pages are already being scanned that that high
> + * enough pages are already being scanned that high
> * watermark would be met at 100% efficiency.
> */
> if (kswapd_shrink_node(pgdat, &sc))
Dunno if the comment above is right.
I have already say to fellow @cdjrlc.com people that you and your team
**IGNORE** patch reviews. If you don't reply to this review, I would like
to just say NAK.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-10-29 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 10:04 [PATCH] mm/vmscan: delete rebundant word in comments Shaomin Deng
2022-10-29 12:51 ` Bagas Sanjaya [this message]
2022-10-29 14:38 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y10hzXgvq+djdQEH@debian.me \
--to=bagasdotme@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dengshaomin@cdjrlc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).