From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B626FA373D for ; Sun, 23 Oct 2022 20:07:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05D64900003; Sun, 23 Oct 2022 16:07:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00DBD900002; Sun, 23 Oct 2022 16:07:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3F1A900003; Sun, 23 Oct 2022 16:07:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D187D900002 for ; Sun, 23 Oct 2022 16:07:57 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AB7FE1C5DC4 for ; Sun, 23 Oct 2022 20:07:57 +0000 (UTC) X-FDA: 80053300194.17.AF1C7B6 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf09.hostedemail.com (Postfix) with ESMTP id D3CDB140035 for ; Sun, 23 Oct 2022 20:07:56 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 78664CE0F65; Sun, 23 Oct 2022 20:07:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71F4AC433D6; Sun, 23 Oct 2022 20:07:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666555670; bh=Ag/xg2HQiuQje4wmXFAhGvzAEVCH/1G7yr5qMDmyc4M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c63qn7Vui6sNhirZB/Gy8jQQWSTBX6RlPENYbdmf2euXuPTcRwNhSYO/4GuC9R230 DYAEiWjMh6h3KRvLgVBt6+9ddkvTjzfgmsIOhtBL2d8JP2c/AhDIYwLUet8xR2PZbB j0BamdIOibCtH89FdHO9Xp2r2k9u4pmx7fv+eEBSbDGDa6iyDCy6hFl5wtluF0faiA Ymcfo81tjwPf230EWg+JYwdVePTXAI44+YWQp52bB968AbzQ9NhW3lKj5+mXZyombc cTVXEhcS3MLeIP4VXX9V3NPxKSlwdnD2+86NRTWV/5eyFdSaKY0UCqSUOIF9+oQgpA DL3XZLmCsZY7Q== Date: Sun, 23 Oct 2022 23:07:43 +0300 From: Jarkko Sakkinen To: Kefeng Wang Cc: linux-kernel@vger.kernel.org, Andrew Morton , Dinh Nguyen , Dave Hansen , linux-sgx@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-mm@kvack.org Subject: Re: [PATCH 2/5] x86/sgx: use VM_ACCESS_FLAGS Message-ID: References: <20221019034945.93081-1-wangkefeng.wang@huawei.com> <20221019034945.93081-3-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221019034945.93081-3-wangkefeng.wang@huawei.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666555677; a=rsa-sha256; cv=none; b=3BL6mlYX9SVbucMjLxBASSEvaXJ2A4dUvWBaEKe8VS7kdaf/eLInht5N1ELcjg5Dvq23eh ZHkmqgU4cgNAGc6gUFjSjsKbbJ15J5y4cGlIKLUE+EusqbSWjSrVL6kSGOF2r20qDG/Khv lD8WlHqzn00kWN6zOI/8Lh8HDqoD47o= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=c63qn7Vu; spf=pass (imf09.hostedemail.com: domain of jarkko@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666555677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3E3dfw2EXzDZhiCwpUyJLIGz2ZxcLo8PouDmSrgpu20=; b=5Gah4/DpsqC2j8yBR1iP/jDYCmoRPqna3OiYxYlawutYUwUEUUfD1nsMXb0+vnnghr2yiT nkFAoaKa/VXYOUPYpmd6TKj/kWXmTRyaco34EBdnJzwF9wKTb9xFMcVGxqjiCZi73SZU89 08Xtru14sHQu8YgnIgh4p7CHdGJbIBs= X-Stat-Signature: h9jrrto7cnmtbiyarsciwiy8pzuwne5a X-Rspamd-Queue-Id: D3CDB140035 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=c63qn7Vu; spf=pass (imf09.hostedemail.com: domain of jarkko@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1666555676-148130 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 19, 2022 at 11:49:42AM +0800, Kefeng Wang wrote: > Simplify VM_READ|VM_WRITE|VM_EXEC with VM_ACCESS_FLAGS. > > Cc: Jarkko Sakkinen > Cc: Dave Hansen > Signed-off-by: Kefeng Wang > --- > arch/x86/kernel/cpu/sgx/encl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/cpu/sgx/encl.c b/arch/x86/kernel/cpu/sgx/encl.c > index 1ec20807de1e..6225c525372d 100644 > --- a/arch/x86/kernel/cpu/sgx/encl.c > +++ b/arch/x86/kernel/cpu/sgx/encl.c > @@ -268,7 +268,7 @@ static struct sgx_encl_page *sgx_encl_load_page_in_vma(struct sgx_encl *encl, > unsigned long addr, > unsigned long vm_flags) > { > - unsigned long vm_prot_bits = vm_flags & (VM_READ | VM_WRITE | VM_EXEC); > + unsigned long vm_prot_bits = vm_flags & VM_ACCESS_FLAGS; > struct sgx_encl_page *entry; > > entry = xa_load(&encl->page_array, PFN_DOWN(addr)); > @@ -502,7 +502,7 @@ static void sgx_vma_open(struct vm_area_struct *vma) > int sgx_encl_may_map(struct sgx_encl *encl, unsigned long start, > unsigned long end, unsigned long vm_flags) > { > - unsigned long vm_prot_bits = vm_flags & (VM_READ | VM_WRITE | VM_EXEC); > + unsigned long vm_prot_bits = vm_flags & VM_ACCESS_FLAGS; > struct sgx_encl_page *page; > unsigned long count = 0; > int ret = 0; > -- > 2.35.3 > Why? BR, Jarkko