From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9EC9C67871 for ; Tue, 25 Oct 2022 03:26:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BF5980008; Mon, 24 Oct 2022 23:26:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86FAA80007; Mon, 24 Oct 2022 23:26:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 738AA80008; Mon, 24 Oct 2022 23:26:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 66AF680007 for ; Mon, 24 Oct 2022 23:26:07 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 37EC6A0930 for ; Tue, 25 Oct 2022 03:26:07 +0000 (UTC) X-FDA: 80058033174.07.B318F50 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf21.hostedemail.com (Postfix) with ESMTP id CD3301C0006 for ; Tue, 25 Oct 2022 03:26:06 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id t10-20020a17090a4e4a00b0020af4bcae10so10766139pjl.3 for ; Mon, 24 Oct 2022 20:26:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=paDBg16p6YRUPglFeZrsN+RssI7F8VwXvdzXMRIMWZ8=; b=o75qzlM0+kPwb3ZW3hftahzUFIy6ArxiI0FbGOn73VeyLgbCnph2zCmWTL1gWzRAWj QmzL7oD+czpalzF/QSPEr8AfCTx/XjNlvBBzvCsc/G8Ro6gTHZziYnTBI8LVMpbjuBre E4EItFpYhFhm2n3GPtPUA9kSdARq6B/TkDhUqlcThT9yH3sR+Gxi8S2nw6cCOC0oNZuG IwrvNZSljR7NdGR2yXXb1OUpRp0MbhCkGW2gmgEgIIsQz3J5G33E7u+hA+MAgjni32Ic 3wS40G5w97hLnPF1fs8GRAyk3GYriudAHBtE8MYVYq0nBxqcMk16IXBIUy2r9NFRRTQh JSPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=paDBg16p6YRUPglFeZrsN+RssI7F8VwXvdzXMRIMWZ8=; b=YLC0hNoTD7vhA9nhav1LnxxbCEI9qXCvkMI16JcbIXHoUF/YhOZef4eZNKFRqZv36y Jfg2/HzP4m4LbegS6eA/tgbwJoWVSGkTVJcfS4g0i6jntxtR7pCzI8pFuePpcqrcCs+E lRd4Z3YaQFXhgaze2WnNdbQlknHSdXxpgN1MSjdmMZiWQcG8f2lUnpCUYgjJkbp9AraK FI6s0Kq0XvLTW99cpkYD0eVaxyv8WQY9X5wk/Ny9VcO0aZejxPQaDlE1F5wKXzseiwhy AqaHpcYXyMVGr9LSPJcoG7iNw3tIN/cPx0UMqHkS9F41wLXbQfeGPY5WjCDU7FpliPwe cyZA== X-Gm-Message-State: ACrzQf3sD7gYAH7gyFF+X2aVH4ZJu5p++mPLY2ucBq6Q6w5SKZEevqKD +utN3H70wTuyWKalRoCFBok= X-Google-Smtp-Source: AMsMyM7woeVXOy9+FfMmuYzQm+OPdUEiGb3oaSK4p9PxL+CEZStmaJcRzE6iFkyJ2RIgIo2LxSPjgw== X-Received: by 2002:a17:902:d64d:b0:186:634e:5517 with SMTP id y13-20020a170902d64d00b00186634e5517mr25462476plh.3.1666668365663; Mon, 24 Oct 2022 20:26:05 -0700 (PDT) Received: from debian.me (subs32-116-206-28-62.three.co.id. [116.206.28.62]) by smtp.gmail.com with ESMTPSA id s5-20020a656445000000b00462ae17a1c4sm437781pgv.33.2022.10.24.20.26.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 20:26:05 -0700 (PDT) Received: by debian.me (Postfix, from userid 1000) id 7B3D21002B9; Tue, 25 Oct 2022 10:26:01 +0700 (WIB) Date: Tue, 25 Oct 2022 10:26:01 +0700 From: Bagas Sanjaya To: Sergey Senozhatsky Cc: Andrew Morton , Minchan Kim , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/6] zsmalloc/zram: configurable zspage size Message-ID: References: <20221024161213.3221725-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5BUiyQSp/khvQ8r+" Content-Disposition: inline In-Reply-To: <20221024161213.3221725-1-senozhatsky@chromium.org> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666668366; a=rsa-sha256; cv=none; b=sbgQAhZlG8vTrDKbHuxlukQHgvWLLHmr1bdiVOmvvfgxK8iWDdrLEYJxDtUrN8FtYJ8HBO irUUgaUMkZYi1Og0si0SBewEgUV9vAjTYINBzYByLx5S4IPjioHz7Xu6a747S3hnzbD1Hi hH8boyNfC6C2IGYoV8QhXYKGfW2l74U= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=o75qzlM0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666668366; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=paDBg16p6YRUPglFeZrsN+RssI7F8VwXvdzXMRIMWZ8=; b=xgsjrLWZXM2eJ7jYXbQrmZJ79ZhF3EaXTdMRs1wYp3vV9hY0k3MfWIC5d0g8LFJN1lkaro 9QJgTQ7nK+yyEA/JD7zlTN1+fQZaCho98jrNb+p44ZBjnf13ND3/uoZMdfNfoSRgZcWQGn WRH6xx8Fz41G7ILFFMWn+Vb3TdZRyKI= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CD3301C0006 X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=o75qzlM0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com X-Stat-Signature: cmr3cje1pcgu8m4sew9cwxsxqppx16o4 X-HE-Tag: 1666668366-150060 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --5BUiyQSp/khvQ8r+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 25, 2022 at 01:12:07AM +0900, Sergey Senozhatsky wrote: > Hello, >=20 > Some use-cases and/or data patterns may benefit from > larger zspages. Currently the limit on the number of physical > pages that are linked into a zspage is hardcoded to 4. Higher > limit changes key characteristics of a number of the size > clases, improving compactness of the pool and redusing the > amount of memory zsmalloc pool uses. >=20 > For instance, the huge size class watermark is currently set > to 3264 bytes. With order 3 zspages we have more normal classe > and huge size watermark becomes 3632. With order 4 zspages > huge size watermark becomes 3840. >=20 > Commit #1 has more numbers and some analysis. >=20 > Sergey Senozhatsky (6): > zsmalloc: turn zspage order into runtime variable > zsmalloc/zram: pass zspage order to zs_create_pool() > zram: add pool_page_order device attribute > Documentation: document zram pool_page_order attribute > zsmalloc: break out of loop when found perfect zspage order > zsmalloc: make sure we select best zspage size >=20 > Documentation/admin-guide/blockdev/zram.rst | 31 +++++-- > drivers/block/zram/zram_drv.c | 44 ++++++++- > drivers/block/zram/zram_drv.h | 2 + > include/linux/zsmalloc.h | 15 +++- > mm/zsmalloc.c | 98 +++++++++++++-------- > 5 files changed, 145 insertions(+), 45 deletions(-) >=20 Sorry, I can't cleanly apply this patch series due to conflicts in patch [1/6]. On what tree and commit the series is based? --=20 An old man doll... just what I always wanted! - Clara --5BUiyQSp/khvQ8r+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY1dXRAAKCRD2uYlJVVFO oxsdAP0czu/j5ZhnUC/xT78qaPXkUubnV2evpencu4KBrAcyigEAsYKD77TJp0VY 0n2vNLsoCAN9P3HtQaUYONTu6nC3TQs= =SGwH -----END PGP SIGNATURE----- --5BUiyQSp/khvQ8r+--