From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53992C04A95 for ; Tue, 25 Oct 2022 12:38:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80BB38E0002; Tue, 25 Oct 2022 08:38:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BB5D8E0001; Tue, 25 Oct 2022 08:38:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AA508E0002; Tue, 25 Oct 2022 08:38:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5EEFC8E0001 for ; Tue, 25 Oct 2022 08:38:11 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 32C191A09AD for ; Tue, 25 Oct 2022 12:38:11 +0000 (UTC) X-FDA: 80059424382.08.6A84B3D Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf12.hostedemail.com (Postfix) with ESMTP id B62DA4001A for ; Tue, 25 Oct 2022 12:38:10 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id f5-20020a17090a4a8500b002131bb59d61so1188008pjh.1 for ; Tue, 25 Oct 2022 05:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UYUaukjgG6ZPIhZG6+5xi4ihALsr7hi5S92eDWaX9Js=; b=LPbQLK3/YEUNHpbsljFlrrNkHOjHg+b2Dl5khLYRIbkIc2Ok43F9bS7v9pNBFXrOvv phAIH/D60w4A/LMnQeL0X2hKEfTNDJzuv4KVe4V1nRRguqPe5/WvrDQRgGGf1MPYpQFX enIRpGTAZ3QI/yhZN2q44OAv6xXh726SC6qEc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UYUaukjgG6ZPIhZG6+5xi4ihALsr7hi5S92eDWaX9Js=; b=TAw42+A5B2HTT8q3EUmu0XBRQNJcxKrsbT3ToKCdoiO9vdlrsDEPIu/xsFhTycg99S XcByG7s3iZRqAZognpArGMA9ZU+iCIalPm1D4fr7pCGdQCmuL46tQU/dO3pB9+wNx4CM JpFfrvQ9mATv7qc3iL25ystyp2ADAUEZvNCVNoP37BXZkUqEQuUtmJNsMpajGNjTrKeS b4fv9CREw/dkblHIznqR0U/H8pvXF8ovipQA9DSdQQ0djvAkdJmXXo3rM+JQtJtQnPiK Xwn0s9qN31BacJlQu2s8OnavRzn144ty9dIZ+P+Er1stKxuWgGoiPhTbJVrqiH49DlVp LWjg== X-Gm-Message-State: ACrzQf1bQnG0MfJG7cPx59llSQYigSoSnlpslDBH4hg3GPPqNXPjXgT/ 3RzgQVCr62PDtnNwsoEnGcso1w== X-Google-Smtp-Source: AMsMyM4MWOqMmrWGjwKGNIaaUovq7sl3ktd2m4jnMt70aw/tyTH0H7AFGOSXvkCh3E4d88EJYIykcw== X-Received: by 2002:a17:90b:1e0c:b0:20f:bcbf:ab5 with SMTP id pg12-20020a17090b1e0c00b0020fbcbf0ab5mr42924589pjb.187.1666701489563; Tue, 25 Oct 2022 05:38:09 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:c493:65a6:2d64:1325]) by smtp.gmail.com with ESMTPSA id p13-20020a170902e74d00b0017a018221e2sm1177082plf.70.2022.10.25.05.38.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 05:38:09 -0700 (PDT) Date: Tue, 25 Oct 2022 21:38:04 +0900 From: Sergey Senozhatsky To: Aleksey Romanov Cc: Sergey Senozhatsky , Andrew Morton , "minchan@kernel.org" , "ngupta@vflare.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , kernel Subject: Re: [PATCH v1] zram: add size class equals check into recompression Message-ID: References: <20221024120942.13885-1-avromanov@sberdevices.ru> <20221025094859.7kbcqknlkmo4hj2y@cab-wsm-0029881.lan> <20221025115542.5o4igroslirn6cxy@cab-wsm-0029881.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221025115542.5o4igroslirn6cxy@cab-wsm-0029881.lan> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666701490; a=rsa-sha256; cv=none; b=8TZe2492kmtFqxeHQju/B6RrFdByvrBJqG2VKaA4Q5Gk1jpe7hcFVssAgYdCMtA5nWEXmd J6CgQfF9ZKDC1VctUY9th/59dDAflJsDGEVIBsEHVtSc69GAm4SRdB4kY+bc81djiX/tf9 k5697uRF+z+msMT0m2Qq6VwXM999k5U= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="LPbQLK3/"; spf=pass (imf12.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666701490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UYUaukjgG6ZPIhZG6+5xi4ihALsr7hi5S92eDWaX9Js=; b=UYyeoxLtwXi87eYngRXcfIvDaXKLsBk6gpUKG9mbnzT6skG84tq9NUDqSpq8ygKM2PCE2D sPLt/9ojx5q70Ac/rwZ/ImxTv0pXU56vlkCFbz+zr9X6Uj8cdiUOP8OSb6j4CBwsQyatBE jZIleHV/61zK3O9Ymr/i8ygU4Bi3RjM= X-Stat-Signature: 49r48tqe9zxoe7zeew7beb8cqyzf3sdd X-Rspamd-Queue-Id: B62DA4001A Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="LPbQLK3/"; spf=pass (imf12.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1666701490-584330 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/10/25 11:55), Aleksey Romanov wrote: > > Return: the index of the zsmalloc &size_class that hold objects of the > > provided size. > > > > unsigned int zs_lookup_class_index(struct zs_pool *pool, unsigned int size) > > { > > struct size_class *class = pool->size_class[get_size_class_index(size)]; > > > > return class->index; > > } > > Sure. I think it would be more logical, and perhaps such a function > would be more applicable in other cases, in the future. > > Will you fix it in your cherry-pick? For that I probably will ask you to send out v2, if possible.