From: Sean Christopherson <seanjc@google.com>
To: Peter Xu <peterx@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
John Hubbard <jhubbard@nvidia.com>,
Paolo Bonzini <pbonzini@redhat.com>,
David Matlack <dmatlack@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
David Hildenbrand <david@redhat.com>,
Linux MM Mailing List <linux-mm@kvack.org>,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [PATCH v4 2/4] kvm: Add KVM_PFN_ERR_SIGPENDING
Date: Wed, 26 Oct 2022 22:48:07 +0000 [thread overview]
Message-ID: <Y1m5J2+6AcYHUf4P@google.com> (raw)
In-Reply-To: <20221011195809.557016-3-peterx@redhat.com>
Uber nit, s/kvm/KVM for the shortlog,
On Tue, Oct 11, 2022, Peter Xu wrote:
> Add a new pfn error to show that we've got a pending signal to handle
Please avoid pronouns in changelogs and comments, they're unnecessarily ambiguous.
E.g.
Add a new pfn error to capture that hva_to_pfn_slow() failed due to a
pending signal. The new error will be used in future patches to
propagate -EINTR back to userspace instead of returning -EFAULT.
> during hva_to_pfn_slow() procedure (of -EINTR retval).
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
Nits aside,
Reviewed-by: Sean Christopherson <seanjc@google.com>
next prev parent reply other threads:[~2022-10-26 22:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 19:58 [PATCH v4 0/4] kvm/mm: Allow GUP to respond to non fatal signals Peter Xu
2022-10-11 19:58 ` [PATCH v4 1/4] mm/gup: Add FOLL_INTERRUPTIBLE Peter Xu
2022-11-02 17:06 ` Paolo Bonzini
2022-10-11 19:58 ` [PATCH v4 2/4] kvm: Add KVM_PFN_ERR_SIGPENDING Peter Xu
2022-10-26 22:48 ` Sean Christopherson [this message]
2022-10-11 19:58 ` [PATCH v4 3/4] kvm: Add interruptible flag to __gfn_to_pfn_memslot() Peter Xu
2022-10-26 22:49 ` Sean Christopherson
2022-10-11 19:59 ` [PATCH v4 4/4] kvm: x86: Allow to respond to generic signals during slow PF Peter Xu
2022-10-26 22:51 ` Sean Christopherson
2022-10-26 22:52 ` [PATCH v4 0/4] kvm/mm: Allow GUP to respond to non fatal signals Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1m5J2+6AcYHUf4P@google.com \
--to=seanjc@google.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dmatlack@google.com \
--cc=jhubbard@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).