From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D49DC38A2D for ; Wed, 26 Oct 2022 22:48:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B37B8E0002; Wed, 26 Oct 2022 18:48:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 562978E0001; Wed, 26 Oct 2022 18:48:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42AA68E0002; Wed, 26 Oct 2022 18:48:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 32C6F8E0001 for ; Wed, 26 Oct 2022 18:48:29 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D358F80116 for ; Wed, 26 Oct 2022 22:48:28 +0000 (UTC) X-FDA: 80064591096.20.8C4FB17 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf25.hostedemail.com (Postfix) with ESMTP id 82032A0011 for ; Wed, 26 Oct 2022 22:48:28 +0000 (UTC) Received: by mail-pg1-f172.google.com with SMTP id f9so12071173pgj.2 for ; Wed, 26 Oct 2022 15:48:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0YtP+k+6uts8m9tNmFsigaW1IdIDo2sBUM/m3vJA+cQ=; b=oH1lHDkxtfk94OzKVfdbwe6bUoopLQw8Fghgdm0DYNrRhRldudBMola+VmESIeCxE0 xYiDR++f8zbRrdUq2GGtiY9GCOFV2OgDsTxliRWveBhCoMqtQ47QG6DhCMIX2MT82B4D Cs9u7o3QPDOAS415bfY/rVRZnuiqymrnbTL1wo17/9KZBKWDjykX5vAMc/FDvgNz/qAR iJctqm16e1YVEnopCQtXwoeF/1IXX+Q4AlYELqB5yiDAtlJneoDvIkYrvbCf8IosAOJt 1UbU5g70iqur0DCnv17npW+TPdxuSZJuR1iGbsR62f5gOSuEzAqyHXfMQe+k89YIDTNL vCPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0YtP+k+6uts8m9tNmFsigaW1IdIDo2sBUM/m3vJA+cQ=; b=3NB94w8txc3YVDYkHJhy24PXG7SVmvdLg+Ow4sOOHEoyvwZXeLNf4BXSEJuxwrBZtK C2BuKk8kPBO2e//G9c8gYQmfs9h+psei5L8dnYGOZbiyOHsgznr4jxY7DVCTRS/3UT9H EGGvS/CSQ/5pZ+vZ9NdIZb53YrgneS9xFTl96DnzEh/+66hHuT7r+7pa8fB+KMxlfD+s Q50FL0GhbK+imyHi5Iz/QGINT8xSinTfcTJeHaStPL9akTqOrCOGMb8/T+3h9S+e9Ad+ RwxDQg63WXKGFUCy6v+hjungEsVJc6KzTtN6n0s87KOl5WmOSf7LGnbBV+64EM6RehTY eyBA== X-Gm-Message-State: ACrzQf109ZUQwMShpm2PWS4XsVOt2NdcG6O/kqxptyiZMoj7pVkjUPCB UZ+o+BvtluZCB1bZ9O0mFSr3rg== X-Google-Smtp-Source: AMsMyM4G9zTFrU6aX0grlDJI8Q2JBxZqVIsOeKPjDFIE4dCdLpZvssF+F8UMJwT79BWrXJLwGRwTGw== X-Received: by 2002:a63:5425:0:b0:450:738:9a78 with SMTP id i37-20020a635425000000b0045007389a78mr38496648pgb.429.1666824507430; Wed, 26 Oct 2022 15:48:27 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id ij1-20020a170902ab4100b0015e8d4eb26esm3372997plb.184.2022.10.26.15.48.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 15:48:22 -0700 (PDT) Date: Wed, 26 Oct 2022 22:48:07 +0000 From: Sean Christopherson To: Peter Xu Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, John Hubbard , Paolo Bonzini , David Matlack , Andrew Morton , Andrea Arcangeli , "Dr . David Alan Gilbert" , David Hildenbrand , Linux MM Mailing List , Mike Kravetz Subject: Re: [PATCH v4 2/4] kvm: Add KVM_PFN_ERR_SIGPENDING Message-ID: References: <20221011195809.557016-1-peterx@redhat.com> <20221011195809.557016-3-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221011195809.557016-3-peterx@redhat.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666824508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0YtP+k+6uts8m9tNmFsigaW1IdIDo2sBUM/m3vJA+cQ=; b=LKug8d/xYVyKBm3ySWSb50wmU3MtxPYrH7Ct+XyuCYi3OdfqYl2KIZbP/usXQsRy4Tha1P 2NdJqThR/vWOk5b7K17TUlFjPMc1U/kKfNuxIDtJx42MgQnMVl301EftWj57JFTyVChnUl JEEKI8LG8+c9VGRENbeSWp+voBfSMRY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=oH1lHDkx; spf=pass (imf25.hostedemail.com: domain of seanjc@google.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666824508; a=rsa-sha256; cv=none; b=dFIorfNq+RiwYaqh4TeNETLlA5+toj7qralN0ONSHFCpodcSOBUdi1eBHrazah1tJtXRvq VwwlDiV+C25+XrCj5My79kFbBGqKFat5+DdkNBXjMRoRIJRPjFBHNbaTeun24zZWQGojGw xmg6swHFTdXfDCXiK2b9QXmkWGR3TNs= X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 82032A0011 X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=oH1lHDkx; spf=pass (imf25.hostedemail.com: domain of seanjc@google.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 8w1371j8gapjc7my8manxdo1jzmohyif X-HE-Tag: 1666824508-797303 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Uber nit, s/kvm/KVM for the shortlog, On Tue, Oct 11, 2022, Peter Xu wrote: > Add a new pfn error to show that we've got a pending signal to handle Please avoid pronouns in changelogs and comments, they're unnecessarily ambiguous. E.g. Add a new pfn error to capture that hva_to_pfn_slow() failed due to a pending signal. The new error will be used in future patches to propagate -EINTR back to userspace instead of returning -EFAULT. > during hva_to_pfn_slow() procedure (of -EINTR retval). > > Signed-off-by: Peter Xu > --- Nits aside, Reviewed-by: Sean Christopherson