From: Wei Liu <wei.liu@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Wei Liu <wei.liu@kernel.org>,
Shradha Gupta <shradhagupta@linux.microsoft.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-hyperv@vger.kernel.org,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Dexuan Cui <decui@microsoft.com>,
Michael Kelley <mikelley@microsoft.com>
Subject: Re: [PATCH v2 1/2] mm/page_reporting: Add checks for page_reporting_order param
Date: Fri, 28 Oct 2022 10:38:39 +0000 [thread overview]
Message-ID: <Y1uxLyaLlKp2sfkD@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20221027132207.bb4e9408e1ca94b3dfaca405@linux-foundation.org>
On Thu, Oct 27, 2022 at 01:22:07PM -0700, Andrew Morton wrote:
> On Wed, 26 Oct 2022 15:33:47 +0000 Wei Liu <wei.liu@kernel.org> wrote:
>
> > On Thu, Sep 29, 2022 at 11:01:38PM -0700, Shradha Gupta wrote:
> > > Current code allows the page_reporting_order parameter to be changed
> > > via sysfs to any integer value. The new value is used immediately
> > > in page reporting code with no validation, which could cause incorrect
> > > behavior. Fix this by adding validation of the new value.
> > > Export this parameter for use in the driver that is calling the
> > > page_reporting_register().
> > > This is needed by drivers like hv_balloon to know the order of the
> > > pages reported. Traditionally the values provided in the kernel boot
> > > line or subsequently changed via sysfs take priority therefore, if
> > > page_reporting_order parameter's value is set, it takes precedence
> > > over the value passed while registering with the driver.
> > >
> > > Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
> >
> > Andrew and other MM reviewers, can I get an ack / nack for this patch?
>
> Looks OK to me. Can this be merged via the hyperv tree?
Yes, I can take of merging it.
I will add your acked-by to the patch.
Thanks,
Wei.
next prev parent reply other threads:[~2022-10-28 10:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 10:24 [PATCH 0/2] Configurable order free page reporting in hyper-v Shradha Gupta
2022-09-29 10:24 ` [PATCH 1/2] mm/page_reporting: Add checks for page_reporting_order param value Shradha Gupta
2022-10-01 8:00 ` kernel test robot
2022-10-01 9:49 ` kernel test robot
2022-09-30 6:01 ` [PATCH v2 0/2] Configurable order free page reporting in hyper-v Shradha Gupta
2022-09-30 6:01 ` [PATCH v2 1/2] mm/page_reporting: Add checks for page_reporting_order param Shradha Gupta
2022-10-17 15:49 ` Michael Kelley (LINUX)
2022-10-26 15:33 ` Wei Liu
2022-10-27 20:22 ` Andrew Morton
2022-10-28 10:38 ` Wei Liu [this message]
2022-09-30 6:01 ` [PATCH v2 2/2] hv_balloon: Add support for configurable order free page reporting Shradha Gupta
2022-10-17 15:53 ` Michael Kelley (LINUX)
2022-10-28 10:42 ` [PATCH v2 0/2] Configurable order free page reporting in hyper-v Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1uxLyaLlKp2sfkD@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mikelley@microsoft.com \
--cc=shradhagupta@linux.microsoft.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).