From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4D99ECAAA1 for ; Fri, 28 Oct 2022 10:38:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FC456B0074; Fri, 28 Oct 2022 06:38:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1ADE06B0075; Fri, 28 Oct 2022 06:38:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 074B76B0078; Fri, 28 Oct 2022 06:38:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E7FEF6B0074 for ; Fri, 28 Oct 2022 06:38:43 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BEED71C6D83 for ; Fri, 28 Oct 2022 10:38:43 +0000 (UTC) X-FDA: 80070009726.24.3FB0F75 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf22.hostedemail.com (Postfix) with ESMTP id 5D19FC0003 for ; Fri, 28 Oct 2022 10:38:43 +0000 (UTC) Received: by mail-wm1-f44.google.com with SMTP id y10so3007492wma.0 for ; Fri, 28 Oct 2022 03:38:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kyduwU+qbCAifE/OEo9fpCfyJvonnxXGOOWJeQlafrk=; b=O4gt+9lwKznYPqjzXNI3uyxEnixfsTi0WvSn+tYYs8bL6U5w8TEjGs1zSZEVKd013A tHWRAj9mZ+yh2uXw0HnFFE7fnQwuDlHZi14oCC0QKuZSVNvEDPBJUsZg9nahhd1EVeuQ gs6Nywo2QbJtgNgKPgWg/l/XGmHLd+tReuwjouT7wAfJ9pf1ZDWUCZKA1PfDLd07J/nN p+kzX7jcbL0GUY6VdT7/Xut6MCz8m5LTbNpVqgkcBI/w6avAh4g36FxxlytYaIg7PWp+ iQA5Xt1U0ZuqD3zEwb+LJoxCxt/0Mfa3/SHQDGdKaat9Gpog0DWO37AlCtjuIBLzrKtE 1RRg== X-Gm-Message-State: ACrzQf13J69wSgZg283O5FZ91IZamSYAwxvAa+5bgEuv4pQhYhINs2io UsHwGVbJG9N0djcmqLDhDZc= X-Google-Smtp-Source: AMsMyM6+r0/UdXjkcGQZIm+YyMf8VdMFCya9QSxoMVd6/EmHzp/NQ//5ZfB0f7jWKFMWZcO/FdaC1A== X-Received: by 2002:a1c:a102:0:b0:3cf:4792:d3a2 with SMTP id k2-20020a1ca102000000b003cf4792d3a2mr8742630wme.55.1666953521904; Fri, 28 Oct 2022 03:38:41 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id r9-20020a05600c458900b003b4ac05a8a4sm9171691wmo.27.2022.10.28.03.38.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 03:38:41 -0700 (PDT) Date: Fri, 28 Oct 2022 10:38:39 +0000 From: Wei Liu To: Andrew Morton Cc: Wei Liu , Shradha Gupta , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Dexuan Cui , Michael Kelley Subject: Re: [PATCH v2 1/2] mm/page_reporting: Add checks for page_reporting_order param Message-ID: References: <1664447081-14744-1-git-send-email-shradhagupta@linux.microsoft.com> <1664517699-1085-1-git-send-email-shradhagupta@linux.microsoft.com> <1664517699-1085-2-git-send-email-shradhagupta@linux.microsoft.com> <20221027132207.bb4e9408e1ca94b3dfaca405@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221027132207.bb4e9408e1ca94b3dfaca405@linux-foundation.org> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666953523; a=rsa-sha256; cv=none; b=CfIJRdLxWJlXazdrfDKLV1B8Kgfhmrgyfx9a0hlLVAwqGi1Vkmr6GHYq5oSOlTLjY7Cn+c hMMgsjeV6i2o0uerMcXq7h8C9Gj2RPcV/YJsHLin9nb5v7qioBF0qyqYA9w8AXY51XK7x2 9ysPfpmeXqAxqbqHBa53ac0pju6HqWQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf22.hostedemail.com: domain of wei.liu.linux@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=wei.liu.linux@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666953523; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kyduwU+qbCAifE/OEo9fpCfyJvonnxXGOOWJeQlafrk=; b=EPZZhBTZ42aU0l/5N31MEkDxpC/fF7xHn/ByXWa896xE+1408p0iD3/nmiN9bPWIw2LEy/ XwhZTaAzTb3IK6gwR5TXg93MhrfglADqIW+Gg+jruyp+wjVQM0lJR3KWdjInki5utlO5/K /n3SJcKSJtucpnpDQXEJsa/JucOWhpg= X-Stat-Signature: n7qeq4mcoejjba87438p141fz1p51juk X-Rspamd-Queue-Id: 5D19FC0003 X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf22.hostedemail.com: domain of wei.liu.linux@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=wei.liu.linux@gmail.com X-Rspamd-Server: rspam09 X-HE-Tag: 1666953523-645604 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 27, 2022 at 01:22:07PM -0700, Andrew Morton wrote: > On Wed, 26 Oct 2022 15:33:47 +0000 Wei Liu wrote: > > > On Thu, Sep 29, 2022 at 11:01:38PM -0700, Shradha Gupta wrote: > > > Current code allows the page_reporting_order parameter to be changed > > > via sysfs to any integer value. The new value is used immediately > > > in page reporting code with no validation, which could cause incorrect > > > behavior. Fix this by adding validation of the new value. > > > Export this parameter for use in the driver that is calling the > > > page_reporting_register(). > > > This is needed by drivers like hv_balloon to know the order of the > > > pages reported. Traditionally the values provided in the kernel boot > > > line or subsequently changed via sysfs take priority therefore, if > > > page_reporting_order parameter's value is set, it takes precedence > > > over the value passed while registering with the driver. > > > > > > Signed-off-by: Shradha Gupta > > > > Andrew and other MM reviewers, can I get an ack / nack for this patch? > > Looks OK to me. Can this be merged via the hyperv tree? Yes, I can take of merging it. I will add your acked-by to the patch. Thanks, Wei.