From: Johannes Weiner <hannes@cmpxchg.org>
To: Nhat Pham <nphamcs@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, minchan@kernel.org,
ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com,
ddstreet@ieee.org, vitaly.wool@konsulko.com
Subject: Re: [PATCH 2/5] zsmalloc: Consolidate zs_pool's migrate_lock and size_class's locks
Date: Fri, 28 Oct 2022 10:46:36 -0400 [thread overview]
Message-ID: <Y1vrTI3G4xitvFEr@cmpxchg.org> (raw)
In-Reply-To: <20221026200613.1031261-3-nphamcs@gmail.com>
On Wed, Oct 26, 2022 at 01:06:10PM -0700, Nhat Pham wrote:
> Currently, zsmalloc has a hierarchy of locks, which includes a
> pool-level migrate_lock, and a lock for each size class. We have to
> obtain both locks in the hotpath in most cases anyway, except for
> zs_malloc. This exception will no longer exist when we introduce a LRU
> into the zs_pool for the new writeback functionality - we will need to
> obtain a pool-level lock to synchronize LRU handling even in zs_malloc.
>
> In preparation for zsmalloc writeback, consolidate these locks into a
> single pool-level lock, which drastically reduces the complexity of
> synchronization in zsmalloc.
>
> Suggested-by: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Nhat Pham <nphamcs@gmail.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2022-10-28 14:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 20:06 [PATCH 0/5] Implement writeback for zsmalloc Nhat Pham
2022-10-26 20:06 ` [PATCH 1/5] zswap: fix writeback lock ordering " Nhat Pham
2022-10-26 20:06 ` [PATCH 2/5] zsmalloc: Consolidate zs_pool's migrate_lock and size_class's locks Nhat Pham
2022-10-28 14:46 ` Johannes Weiner [this message]
2022-11-02 3:28 ` Sergey Senozhatsky
2022-11-02 21:36 ` Minchan Kim
2022-11-03 15:18 ` Johannes Weiner
2022-11-03 15:53 ` Minchan Kim
2022-11-03 18:08 ` Johannes Weiner
2022-11-03 18:10 ` Yosry Ahmed
2022-11-03 20:37 ` Minchan Kim
2022-11-03 20:46 ` Yosry Ahmed
2022-11-03 21:15 ` Yu Zhao
2022-11-03 23:19 ` Yosry Ahmed
2022-11-03 21:43 ` Minchan Kim
2022-11-03 23:31 ` Yosry Ahmed
2022-11-03 20:22 ` Minchan Kim
2022-11-04 3:58 ` Sergey Senozhatsky
2022-11-07 21:31 ` Nhat Pham
2022-11-07 22:35 ` Minchan Kim
2022-10-26 20:06 ` [PATCH 3/5] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order Nhat Pham
2022-10-28 14:47 ` Johannes Weiner
2022-10-26 20:06 ` [PATCH 4/5] zsmalloc: Add ops fields to zs_pool to store evict handlers Nhat Pham
2022-10-28 15:18 ` Johannes Weiner
2022-11-02 4:10 ` Sergey Senozhatsky
2022-11-07 21:36 ` Nhat Pham
2022-10-26 20:06 ` [PATCH 5/5] zsmalloc: Implement writeback mechanism for zsmalloc Nhat Pham
2022-10-27 13:53 ` kernel test robot
2022-10-27 18:27 ` [PATCH v2 " Nhat Pham
2022-10-28 15:19 ` Johannes Weiner
2022-11-02 3:42 ` Sergey Senozhatsky
2022-11-03 15:26 ` Johannes Weiner
2022-11-02 3:44 ` Sergey Senozhatsky
2022-11-02 4:13 ` Sergey Senozhatsky
2022-11-03 16:45 ` Johannes Weiner
2022-11-04 4:02 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1vrTI3G4xitvFEr@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).