From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3FB9C4332F for ; Fri, 11 Nov 2022 20:47:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A4748E0011; Fri, 11 Nov 2022 15:47:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 253C68E0008; Fri, 11 Nov 2022 15:47:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 127E98E0011; Fri, 11 Nov 2022 15:47:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0052D8E0008 for ; Fri, 11 Nov 2022 15:47:00 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B487B1601F2 for ; Fri, 11 Nov 2022 20:47:00 +0000 (UTC) X-FDA: 80122345800.25.AD28780 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf04.hostedemail.com (Postfix) with ESMTP id 13D5E40009 for ; Fri, 11 Nov 2022 20:46:59 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D0608B8260C; Fri, 11 Nov 2022 20:46:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16855C433D6; Fri, 11 Nov 2022 20:46:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668199616; bh=+aijmCyFee7qWFeNljZb8zYD5+XuzsnyGaxX9FEYxpk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UnwFL8wuWkoZyhSHDqs67j/LsmCKgpcpww1g7jCaWZ36JihNBOGBStyV6m2p2YLp+ m2905fbVL3d+YYvg5Yw6+fM2rewxOIR0BXA5PJNQb7wbR7rut9I32ZzXzgtbxINfcn ywzelh60+IhLjCHgH9LQeBHlGFBz+Su/dtPQQ7KQ5eWGcMuTG6UyLYdWb1u1/m+WfT AWnvj4oYpVtx2Yi88aEsVMDJHNkhw4lVBU9k1Di7od31GKlIx8ow4kj7mjLq5dO6Vi ujvifadc6imBUFXqg2RbvXS48bE0aDe4bgAMQCOKMiv9+sqVG6Zl0x5Xv7jiRhT7w9 B9u+Kk/K+VpHw== Date: Fri, 11 Nov 2022 20:46:46 +0000 From: Conor Dooley To: Vlastimil Babka Cc: Pasha Tatashin , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Matthew Wilcox , Roman Gushchin , Linus Torvalds , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Catalin Marinas , Rustam Kovhaev , Andrew Morton , Josh Triplett , Arnd Bergmann , Russell King , Alexander Shiyan , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Yoshinori Sato , Rich Felker , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "linux-arm-kernel@lists.infradead.org" , openrisc@lists.librecores.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, Geert Uytterhoeven , Conor.Dooley@microchip.com, Damien Le Moal , Paul Cercueil Subject: Re: Deprecating and removing SLOB Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668199620; a=rsa-sha256; cv=none; b=bHVkaOfAoeoLwpHlnNxS5w/kdfLB5eDTDu4p8QMm9J2TyI4+Dbf5iinWGlMXNmLuKjNduy Vx/1VFpqKpf64qrz8oeulybD97WD7j3ig0BItrKMBmuvjjEPHEHc6+oBivlthzq0A0an6x XxEf+S6OQIH4vPbCKTeGltKdlRPL/pM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UnwFL8wu; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of conor@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=conor@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668199620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3iZy4d77AdG/5G+eU46EsJG47BLZ/L5cyKNCDNciqJU=; b=zEl9BbJhRnGkzz8ITy0hTHaqLvuqemTOjt66zQ2N0W70d6NazWP9hwfYm76ESgfFzhsqX7 0Nk9bbeJKNbkztV4t9EPB6hGZOaK9z6dH2pts8PqspH1bSo2VBUnknUacGm9wPAkZgu9vg tHkK7UYIJNmew1hOJUaxf/VwTGoKpSM= X-Rspam-User: X-Stat-Signature: hgpnbbqygurtd6ibm4kkw4x3pmduba4h X-Rspamd-Queue-Id: 13D5E40009 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UnwFL8wu; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of conor@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=conor@kernel.org X-Rspamd-Server: rspam03 X-HE-Tag: 1668199619-372417 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 11, 2022 at 11:33:30AM +0100, Vlastimil Babka wrote: > On 11/8/22 22:44, Pasha Tatashin wrote: > > On Tue, Nov 8, 2022 at 10:55 AM Vlastimil Babka wrote: > >> > >> Hi, > >> > >> as we all know, we currently have three slab allocators. As we discussed > >> at LPC [1], it is my hope that one of these allocators has a future, and > >> two of them do not. > >> > >> The unsurprising reasons include code maintenance burden, other features > >> compatible with only a subset of allocators (or more effort spent on the > >> features), blocking API improvements (more on that below), and my > >> inability to pronounce SLAB and SLUB in a properly distinguishable way, > >> without resorting to spelling out the letters. > >> > >> I think (but may be proven wrong) that SLOB is the easier target of the > >> two to be removed, so I'd like to focus on it first. > >> > >> I believe SLOB can be removed because: > >> > >> - AFAIK nobody really uses it? It strives for minimal memory footprint > >> by putting all objects together, which has its CPU performance costs > >> (locking, lack of percpu caching, searching for free space...). I'm not > >> aware of any "tiny linux" deployment that opts for this. For example, > >> OpenWRT seems to use SLUB and the devices these days have e.g. 128MB > >> RAM, not up to 16 MB anymore. I've heard anecdotes that the performance > >> SLOB impact is too much for those who tried. Googling for > >> "CONFIG_SLOB=y" yielded nothing useful. > > > > I am all for removing SLOB. > > > > There are some devices with configs where SLOB is enabled by default. > > Perhaps, the owners/maintainers of those devices/configs should be > > included into this thread: > > > > tatashin@soleen:~/x/linux$ git grep SLOB=y > > arch/riscv/configs/nommu_k210_defconfig:CONFIG_SLOB=y > > arch/riscv/configs/nommu_k210_sdcard_defconfig:CONFIG_SLOB=y > > arch/riscv/configs/nommu_virt_defconfig:CONFIG_SLOB=y > > Turns out that since SLOB depends on EXPERT, many of those lack it so > running make defconfig ends up with SLUB anyway, unless I miss something. > Only a subset has both SLOB and EXPERT: > > > git grep CONFIG_EXPERT `git grep -l "CONFIG_SLOB=y"` > arch/riscv/configs/nommu_virt_defconfig:CONFIG_EXPERT=y I suppose there's not really a concern with the virt defconfig, but I did check the output of `make nommu_k210_defconfig" and despite not having expert it seems to end up CONFIG_SLOB=y in the generated .config. I do have a board with a k210 so I checked with s/SLOB/SLUB and it still boots etc, but I have no workloads or w/e to run on it.