From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC341FA373D for ; Tue, 1 Nov 2022 07:58:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CFA380007; Tue, 1 Nov 2022 03:58:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 458796B0075; Tue, 1 Nov 2022 03:58:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AAB680007; Tue, 1 Nov 2022 03:58:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1405A6B0074 for ; Tue, 1 Nov 2022 03:58:31 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C12DE40ECF for ; Tue, 1 Nov 2022 07:58:30 +0000 (UTC) X-FDA: 80084121180.20.138877B Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf07.hostedemail.com (Postfix) with ESMTP id A821F4001D for ; Tue, 1 Nov 2022 07:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667289509; x=1698825509; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=NtKXddx28fx4IVaaZf6yBqFuLV8AbouAYPWSgRm4m7k=; b=Jkvpd+nZo4OvTp2h/mIRp8qceuZedUuShWP8H1FWLtASswwvIqrPmmX2 JXRHLllhpi9tdgYyhB4I/H8jAEo7WU64Z/zfoyHvYkahqsg6i1DGhU0YP sKZa1iz08g1CZ/ivFGiFIiJxGF9kGgWRVCFceznN6dv33tnde8Mik7LdA MOeS4TVBaWeNU+twv23pM9Im4+pDHFKTBgP+tQynKjYghs4MqHCeclWGx Vhd1eKn6VztJYqgLp0mf02LTWNzb7F8cIvQZhX9BWwsvtOhhwgsZocspu Uflq/bVObfEdn8/W6uZJhCMOfmseJmA98IowCw459HsidlNZ//mlRTkuK Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10517"; a="289480258" X-IronPort-AV: E=Sophos;i="5.95,230,1661842800"; d="scan'208";a="289480258" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2022 00:58:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10517"; a="776419624" X-IronPort-AV: E=Sophos;i="5.95,230,1661842800"; d="scan'208";a="776419624" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 01 Nov 2022 00:58:12 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 00:58:11 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 1 Nov 2022 00:58:11 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 1 Nov 2022 00:58:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c27hQY59nRUas8d53oMvurXrROmZ0kKAAErrQ6/5W9BsHRjZPrHpALVv6Lguo/5fRG8lOIjooVBtGHzvt8nEIR+/oECFoRDMGWnSQYwyZvmBrPPg9ToOSSDPawPoYjrs6foyN6vk+UUyP/z0BxUBTELAsulDqOWXZBwZ+OSGt1qKOkYNPoMUxgIVDDa48SwUqY+3kmx5E2sZw/dnqB+1lir3doo0cRp6eQbm8J7f8eD6i1tesbCZMfbeVa6XHeHvXU7VcPPcbrBwkxGXl4cMf99pIdEWfYjWvIJvpxcMqz3hpTDQ7lwaSPTmzqDujYdxGFuHVmoZ3o5Zr3uUIVD/qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6zSLQeuGG66zx6XsnqAmAtqAZukaINP80wafUgiPX+Y=; b=GDlgg1gOqIxst0rrjnFOGKbb/4CdvgT/YMOYM/GLLuK8xswdAN+UWkWY7X3bx6RCySPKN1RZloo9qfRRuNMdXDWGM3LMgAttkhHU9CA4W0tyvacImm7rEzT9eu1TQPvmWUqzeiy60FCOXNMk47sFod6SDW2crTwRUac48cQTOcJxpcoZLB0eUsiAKUALcW091ljyYghzPODCBmZBSg1Hf/yXjnlaOOlZl52Nv4GrJDT2SEhvtH5Gl+Hz0ArEQ2yFcDg13PS3mDDo+bazrd9BgCaCtwQehNPYBOAbZitMYOosxg7RefAUTtDGSGxe1S737KeKe0qkpFU5PFqIXjDpiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6304.namprd11.prod.outlook.com (2603:10b6:208:3c0::7) by CY8PR11MB6913.namprd11.prod.outlook.com (2603:10b6:930:5b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Tue, 1 Nov 2022 07:58:03 +0000 Received: from MN0PR11MB6304.namprd11.prod.outlook.com ([fe80::c00f:264f:c005:3a5b]) by MN0PR11MB6304.namprd11.prod.outlook.com ([fe80::c00f:264f:c005:3a5b%3]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 07:58:02 +0000 Date: Tue, 1 Nov 2022 15:57:46 +0800 From: Feng Tang To: John Thomson CC: Vlastimil Babka , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Dmitry Vyukov , Jonathan Corbet , Andrey Konovalov , "Hansen, Dave" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "kasan-dev@googlegroups.com" , Robin Murphy , John Garry , Kefeng Wang , "Thomas Bogendoerfer" , Subject: Re: [PATCH v6 1/4] mm/slub: enable debugging memory wasting of kmalloc Message-ID: References: <20220913065423.520159-1-feng.tang@intel.com> <20220913065423.520159-2-feng.tang@intel.com> <9b71ae3e-7f53-4c9e-90c4-79d3d649f94c@app.fastmail.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <9b71ae3e-7f53-4c9e-90c4-79d3d649f94c@app.fastmail.com> X-ClientProxiedBy: SI2PR06CA0004.apcprd06.prod.outlook.com (2603:1096:4:186::20) To MN0PR11MB6304.namprd11.prod.outlook.com (2603:10b6:208:3c0::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN0PR11MB6304:EE_|CY8PR11MB6913:EE_ X-MS-Office365-Filtering-Correlation-Id: bebba90f-a2a1-42ec-d960-08dabbdecc9e X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /+7bP2I29vYXjIsWpAyQ7XLL+k6QqsJQ8nkNhs+2O4puBx3RzB05AqmQ3rIPuCc2w6mfmG9rQl5NnzykzfQXKov5pCqb9yi6tyWR8iLj/2MVn+C9ibwgho6G5aAkn7ZMMukhGWtPZuLDve3l4u7UjBgkxmf6qjMPP5Tn758qUU1yN0y67gd67g5nn3pcS1hEryfcq55vMLYsuSpRSbPUtXA7V+qGnmt0U1ItdzWnN8JXDmRPa8ZCPIynok8OpNhN6neo10DL7V39zvOjRlGOOssksJHoRwEjhqybSb/cwgPVvBUo1Qcn79FQ3LVjABkeNCJ0UYiwU8Kup0XTLYbyVcRJt5GtYZLzW6d/raUacMhoP3FDGo03pu30OuMJXanXsauPoFKBILkz2GtiPNbNxTq+N8DjGZs6OIDzTcmOmzl1hylYNIcYReFiYlIjf5GwEwhJzduf6bquTjE49KtKXmHvuiJca6uRABTyf+7xIPgPrMVeY2xbIobKxAW6LKRVLjqT2T7p4jb16VR+Vmam52pdAMmLE3+L/a8sOAc2ci5b4+AOh1MlkhofwTzpTx4RQGJYTNdpHhHylMqJjj/wKA8JGNKER9ZDleRieSAGFC7Phw7zj6H0yBYcaYqtcmPAARCMErrqmdzGzE6gGwoCNHcihlj6NBhQe0I1VMaT0XrUyXzCMDRHyx3D8AovRBJQ5JTy+Febyq2ZW58c4oZgEqczPjjA+GQYUH5mjWMJZuM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6304.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(366004)(376002)(136003)(39860400002)(346002)(396003)(451199015)(83380400001)(33716001)(86362001)(82960400001)(38100700002)(6916009)(54906003)(316002)(6666004)(44832011)(7416002)(5660300002)(186003)(6486002)(2906002)(966005)(6512007)(9686003)(41300700001)(26005)(6506007)(8676002)(4326008)(66476007)(66556008)(66946007)(478600001)(8936002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?l+qgPhplE+K9mYy+8IwfgB2GrWBaXneQSj5P1LzWUfSVFPJBzEtg+4/qTeRd?= =?us-ascii?Q?Vs9HPB/z/U9LklfGAcocFn5JU0gJ4nWsvbTuBC6JB0WBkP6lWI8QcIuV5sHg?= =?us-ascii?Q?i9oiSe16oboG/kHMQpfjB0E3iBbbntcCwZ/eKkeyeYnZ6Y9DD4BVCkhLtB+T?= =?us-ascii?Q?WJhi6RV5G97iyfWzf73hjh1itn4p7bFaunt6Z/9MHiEp6+xmm617OZJW3smK?= =?us-ascii?Q?dtvFKyOxRflEN+trUJGB7FYNqgz+zkj5v/KOjZOCtoUgqdcba8HwwP4bdRxD?= =?us-ascii?Q?CfUFOnHhRPEnRoBRhlOr10I2mq287bnKcZRIfYii1aSNxj0BJcOJAgZ6P4Mh?= =?us-ascii?Q?/ycS889EW0cKBcRHRaastvUGU0XH1vYeiHk/xP+hi3vQocfxdObrpLDhux0F?= =?us-ascii?Q?4zM/iu5L4T32s2PzohGYN8jSrMQEGn4oMuxpWHigbayhSQR+4d+/Shv+MmHa?= =?us-ascii?Q?qri42B6X2e7rIhaYWXljdMp2iPuKZCql/p/k7n9FCEK7uLpi4G64lVAOS5Yg?= =?us-ascii?Q?TAeM98pvXphNyLudBnUKWNWzVy5g/1JYLjFQjlykvXcp25LMgpsLsyYu7KyQ?= =?us-ascii?Q?OobJuBV5jCwBgFm2F7P6shTcxqaQKQ4eLwOHR6ckRuvlfD/PxOz3ZepnCmKl?= =?us-ascii?Q?vE5VcqPBE0tGBeUiJixQLSptRf0HZjnk55GMPJa4dU4nDitrgdA5vwWCcdSx?= =?us-ascii?Q?IRl7l0lErJUlUKMwL4cw2heOzBD/48NBHGJ/o6HfvugP4QTjMpvt90DbpwDT?= =?us-ascii?Q?gibPd1hmNc6dPUFBF5fTyLdjW6U+nxULJOhrb3Uh29YGVouiwwz7MOt7ba10?= =?us-ascii?Q?mNneKyQt1SGx+jh9m33x7hz3ICPogfyKlI5twUjmDzK51Nx4hzH3Gqo3MMFb?= =?us-ascii?Q?yIxXOZLZq1vZxvDQDNQpfhBmj+slOrRmCHyTE1A1lzde3ANfNFKSueVqHymb?= =?us-ascii?Q?qi/dvje94XxBq3UJe3+0QG8Qm/BEYauUmitoXJnAGjmY8HJPbtK3fmNxo1zV?= =?us-ascii?Q?88mine/jAcXpEeijcLFlCgPRdGpj1zwujTaaG1nbjY9Ru/c0K69RU8uSczKZ?= =?us-ascii?Q?kDbOsVouEDK6ub2rPBZ0SbsTTyqdaVg0j/IxqpP3JW4i1NCKmkWmvngEmTfP?= =?us-ascii?Q?MfR0i8Wl3lCYoFw2JyAQhUhL93fdLz7QFyfjlM3w5fcftGsh6srmF05XCWEJ?= =?us-ascii?Q?bqQWNPfpqZpS6FK/uBlxdUt3hpN2oiw0coiICFrb8PU4o39yHwNI7JRfmmQt?= =?us-ascii?Q?lRShYe+WUP0KoFt3FKqhKNcVv89stjjR+RPUrgKfUBv+au0WqBpyRwAe1fP4?= =?us-ascii?Q?wfk7zmwHkE7y/jWhK3qanAiTl45uiJQCgfZgbv1XDs2EkiRAAItmii9wwCaR?= =?us-ascii?Q?1dv4HMYeItOXDqCYzITFWbWqcXzPZ3m65OILn2fNdnaGQcHuvOSyM2ud9cU8?= =?us-ascii?Q?UVkxedamRxDqzBuSx2k8HQRy9HytjT7F1IurQS5RIkOuYCB1zAjsuGztQrbx?= =?us-ascii?Q?kaqsUIjdMO1Qmr1OqYuUIJuMHZCdTeY5hh2IVU0SaiXEu8iuUXMhqk++c6/e?= =?us-ascii?Q?GuOzJjSUdTp66FxWZB8XOFgr6/JOmZNAWF8ozzjB?= X-MS-Exchange-CrossTenant-Network-Message-Id: bebba90f-a2a1-42ec-d960-08dabbdecc9e X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 07:58:02.2549 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +Spq6KwKs+rl50bZs28kLdQhR+x45aY7uSNJdp8r6YEGxTFv/LDaHiyif1QNCXwYEdxcfKvFZUOwOrbQsSW/cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6913 X-OriginatorOrg: intel.com ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Jkvpd+nZ; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf07.hostedemail.com: domain of feng.tang@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=feng.tang@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1667289510; a=rsa-sha256; cv=fail; b=SwK/C34EDaeqSr0b6YkKeRZJWnjCkrlcbsDjHiOJJ+Us1qZnFHRxewGct89eV3xrfNC/Sz rF3i/S707zBFrqcOhtRxGp5ydShg6/LzUEXYJOrLdkSZ5nh42MGCcIHP9mhruB5/b1gGlZ miVO5lQKBLgnkJYZsCfZs+elCT7c+xQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667289510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6zSLQeuGG66zx6XsnqAmAtqAZukaINP80wafUgiPX+Y=; b=TEKQDphffcxt1Qr9agH7IGC3xgvSDFrHHedqMISNNUCo7lLzK1bBqwwz8XNC8RCJyYH5u9 ItdbYcwP+cfis4hocygROyKFZEixbvEOWiUlAhdPIiBnA3nRq8OQ4mRIVyCpdin+Y8bMY7 UdOjWfO2eLoU44bTqWbDvkolaUp1yo8= Authentication-Results: imf07.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Jkvpd+nZ; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf07.hostedemail.com: domain of feng.tang@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=feng.tang@intel.com X-Rspam-User: X-Stat-Signature: cd91ynx8hsrtsxpxa6w37dyixmwrfs6d X-Rspamd-Queue-Id: A821F4001D X-Rspamd-Server: rspam11 X-HE-Tag: 1667289509-258349 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Thomson, Thanks for testing! + mips maintainer and mail list. The original report is here https://lore.kernel.org/lkml/becf2ac3-2a90-4f3a-96d9-a70f67c66e4a@app.fastmail.com/ On Tue, Nov 01, 2022 at 12:18:19AM +0000, John Thomson wrote: > > As I can't reproduce it locally yet, could you help try 3 tests separately: > > * change the O2/O3 compile option to O1 > > * try the attached 0001 patch (which cut part of commit) > > * try attached 0001+0002 patch > > None of these changed my outcome. 0001 patch chops off most of the functional changes, and it still fails. I'm wondering if it is related to the function arguments' passing, I noticed this is a 32 bits MIPS platform (from your config) > I also tried compiling the same linux tree & config with the Bootlin toolchain > (mipsel-buildroot-linux-gnu-gcc.br_real (Buildroot 2021.11-4428-g6b6741b) 12.2.0) > with the same results. > I will look into finding or building a mips clang toolchain. Yes, Hyeonggon's suggestion makes sense, different compiler may show some difference. > No JTAG capability to debug, sorry. > > I get the same outcome with either the ZBOOT vmlinuz, or vmlinux > > Same happening with 6.1-rc3 > > > After some blind poking around changing (how much of the commit affected) mm/slub.c, > I may have got lucky. it appears as though this is all I need to boot: > (against 6.1-rc3), and with the Bootlin toolchain. Will test my other build system as well. > > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -3276,7 +3276,7 @@ static void *__slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, > c = slub_get_cpu_ptr(s->cpu_slab); > #endif > > - p = ___slab_alloc(s, gfpflags, node, addr, c, orig_size); > + p = ___slab_alloc(s, gfpflags, node, addr, c, 0); ___slab_alloc()'s argument number has been changed from 5 to 6, and some others from 4 to 5. Thanks, Feng > #ifdef CONFIG_PREEMPT_COUNT > slub_put_cpu_ptr(s->cpu_slab); > #endif