From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAD3DC4332F for ; Wed, 2 Nov 2022 03:42:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A7316B0071; Tue, 1 Nov 2022 23:42:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1574D6B0072; Tue, 1 Nov 2022 23:42:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01F436B0073; Tue, 1 Nov 2022 23:42:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E64B06B0071 for ; Tue, 1 Nov 2022 23:42:13 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AD108120FE5 for ; Wed, 2 Nov 2022 03:42:13 +0000 (UTC) X-FDA: 80087104146.29.F6B77FA Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf27.hostedemail.com (Postfix) with ESMTP id 5D97D40003 for ; Wed, 2 Nov 2022 03:42:13 +0000 (UTC) Received: by mail-pg1-f174.google.com with SMTP id r18so15122390pgr.12 for ; Tue, 01 Nov 2022 20:42:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Oo23rdptXeonGeV+R+rAP3rUmFYr9yR6UUbFic0TMHM=; b=Ej7aSHjtyIcfBIc+mXwGkpDPO/8iWJd7WvOMKVWE7hrCgZlw4b1fV14PjOH/sqi9Ky wnr7vwVt2ZDmK1TGnqgdOOQ4GN1Fmd/cv1wdliqW+KcABkCoMKjLQ3g7x01FizZH6HD3 5x/CFyTc7nUU+7RAJG0dswlsWc9Z+xc3laUiU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Oo23rdptXeonGeV+R+rAP3rUmFYr9yR6UUbFic0TMHM=; b=B6AT54A/anqB7036Fkk4+O7/pOPnGZgBtzOyowwWIaNeduxUkjpL3IvphrzwAzFF19 hkLcAYM3NFvFyd3tkyNCaVk6aTy1icB1uRETS2UmoElmhxJ3e80gVRlTlxucfAjSlpP6 zYST5Y8yb3+sQQcfMeKSPCEcdXfi1UayeIZ2fJOmNIiaf9/X+/X1trOM6OEGoXJOQ/JM RlcYP4Up0LEsiuvH9pKx4eGC1JMhfN680ih4lA1rYljb+HeKcG+qC3uBUABrA/yO+IJn 2OF0em4uEplmG4PJvIGxlReL/wmcIvMo/S1XNb4RhDpi/R1EZFo2RfFkAddzz0U/cLkC jc0g== X-Gm-Message-State: ACrzQf0kOUAdSx8PIxqtLblH1zGT4d1oKpo1fYj5kzUjS/01SHb9fxxi 5oJZdb14WN5zX2xaA89UI86hew== X-Google-Smtp-Source: AMsMyM5bZXD48076Ge2HXaXwzUt1HHHf5Ug7/VXNl31WPVwEIU4kov8PXoyBU4VaX/MbTOVpkAxAcQ== X-Received: by 2002:a63:501f:0:b0:46f:a711:c455 with SMTP id e31-20020a63501f000000b0046fa711c455mr15000744pgb.402.1667360532351; Tue, 01 Nov 2022 20:42:12 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:f558:dfb0:7cb7:44d9]) by smtp.gmail.com with ESMTPSA id r1-20020a17090a1bc100b0020dda7efe61sm318368pjr.5.2022.11.01.20.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 20:42:11 -0700 (PDT) Date: Wed, 2 Nov 2022 12:42:06 +0900 From: Sergey Senozhatsky To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v2 5/5] zsmalloc: Implement writeback mechanism for zsmalloc Message-ID: References: <202210272158.7swYwd23-lkp@intel.com> <20221027182736.513530-1-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221027182736.513530-1-nphamcs@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667360533; a=rsa-sha256; cv=none; b=AWLJP//o6DWXxHUwVtsgatz82TlpBuRd3XM7GL8PcBQEYNWYTISd1a0IUElvVFrDAB9Yoy BvKsXg7is35/wS+sSq0gXO2oESDSqOqzvZ7q5V9zjnM8JNlHrX6664uOL6WKNjr+IvFuZ/ Z8mv+7D+P0ZT3D6mXfkbSjgROfJwnoA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Ej7aSHjt; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.174 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667360533; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Oo23rdptXeonGeV+R+rAP3rUmFYr9yR6UUbFic0TMHM=; b=IG7Dnri0Qo+2fzVu9regDcKrL393ygicnEkeAi+qMzGTGnfZidhdbq2lizRF0lwYk3VZ6z HlTyngIhicCaZWA/XIpgQ/JcX9NhbV2nK++R06Yyj4uES7AS3x4kTOcwI4bgyW13QkVKg2 ktMYT42SucFdM+SvldcrEuQrhNX6kBY= X-Stat-Signature: bncpaeqxz1155oz7n4y1sjiy5ispq5br X-Rspamd-Server: rspam09 X-Rspam-User: X-Rspamd-Queue-Id: 5D97D40003 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Ej7aSHjt; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.174 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-HE-Tag: 1667360533-550404 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/10/27 11:27), Nhat Pham wrote: [..] > +static int zs_reclaim_page(struct zs_pool *pool, unsigned int retries) > +{ > + int i, obj_idx, ret = 0; > + unsigned long handle; > + struct zspage *zspage; > + struct page *page; > + enum fullness_group fullness; > + > + /* Lock LRU and fullness list */ > + spin_lock(&pool->lock); > + if (!pool->ops || !pool->ops->evict || list_empty(&pool->lru) || > + retries == 0) { > + spin_unlock(&pool->lock); > + return -EINVAL; > + } > + > + for (i = 0; i < retries; i++) { > + struct size_class *class; > + > + zspage = list_last_entry(&pool->lru, struct zspage, lru); > + list_del(&zspage->lru); > + > + /* zs_free may free objects, but not the zspage and handles */ > + zspage->under_reclaim = true; > + > + /* Lock backing pages into place */ > + lock_zspage(zspage); Does this call into the scheduler under pool->lock spinlock?