From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BF53C4332F for ; Thu, 3 Nov 2022 23:33:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB21B6B0072; Thu, 3 Nov 2022 19:33:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3B626B0073; Thu, 3 Nov 2022 19:33:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDC8B6B0074; Thu, 3 Nov 2022 19:33:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BEDFD6B0072 for ; Thu, 3 Nov 2022 19:33:31 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 89C0C161430 for ; Thu, 3 Nov 2022 23:33:31 +0000 (UTC) X-FDA: 80093735022.14.63F9AEF Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id 303121C0002 for ; Thu, 3 Nov 2022 23:33:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=B+WVJtSG9qilNfBnLbjB8IaNTAyS5PzrTs5MgsZSZYs=; b=P8H1AhXnqQyG/LassE8lRajXwF 39yup/eNw16yNohyv8dcUTUv9FSTUtyvVpNQMBSiHxkY6hmzViWt0q4ujCPRqnIdlma3HTTdEu56o CVErC0yb+O4GENELS9Hr4Fdf6iV0NGSTHamHmBAxaaNYBLUfcqFNS49BiEZcaj2O25/0nWmJGfpby rYllsSN9Gm+OcF1anor+fVZLKQwVrvO7cmbKMYsp4QqekQTPv6qkL6L93B7v6g4uogW79+vw54YR2 Og9CAdgU1ki7F7CaSyavdGzEamgXWpLevaWw4LAiO5S5sGVhYvPexYHJ5/Q9xQgwzwL4yFPBEJG9K kRdCzabw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqji5-001ygZ-Lx; Thu, 03 Nov 2022 23:33:21 +0000 Date: Thu, 3 Nov 2022 16:33:21 -0700 From: Luis Chamberlain To: Song Liu Cc: "Edgecombe, Rick P" , "rppt@kernel.org" , "p.raghav@samsung.com" , "peterz@infradead.org" , "bpf@vger.kernel.org" , "dave@stgolabs.net" , "willy@infradead.org" , "linux-mm@kvack.org" , "hch@lst.de" , "vbabka@suse.cz" , "zhengjun.xing@linux.intel.com" , "x86@kernel.org" , "akpm@linux-foundation.org" , "Torvalds, Linus" , "Hansen, Dave" , "kbusch@kernel.org" , "mgorman@suse.de" , "a.manzanares@samsung.com" Subject: Re: [PATCH bpf-next v1 RESEND 1/5] vmalloc: introduce vmalloc_exec, vfree_exec, and vcopy_exec Message-ID: References: <20221031222541.1773452-1-song@kernel.org> <20221031222541.1773452-2-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=P8H1AhXn; spf=none (imf21.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667518410; a=rsa-sha256; cv=none; b=5H7SAIzMlENgEf5sSUHH2cywoOPsvg31q21nOypHgj2haV7nrDOTuzgPaFwqOvtpr4OZ6x QuLu3ev5NcqCmxKbxrcI5WJ+sZ71dNSCbc42xc4Zl5qQSY6W/YHOZobuCAfIKSvnHvwW8i UF8H1Ch04h9CgO6867xb/UqbYrCZHDw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667518410; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B+WVJtSG9qilNfBnLbjB8IaNTAyS5PzrTs5MgsZSZYs=; b=OQbUCmpY4LtMwCBsCHoCQ8voGZAW/1hrLTM8H8IpL2zifXh6e+eUQECDXqxJm7XboVZxAi AOPLBmZyj++6qenlYPE7VCTrLZQdD7LWJ6X2asOgKfn32GTMeFjiMRNBhAYPU1Zzr7FL6Y 5docFhMK1MfDQ1Hp8fbHbdeD+KDlBcM= X-Stat-Signature: w8frt3roje3ubhkygtt536nrsdhqydc5 X-Rspamd-Queue-Id: 303121C0002 X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=P8H1AhXn; spf=none (imf21.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam01 X-HE-Tag: 1667518409-286056 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 03, 2022 at 02:41:42PM -0700, Song Liu wrote: > On Thu, Nov 3, 2022 at 2:19 PM Edgecombe, Rick P > wrote: > Besides the motivation improvement, could you please also share your > comments on: > 1. The logic/design of the vmalloc_exec() et. al. APIs; I've provided the feedback that I can so far as I'm new to mm. Best I can do is provided a better rationale so that mm folks can understand the motivation. > 2. The naming of these functions. Does execmem_[alloc|free|fill|cpy] > (as suggested by Chritoph) sound good? That seems sensible. There may be other users later, secmm_alloc() too then later, for instance. So we just gotta keep that in mind. Luis