From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FC08C433FE for ; Sat, 5 Nov 2022 01:30:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25A556B0074; Fri, 4 Nov 2022 21:30:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E32A6B0075; Fri, 4 Nov 2022 21:30:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AC138E0001; Fri, 4 Nov 2022 21:30:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EF8726B0074 for ; Fri, 4 Nov 2022 21:30:41 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C4B941A0ADF for ; Sat, 5 Nov 2022 01:30:41 +0000 (UTC) X-FDA: 80097659082.01.3697C45 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf16.hostedemail.com (Postfix) with ESMTP id 4DF99180005 for ; Sat, 5 Nov 2022 01:30:41 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id q1so5768629pgl.11 for ; Fri, 04 Nov 2022 18:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vM2nfNNh1xjXMSY6VcmCg8+PkxfmboalhkRzZP/gAMw=; b=HOIcRdEp87iUaKFHK6AdakNNkbdYi10THlenTzCsrb2ZeZ/JpmN+5JujSX9R5COYSN lARB6CAVAXsjZetcYFRJtaPwUP8Y2k4RzrRcq0jIHuIvhyTIn1KOkv0x7i4AKp43Y2Y+ h3c8FUPAZUtFY/9SFM+xdoZn1HI39lFqAK35s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vM2nfNNh1xjXMSY6VcmCg8+PkxfmboalhkRzZP/gAMw=; b=isRS6Z8r/5dOx8YgG9nbVrx8t0peqHoJFFzJpRsKA9ZWkz4SMDN+Wmb65w+Zldsft0 UZkMRHXIMZ7C7SuzlF2tzfhlMZenaWp+/G4q8RdQE+piVGeHq3Cn6a3ytsjk1KcLpJRH n1aU5RQGf/zfVipIx9e1GFR1ipXFafjHgUCczNj3xQDBZUi4iU6SGH//kwiecq0SN8xw iT0Hfhyg4m4tTjNNoMNEp/ksVbG8lLlG4F12abB1mKgYWr1XNKjgM/mjv9N5k7vIgQSu PQOdaC5Fl/1iJRnIgAQH1Y3tvsa6H3r8rfRI97HdSYaDCOvJuBG22vjnmOaBGqxNsaqi cpqQ== X-Gm-Message-State: ACrzQf2+6dl1C/rZq83rJeN6OUO2HnoQL3uteijVWDSNFJWZEiM03gTW +50WFI9PkzMMMJsUgE2Ceo52lA== X-Google-Smtp-Source: AMsMyM4EGGoAXgRDCR65iommYmSot0sSq1xmi8vUiKeXLKdvcKm7O8IoQZeYe+gZYKhNZFqW0LSEZQ== X-Received: by 2002:a63:8bc3:0:b0:46f:fa99:7d76 with SMTP id j186-20020a638bc3000000b0046ffa997d76mr17284463pge.134.1667611840181; Fri, 04 Nov 2022 18:30:40 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:cce:9a1e:69f0:8d2]) by smtp.gmail.com with ESMTPSA id c27-20020aa7953b000000b0053e38ac0ff4sm234641pfp.115.2022.11.04.18.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 18:30:39 -0700 (PDT) Date: Sat, 5 Nov 2022 10:30:35 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 2/9] zram: Add recompression algorithm sysfs knob Message-ID: References: <20221018045533.2396670-1-senozhatsky@chromium.org> <20221018045533.2396670-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HOIcRdEp; spf=pass (imf16.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.169 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667611841; a=rsa-sha256; cv=none; b=uSDctKAFz7UhwXOoh75Y+90sz8qucvDmu9lvPTyU2qtgmOPHVsPwA9RgRfI46/6OewcohU fsmcdmW251fd7VGTocOp/sF8OtJ7rgzCSCHO/8lAekY7Zj+8kRUPnmE9P8rVhhbN1rx7ZW pHwGlFh0KGOB4X26Miqjuz9Zu1YcCCY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667611841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vM2nfNNh1xjXMSY6VcmCg8+PkxfmboalhkRzZP/gAMw=; b=Pq15CAofghoE2dAYhz2CkPvkAyMW/PK3Go14U+WOjP76Hjt/szhyu/mJUUjxFsmUwuNGrh GD7CqlHw//llbe1MzBVJXhabhRwLw35NZT2aQWZyBtyqfJwyHauiJfdZBPwfcKVTBu69Wo TRxR1VNUIXZt6xqARfzlN3iHY7BKagM= X-Stat-Signature: 9xqqyoqrqmkbxosxgwjzj85kcq196fpd X-Rspamd-Queue-Id: 4DF99180005 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HOIcRdEp; spf=pass (imf16.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.169 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam05 X-Rspam-User: X-HE-Tag: 1667611841-53328 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000480, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/04 17:01), Minchan Kim wrote: > > One can be SW one can be HW. So I thought about having flexibility here. > > Instead of doing > > > > for (idx = 1; idx < MAX_IDX; idx++) { > > len = zcomp_compress(zram->comps[idx]); > > if (len <= threshold) > > break; > > } > > > > We would just directly use the suggested algo. > > > > But we probably don't need that param at all and can use > > the loop instead? > > I don't understand what param you are saying. I expected > the zram->comps array already has sorted algoritm based on the > priority so the loop will try compression as expected so loop is fine. > Are we on same page? I'll try to implement both loop and a specific algorithm selection.