From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8D82C433FE for ; Mon, 7 Nov 2022 07:30:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAE578E0002; Mon, 7 Nov 2022 02:30:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E5E7B8E0001; Mon, 7 Nov 2022 02:30:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4D9A8E0002; Mon, 7 Nov 2022 02:30:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C58788E0001 for ; Mon, 7 Nov 2022 02:30:08 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 819FB140E35 for ; Mon, 7 Nov 2022 07:30:08 +0000 (UTC) X-FDA: 80105822496.04.9B8D87E Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf18.hostedemail.com (Postfix) with ESMTP id E72C11C0006 for ; Mon, 7 Nov 2022 07:30:07 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2B5ABB80E0E; Mon, 7 Nov 2022 07:30:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43032C433C1; Mon, 7 Nov 2022 07:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667806204; bh=dARsHMvO/jjfwb1xJiZ9If4+NzELmasjWyqxIZwCW2k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fcLtBatZU2QkJMt06HGMQYnquCFS/c3U9hUYPQ4xrLSt1g4fkh6pMZkJOQrwo7AYb pm3GeWt0Y6hWORLycAyDboYwMyz2Cd4a64IryL0eDPaYNAh+qKvXhT2pG6kXBtYffZ tUOseyHaD8zEwJiivZ8ermjBMn5BBk/NKmYBsEKdFz/kqHWZmhwgpPKYlKx+B6oHdH tgrWTdBWydzEQ30guBTrUcBjM4lr1Scs2RmceWsLKVTkzNQdrInjGq4izrgbs4w8w9 BAXEWz4dm0Zf9MKqRnIcGazHPZvbIhJ6fJKjRaZ7kEdGsH7v8xTa5tKrSihE/J3nut HN3TNk9i+3q9g== Date: Mon, 7 Nov 2022 09:29:51 +0200 From: Mike Rapoport To: Rebecca Mckeever Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand Subject: Re: [PATCH v4 0/5] memblock tests: add tests for memblock_alloc_exact_nid_raw Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fcLtBatZ; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667806208; a=rsa-sha256; cv=none; b=4sBpuBRms3Waseoqyx2E4QqgdlvK0fv/GWjOiAL/ZiJoxaXbYS8/yA2lYjjgdAl6Nu+MlG dhvx7glGfUbURcdf+sJhoTPruwSY/s9NAgOMtNChew8zemriUGEDDUTepGYIgJjDufxYb2 rXVx4xucmp2VoOnfXapOf3hO+dNDX7w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667806208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eRVKHllB3sAmIxOtXAVYXeej99o+X2fDvL4YGDgc4OY=; b=h8y4gLwObP6O9VG55uQA0O0ny5HhRc7YMwOtvqp6wg+UGOb3wZJ2dkc+qOaweg0m2gVJ2b eR50/wyt6SAtkPLr3S50eYtosBlnP2OijAQaOE4OkPdbZQFVGoIswPdiA9F+rtEUt9hPzN q05q2DTYcpmiTVHToncAVYNEnuPaXVM= X-Stat-Signature: e1hkgx878o4jpct3qgzwhxb4898h6qxt X-Rspamd-Queue-Id: E72C11C0006 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fcLtBatZ; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1667806207-931961 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 07, 2022 at 12:28:04AM -0600, Rebecca Mckeever wrote: > These patches add tests for memblock_alloc_exact_nid_raw(). There are two > sets of tests: range tests and NUMA tests. The range tests use a normal > (i.e., UMA) simulated physical memory and set the nid to NUMA_NO_NODE. The > NUMA tests use a simulated physical memory that is set up with multiple > NUMA nodes. Additionally, most of the NUMA tests set nid != NUMA_NO_NODE. > > For the range tests, the TEST_F_EXACT flag is used to run the same set of > range tests used for memblock_alloc_try_nid_raw(). The NUMA tests have the > same setup as the corresponding test for memblock_alloc_try_nid_raw(), but > several of the memblock_alloc_exact_nid_raw() tests fail to allocate > memory in setups where the memblock_alloc_try_nid_raw() test would > allocate memory. Also, some memblock_alloc_exact_nid_raw() tests drop the > lower limit of the requested range in order to allocate within the > requested node, but the same setup in a memblock_alloc_try_nid_raw() test > allocates within the requested range. Applied, thanks! -- Sincerely yours, Mike.