* [PATCH v4 5/5] memblock tests: remove completed TODO item [not found] <cover.1667802195.git.remckee0@gmail.com> @ 2022-11-07 6:28 ` Rebecca Mckeever 2022-11-07 7:29 ` [PATCH v4 0/5] memblock tests: add tests for memblock_alloc_exact_nid_raw Mike Rapoport 1 sibling, 0 replies; 2+ messages in thread From: Rebecca Mckeever @ 2022-11-07 6:28 UTC (permalink / raw) To: Mike Rapoport, linux-mm, linux-kernel; +Cc: David Hildenbrand, Rebecca Mckeever Remove completed item from TODO list. Reviewed-by: David Hildenbrand <david@redhat.com> Signed-off-by: Rebecca Mckeever <remckee0@gmail.com> --- tools/testing/memblock/TODO | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tools/testing/memblock/TODO b/tools/testing/memblock/TODO index 503cc96fcdc3..e306c90c535f 100644 --- a/tools/testing/memblock/TODO +++ b/tools/testing/memblock/TODO @@ -1,10 +1,5 @@ TODO ===== -1. Add test cases using this functions (implement them for both directions): - + memblock_alloc_raw() - + memblock_alloc_exact_nid_raw() - + memblock_alloc_try_nid_raw() - -2. Add tests for memblock_alloc_node() to check if the correct NUMA node is set +1. Add tests for memblock_alloc_node() to check if the correct NUMA node is set for the new region -- 2.34.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4 0/5] memblock tests: add tests for memblock_alloc_exact_nid_raw [not found] <cover.1667802195.git.remckee0@gmail.com> 2022-11-07 6:28 ` [PATCH v4 5/5] memblock tests: remove completed TODO item Rebecca Mckeever @ 2022-11-07 7:29 ` Mike Rapoport 1 sibling, 0 replies; 2+ messages in thread From: Mike Rapoport @ 2022-11-07 7:29 UTC (permalink / raw) To: Rebecca Mckeever; +Cc: linux-mm, linux-kernel, David Hildenbrand On Mon, Nov 07, 2022 at 12:28:04AM -0600, Rebecca Mckeever wrote: > These patches add tests for memblock_alloc_exact_nid_raw(). There are two > sets of tests: range tests and NUMA tests. The range tests use a normal > (i.e., UMA) simulated physical memory and set the nid to NUMA_NO_NODE. The > NUMA tests use a simulated physical memory that is set up with multiple > NUMA nodes. Additionally, most of the NUMA tests set nid != NUMA_NO_NODE. > > For the range tests, the TEST_F_EXACT flag is used to run the same set of > range tests used for memblock_alloc_try_nid_raw(). The NUMA tests have the > same setup as the corresponding test for memblock_alloc_try_nid_raw(), but > several of the memblock_alloc_exact_nid_raw() tests fail to allocate > memory in setups where the memblock_alloc_try_nid_raw() test would > allocate memory. Also, some memblock_alloc_exact_nid_raw() tests drop the > lower limit of the requested range in order to allocate within the > requested node, but the same setup in a memblock_alloc_try_nid_raw() test > allocates within the requested range. Applied, thanks! -- Sincerely yours, Mike. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-07 7:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1667802195.git.remckee0@gmail.com>
2022-11-07 6:28 ` [PATCH v4 5/5] memblock tests: remove completed TODO item Rebecca Mckeever
2022-11-07 7:29 ` [PATCH v4 0/5] memblock tests: add tests for memblock_alloc_exact_nid_raw Mike Rapoport
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).