From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEFEFC433FE for ; Wed, 9 Nov 2022 08:14:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA1816B0072; Wed, 9 Nov 2022 03:14:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E52026B0073; Wed, 9 Nov 2022 03:14:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF2268E0001; Wed, 9 Nov 2022 03:14:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BFEAF6B0072 for ; Wed, 9 Nov 2022 03:14:14 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 861198112E for ; Wed, 9 Nov 2022 08:14:14 +0000 (UTC) X-FDA: 80113191228.28.01775F7 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf07.hostedemail.com (Postfix) with ESMTP id 1954640007 for ; Wed, 9 Nov 2022 08:14:12 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id A64331F8C4; Wed, 9 Nov 2022 08:13:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667981595; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iZ41zAxuFab1VbpZbOqMuhHV5p0NUYaSK2sGuoKt9j4=; b=A39M7ugjky4HJHQHpgupgCpSL4sIzdbSNnEklOL1SK2k8fgTBZ0UquiKGpX2rsgBpG5RKd fiWl+ZiIHC1FiY5c5gjE2ZFIKCevpdQ/RaPk3QCEmR1nQV6KTg/HAY0deZ95bnD5JxnHpP 9qW8VmwXRjZZy3Ymanng8AOAF0PFh8o= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id B9CAB2C141; Wed, 9 Nov 2022 08:13:13 +0000 (UTC) Date: Wed, 9 Nov 2022 09:13:11 +0100 From: Petr Mladek To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Joe Perches , linux-mm@kvack.org, Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Vlastimil Babka , Naoya Horiguchi , Miaohe Lin , Matthew Wilcox , Minchan Kim , Mel Gorman , Andrea Arcangeli , Dan Williams , Hugh Dickins , Muchun Song , David Hildenbrand , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v2 3/3] mm, printk: introduce new format %pGt for page_type Message-ID: References: <20221106140355.294845-1-42.hyeyoo@gmail.com> <20221106140355.294845-4-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667981653; a=rsa-sha256; cv=none; b=bOrzucMLcTAv8VJbTK3TH/dNv2KCxnlVgb9eds4s6mNMkc8jYxMEWvfWba/HGQfmgemlmH jJz67DNrVTAnlfReb9B/dVusoYlLZtYYacwYRvybiQ7Dje/wE6V6J1TftxepEWE5BSCjX2 MdcE5E0R4B/53BZLaKz8z0JxUpDd+ac= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=A39M7ugj; spf=pass (imf07.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667981653; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iZ41zAxuFab1VbpZbOqMuhHV5p0NUYaSK2sGuoKt9j4=; b=qd0s0O9Z1h4J+uQ+2qDDlXCUJkLcnh5Qz+KcSOLO9nQWVmK6LW4D7eI0WEerJ5RM0yMiLH DRyYvnTRAIAO3XaHjzhGWfyx8uGzB75JVkXuzgz8h4kmW8/tQ5qTl4hPXixvNhxe2T5GnI T0q549L399qTKr5pYxzgjjbyTc+E+M0= Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=A39M7ugj; spf=pass (imf07.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1954640007 X-Stat-Signature: oi41t958bgb3x7bacuybgbjrnaf6rjsb X-HE-Tag: 1667981652-962426 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 2022-11-09 15:14:05, Hyeonggon Yoo wrote: > On Sun, Nov 06, 2022 at 10:04:25AM -0800, Joe Perches wrote: > > On Sun, 2022-11-06 at 23:03 +0900, Hyeonggon Yoo wrote: > > > dump_page() uses %pGp format to print 'flags' field of struct page. > > > As some page flags (e.g. PG_buddy, see page-flags.h for more details) > > > are set in page_type field, introduce %pGt format which provides > > > human readable output of page_type. And use it in dump_page(). > > [] > > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > > [] > > > @@ -2056,6 +2056,28 @@ char *format_page_flags(char *buf, char *end, unsigned long flags) > > > return buf; > > > } > > > > > > +static > > Thanks for looking at this. > > > > > noinline_for_stack ? Honestly, I do not like much adding this without numbers. It has been added to some functions in vsprintf.c long time ago because it reduced the stack usage. But I think that it is a compiler and an architecture specific. And it is not clear if it would really help in this particular case. Feel free to omit it. Best Regards, Petr