From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70152C433FE for ; Thu, 24 Nov 2022 01:24:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 107E26B0072; Wed, 23 Nov 2022 20:24:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B8AB6B0074; Wed, 23 Nov 2022 20:24:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4D9A6B0075; Wed, 23 Nov 2022 20:24:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D6F466B0072 for ; Wed, 23 Nov 2022 20:24:28 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B2D10AB7D9 for ; Thu, 24 Nov 2022 01:24:28 +0000 (UTC) X-FDA: 80166590616.25.9CE3EF9 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf28.hostedemail.com (Postfix) with ESMTP id CCFDBC0009 for ; Thu, 24 Nov 2022 01:24:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669253067; x=1700789067; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=PZZJi1FYJX7AK/LIo7bfp02eQMOei65txkDLB/pDWTI=; b=Q/ok708KYIVzkCq43SMMU03tqucippLxRgygN3fv5k0YpaZQqW0TYkUy MU3nzTLrVe51/Y+1R+eHOLYj26XB9FFT0GK7pWmdKimyCwC1lB+csgyoR q38wMmBDIgzYzKxKIvUfx+4z12RW4AuSBLdbIiQWO/cP7EN7UEZeJx3Zi 6UJMjah7Xbu2qE35t0fiGyO5V4SyRAz2L/R5PvqhIhuG6vGw8xhZ2Aswj Ecd3gSAC7OPCaWBPeHWVGF7IclXi2CpN8UnJnT14s06jBhkBVS3ec46Hr rtnCFsbBcoIGO7Z+7NRulSCBhCRD/ge7EyVCSSO3Uul8qaaLEv1oth3le Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10540"; a="376336371" X-IronPort-AV: E=Sophos;i="5.96,189,1665471600"; d="scan'208";a="376336371" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2022 17:24:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10540"; a="636105186" X-IronPort-AV: E=Sophos;i="5.96,189,1665471600"; d="scan'208";a="636105186" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 23 Nov 2022 17:24:20 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 23 Nov 2022 17:24:19 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 23 Nov 2022 17:24:19 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 23 Nov 2022 17:24:19 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 23 Nov 2022 17:24:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I5hjCkzJLHswN6ZaORcJ5rAFO9c5+OqEtH4hv/XlLvRoD1Ok3jlnZFNXOy5/AaXqH20MYUE0vG3+H6jMIeTunaUyi5QZpMzMO5Bb0Z9QdsrjtG/5zu1nrtQzworF2dj2ci1DqoLNc1ol1hBudDhmU6G785RP2bCKMpwsvvVO8KQJ5xEgB0bXu/wdBRO4yCOl6X0tWzJ10s0SsTzz3GPt0bPVC6Oo73mwfcKJ7APEztqyJkruZVqEg9uWdF19FAFehwdEFGNZh3lGy2CNF88K49BPS0JilYM+cD8tHo/97brI7qfBND9zwe8rtX7rXKiwbDc6lqjgUW5hy5YNK7GefQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QM8AXRK1dGCK60KZ4QHkEeYRuYT8NufyT5gZCkuseKc=; b=VVmjDj3nc6cpuANm0kGRJDXiufPY4VcjAy1+Qk4Nw++Rc1yqtj3wM0VfOh1iNB2f640XsYLu9iRgqW6QTwfVllJbvHhGZtfXliX8ykNgh6qDnT4vcoXolZvitXdF0KzQdWCwhuk6RO1UCaBN8yVUyz9SuQF19JU2S77eXy1FHqWlKkb5+qplBojZWOrQobK1mOrplP/K5KiZX02j2WizC0wUHbO+hC8ro2qaQP+KWIgv0HM9uvgLUErSE3j9ZeJEDxhX2Hm1X8arGcJU1074e8pekRcBG6tWNpz+1eLWiwTTreK+3T9I/W3oZjartAYYFs8M77jOEgaEpCNcGJ9SNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6304.namprd11.prod.outlook.com (2603:10b6:208:3c0::7) by BN9PR11MB5306.namprd11.prod.outlook.com (2603:10b6:408:137::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Thu, 24 Nov 2022 01:24:18 +0000 Received: from MN0PR11MB6304.namprd11.prod.outlook.com ([fe80::1564:b428:df98:96eb]) by MN0PR11MB6304.namprd11.prod.outlook.com ([fe80::1564:b428:df98:96eb%5]) with mapi id 15.20.5834.015; Thu, 24 Nov 2022 01:24:18 +0000 Date: Thu, 24 Nov 2022 09:21:09 +0800 From: Feng Tang To: Vlastimil Babka CC: Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Andrey Konovalov" , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Vincenzo Frascino , , , Subject: Re: [PATCH v2 -next 1/2] mm/slb: add is_kmalloc_cache() helper function Message-ID: References: <20221123123159.2325763-1-feng.tang@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SI1PR02CA0034.apcprd02.prod.outlook.com (2603:1096:4:1f6::10) To MN0PR11MB6304.namprd11.prod.outlook.com (2603:10b6:208:3c0::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN0PR11MB6304:EE_|BN9PR11MB5306:EE_ X-MS-Office365-Filtering-Correlation-Id: 49b3761c-0b7d-4f03-0214-08dacdba9b4e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tYEwjX6i3CutSeI0n9HWhBwNe4P5NdAvbodNgZ4+VN8Zx1jXaach63bbgS/XoDW8sG1Txb4Pg0PMQwlqkYXpbvVGDxye5p40wqUuRJZMExEC05VWp7o9OFoAYLr6Kl+PbthAu+5xYiijLD95zPrizb9NNEwRYNxdG6B/HEwjgeGhQCr9k+mFZUUk5bKW7etHlykZWftML9SknTSB0WXBHIt5NvomUfmS5W5Sp3POe8Y181bLSZQxv/4m02ps3Kgt2WCMv1+PYK7jK4Mb8JTx60/OLGpjA71otMj/SnlqbfGjVPGd0mdZNdZ2Kzq9deCnDvXzh1ww8VRvhFhlZmeFgR20hPS8MjfxgY+yIhes4XrUW8xiu35lleZqpQCZjQKOE8wnBhff6WGlh2CuRenB4tutdffVFxCw+XcDUQjnmzMvgsYsYGi1fBuTzV1WsTChMa1RR49YtHZe7+n7BIRhKiPwjdQ18ozuuj5JSzh4Ah55posKuSzhZ0iEc27qxIi77AxTfIhj/r19+bdUrQ8a2rcv4FO8f3Lr9fX0pqiqYk+R+kdsE+RbDS8uJ/rvOSYCIrbeAoGi72pbdhIfht+T4YiUTTDiIT2AfWq+g9sdte2ns7gXBakKyZ2q8T+GqjnnCyhg4x3I7Z2THnttOv56UQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6304.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(136003)(396003)(346002)(39860400002)(376002)(366004)(451199015)(38100700002)(6486002)(33716001)(82960400001)(66946007)(53546011)(66556008)(83380400001)(5660300002)(6666004)(8936002)(44832011)(7416002)(2906002)(4326008)(6506007)(8676002)(186003)(478600001)(26005)(316002)(66476007)(54906003)(86362001)(41300700001)(9686003)(6916009)(6512007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AAn1vxFSFRa3WsJvfg+che4alWk1kenxdCai3WRqzqLqzY7VrQs6pHKWix/L?= =?us-ascii?Q?53KtP2dQ//bR78XkVea/GRRzmBhWK5e4zbTF7cPQHMBGuAfzeEWsvcxqTRxn?= =?us-ascii?Q?3dEw4fAd1gvWwYoLfjsfWMFLOy341yZQp2QGkt7uc3fnPaUAJJIZSOa5++eR?= =?us-ascii?Q?TnX6MjBxc2AyDFa7uSmbMebLmHZyNfz3dVIBeSIXxxK7dmifiMSwETNW34n2?= =?us-ascii?Q?h/AGDpCHIIJ2jpeEQy9LSnjpo5h8GwEzqyFvKA4Bne0JPn+B7cvaA/xB6dlk?= =?us-ascii?Q?ndCoPppkIFrjgF9wg+jk3Kk3G0tJotsKwINzY2Wc9zf0fYgi2qHoeio1qjwh?= =?us-ascii?Q?oEjZo5f4DYyHE/VCZROCQPKv2o8cgUpSnM5qa0H71GEfes9qnMkqDrP3zZ9D?= =?us-ascii?Q?wqwOSLh1QXgAtmf0/ZYnXdJ6WuQLhYxiK2NDHYIDbxSSxCQa8TAzGdF46nYK?= =?us-ascii?Q?nZ5OAfC1+bNSG5Y3nfCCEb09Jdv8q0G2+vVNdjeeXGpQgjMIsiquvGirWUFg?= =?us-ascii?Q?d+Btfcm1LGtrC7mmsAAojL2HkwRmpQQrYFwT0Slmjv7HSm43oRIfvIIUPNkv?= =?us-ascii?Q?noVDdd2p+MHth/SYDZwsYah5LZciRyttFRKa82QCLhfITFF6bsPidethlvWg?= =?us-ascii?Q?DEva66PU109TlDBip0qj3n8a9td62sIpQ/AukIG2iFkC6plUP9p0II6TkNNl?= =?us-ascii?Q?Uu/EKAacJGxwkoM3R35NcD5j0sgXK/aWBhf9FRNeTD8EuZ5kWrM216FUqb+K?= =?us-ascii?Q?mkyaDBYj73Z+SfFA49OK9zEK785Rh5exCdiQhfv2fDo6WdgEbIXpnAzZOSeO?= =?us-ascii?Q?c3RJPt4BY47wSFosFbAyhIFtaIfsIIP9U52TRj+59XbqvonMAzD3FJB0kW4d?= =?us-ascii?Q?2yxHNHcyGSkzc0vi+HZXYlosjpgzTpko3lc87UmqEfHkJvAqA6H9VOYsrsdH?= =?us-ascii?Q?p9k08boENHFAaM/8gzP207feuHwkWzJ1A5lmilDU3MToktYueuD/GipzrGBG?= =?us-ascii?Q?xJA80Ou0WEHse9ZLRajlRaHP5vaJ+I5tPMbCowwSeJqMrTgdrY1VSM2NMhYO?= =?us-ascii?Q?2iL+u6LecNHHkh6+BRrDml4qUU33dYh/Lb4CYPr/QzbLLVasQfU5Lgvy18L7?= =?us-ascii?Q?qCRp6cIKkx/DpaognOnxdq1XuwupZ99Z5phnDdfWifAmg4sASSxmEQuohPxS?= =?us-ascii?Q?yXimlIYpN8qKQazuvQ7mWd5/b49U6OaDc0ihBJkHHjyO2+NcVOo2VNt2omxZ?= =?us-ascii?Q?L/AD9p59d4kyNjsf333lTU90OLNS0B7cDAv8HgmfCkplJ5H2uKycSfJRXB9U?= =?us-ascii?Q?pMg6KZBk7NxVGRhWdD9cV/q4mayLRULUqcOMpngMbL7hM7OM/3GCNi8iNTk9?= =?us-ascii?Q?DurzvCgvUNinhslEp7xI1g7QvEMIlDAnxrbisMoczp7GgJRpQtthgIa/q3vi?= =?us-ascii?Q?E1L+ZG0scJopxRpEeft/FFr8fjUdP7rTOMmctMTdn3N16ZhitILYyoiDm9kC?= =?us-ascii?Q?vMQYbxdhb+Pnb14PmhJDv84eXmoSwiVNMDOg11JKxx/36izq3/YRb0EIVf+n?= =?us-ascii?Q?j1WADWPbLvOGwrwnqvxxnOOIlJWaF2o2qYFBTj/e?= X-MS-Exchange-CrossTenant-Network-Message-Id: 49b3761c-0b7d-4f03-0214-08dacdba9b4e X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 01:24:18.0788 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 05KDTf8ivWfZh2zvAyXc6zM2Z6D69pkaGN4JKGt8ujc7sWKZEu9yvTvKyt0oIrzwjoyaaC5YKCjdFU/dQN6F9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5306 X-OriginatorOrg: intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669253068; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QM8AXRK1dGCK60KZ4QHkEeYRuYT8NufyT5gZCkuseKc=; b=4QjOB1zyBdlphD/m+F8HbKl22AUblJY2V+j99dZRXYcux+KSCz/3eqi8gK0HL3XlaPg7L8 M5SdzsBxvtMt08zB+Dv8oIHbUuReMOs8NjaV65NkcHobJMo/jw/flOXrvjA9UrbPL25QfB 0L9pnRlutSAUPJLyrMl385m+I54N26w= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b="Q/ok708K"; spf=pass (imf28.hostedemail.com: domain of feng.tang@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=feng.tang@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1669253068; a=rsa-sha256; cv=fail; b=6pulbhcBCiOWmzv8ITDxLJIz0B0bMmJ66dHsiPPuR1wXWK9vTjmAfjhUwnKRofA3CRycWF +xwRxmTbdp8KKzKvb6kkHfHu34r58tQYHltbFrZ/wpHULYmuXpZibOn+6ULRjyYlurqyv2 qeWnnxqjoh1JFN+hSqqly0sXD65vuk0= X-Rspamd-Queue-Id: CCFDBC0009 Authentication-Results: imf28.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b="Q/ok708K"; spf=pass (imf28.hostedemail.com: domain of feng.tang@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=feng.tang@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: g7pyipjp7fg961g4i9du7rdyef3gnd49 X-HE-Tag: 1669253067-282184 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 23, 2022 at 06:03:26PM +0100, Vlastimil Babka wrote: > Subject should say mm/slab My bad, thanks for catching this. > On 11/23/22 13:31, Feng Tang wrote: > > commit 6edf2576a6cc ("mm/slub: enable debugging memory wasting of > > kmalloc") introduces 'SLAB_KMALLOC' bit specifying whether a > > kmem_cache is a kmalloc cache for slab/slub (slob doesn't have > > dedicated kmalloc caches). > > > > Add a helper inline function for other components like kasan to > > simplify code. > > > > Signed-off-by: Feng Tang > > Acked-by: Vlastimil Babka Thanks! > Patch 2 seems to depend on patches in Andrew's tree so it's simpler if he > takes both of these too. Yes, patch 2/2 change many places of kasan code. Hi Andrew, Could you consider taking these 2 patches to your tree? If you think it's too close to the merge windown, I can respin after 6.2. thanks! - Feng > Thanks, > Vlastimil > > > --- > > changlog: > > > > since v1: > > * don't use macro for the helper (Andrew Morton) > > * place the inline function in mm/slb.h to solve data structure > > definition issue (Vlastimil Babka) > > > > mm/slab.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/mm/slab.h b/mm/slab.h > > index e3b3231af742..0d72fd62751a 100644 > > --- a/mm/slab.h > > +++ b/mm/slab.h > > @@ -325,6 +325,14 @@ static inline slab_flags_t kmem_cache_flags(unsigned int object_size, > > } > > #endif > > > > +static inline bool is_kmalloc_cache(struct kmem_cache *s) > > +{ > > +#ifndef CONFIG_SLOB > > + return (s->flags & SLAB_KMALLOC); > > +#else > > + return false; > > +#endif > > +} > > > > /* Legal flag mask for kmem_cache_create(), for various configurations */ > > #define SLAB_CORE_FLAGS (SLAB_HWCACHE_ALIGN | SLAB_CACHE_DMA | \ >