From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0D54C433FE for ; Thu, 24 Nov 2022 14:26:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33CB16B0072; Thu, 24 Nov 2022 09:26:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2ED8E6B0073; Thu, 24 Nov 2022 09:26:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B4706B0074; Thu, 24 Nov 2022 09:26:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0F5176B0072 for ; Thu, 24 Nov 2022 09:26:09 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C4042160BF2 for ; Thu, 24 Nov 2022 14:26:08 +0000 (UTC) X-FDA: 80168560416.08.123AF8C Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf05.hostedemail.com (Postfix) with ESMTP id 6F8D4100002 for ; Thu, 24 Nov 2022 14:26:07 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id v3-20020a17090ac90300b00218441ac0f6so5923278pjt.0 for ; Thu, 24 Nov 2022 06:26:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IAlmDlf3J91/9mijeaog5st0f/5MkIiZF834ldeIBx0=; b=Lk+Axj7fdQi0yyxjccdwBH5rucopDiUHwkMJPcAFD7s4QwYPhq5ajHq09DdObQ2Uog wvdaypvnpIdGzvnl6AsKAxzZmxCeUbtC7znyGNbYEg7RN9iV4EwXh+GZf8DL+r6JQppl 0+RXV3gkAXLlDxn/fNq6t7tixQd2bpUcJi2Ylyv3d52VAUk/OwKMDjpNV+LVUuioP10j sHDbN3vrfGaj2NkLLJ9I/PYietus+u8+w/+awCtXgEMK0AXEQT4XtdXgL22zcbuXIykW 7fBCiTHNDknLsSPFRhsyiqhQ6LbQ1dEABMZHZ/VvRWXQTm/LwZnZBOB9rY33q5Je01kz UuWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IAlmDlf3J91/9mijeaog5st0f/5MkIiZF834ldeIBx0=; b=37BMe5hY0HDftsZ0tM4CShrRKLK7XZupufX2/ivoZAD6Ges/F4t7uZ940egdlvkxy/ B3szl/3TUF2jUv2Kzl0jK9+9Y3h3jrOaC0gdecuvaAy/y3f/NPFjBaijxAf2CsVc5GRg qOsLMgFrKyBnuSKf4iYXLXKvAYGQhY6fdnijN4Grk/TIgNnTCC8DT2M5RFhLKH5ylIFe RjtdZmO8vvk7inSZXx5yU13xvN+phc6Gp2Aa+CZeicp9dSvTQZ0wv5OVhigYXQF5OoEP JsL6T1Yg/OtwosCevf0m3pkJCV+yGhRL98f29OUyMcrrnpZJVa+14GI13LJGUrQEYm5Q 42Qg== X-Gm-Message-State: ANoB5pnIQTNQM7cQIMX0EO11TXXNsP+S+MY1MwM/fSEilWYC/J4AoDv6 gHTN6HQ2We0uigNrfpoyZ20= X-Google-Smtp-Source: AA0mqf5GMN96W6w9aQMjgL4hm3VPATsFalHprJKWDdJ0RfZ4rKCtYx8AcAblrrg7VOpxiQKs3Ex0HA== X-Received: by 2002:a17:902:e807:b0:186:fb90:5774 with SMTP id u7-20020a170902e80700b00186fb905774mr14542983plg.137.1669299966305; Thu, 24 Nov 2022 06:26:06 -0800 (PST) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id b26-20020aa78eda000000b0056da63c8515sm1319439pfr.91.2022.11.24.06.26.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 06:26:05 -0800 (PST) Date: Thu, 24 Nov 2022 23:25:54 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Roman Gushchin , Andrew Morton , Linus Torvalds , Matthew Wilcox , patches@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/12] mm, slub: don't create kmalloc-rcl caches with CONFIG_SLUB_TINY Message-ID: References: <20221121171202.22080-1-vbabka@suse.cz> <20221121171202.22080-7-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Lk+Axj7f; spf=pass (imf05.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669299967; a=rsa-sha256; cv=none; b=rUW66IUtHhXO1md7rr4zQEHk+ScPGbCaEslOdzWw/1e5ZVTsUnb0QGVU1utXevw5AWk+DL Vz1CR0w5VlStByMj2wbPXAxQqefgPy5lAk7BAj34uSNz6gJLqdrocPRasqAYxGhKij0N61 HzC3VsJSEet3neeSPpMB4Rf+F/ZOoI4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669299967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IAlmDlf3J91/9mijeaog5st0f/5MkIiZF834ldeIBx0=; b=OJODdGqcfd17wlMloOvsodYcaal44cQphYlWYT3py19UBnhavkV0hX+vw1NcHjTKZB3hVV kR35NUhrSEQwC4Wsjnx/X2qlYWQ9Iib8I+b4oQRWMg0NVqFqrGH0BT3e/dlg8NyKN2/90Z nmFM7eS/nl3WRjPbtmsqDWWi0Makrqc= X-Stat-Signature: wskgcnc9szxqt5b8j31wji3ef8q9wn8j X-Rspamd-Server: rspam08 X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Lk+Axj7f; spf=pass (imf05.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Queue-Id: 6F8D4100002 X-HE-Tag: 1669299967-401860 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 24, 2022 at 10:23:51PM +0900, Hyeonggon Yoo wrote: > > @@ -859,7 +865,7 @@ void __init setup_kmalloc_cache_index_table(void) > > static void __init > > new_kmalloc_cache(int idx, enum kmalloc_cache_type type, slab_flags_t flags) > > { > > - if (type == KMALLOC_RECLAIM) { > > + if ((KMALLOC_RECLAIM != KMALLOC_NORMAL) && (type == KMALLOC_RECLAIM)) { > > for consistency this can be: > if (IS_ENABLED(CONFIG_SLUB_TINY) && (type == KMALLOC_RECLAIM)) { > My finger slipped :) I mean: if (!IS_ENABLED(CONFIG_SLUB_TINY) && (type == KMALLOC_RECLAIM)) { -- Thanks, Hyeonggon