From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4CD2C433FE for ; Thu, 24 Nov 2022 10:57:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1FBB6B0071; Thu, 24 Nov 2022 05:57:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E81566B0072; Thu, 24 Nov 2022 05:57:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D22096B0074; Thu, 24 Nov 2022 05:57:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BED586B0071 for ; Thu, 24 Nov 2022 05:57:13 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 84662812BD for ; Thu, 24 Nov 2022 10:57:13 +0000 (UTC) X-FDA: 80168033946.02.CB44137 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf16.hostedemail.com (Postfix) with ESMTP id 3BB5418000E for ; Thu, 24 Nov 2022 10:57:13 +0000 (UTC) Received: by mail-pf1-f174.google.com with SMTP id w129so1334822pfb.5 for ; Thu, 24 Nov 2022 02:57:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DvR5jjAQ32QrpwiKXRFx0nsQpDhgkCSnhCfnlCZrw8c=; b=Wt6hrqGpXslJn3dEbv8BymwvP+VI2XLUb9ku4DeGKq5iPG6tvu2eeNGM2v19yYxZXK 2iRnR7/jW1ANAb4yTmd1xxYGCbojc9uaB4EyDb+7msZO5ciVsPX8KaEtiMImXEuB575P EvK04nIJoHOWmIkM4fg5vHxRr89C0WSBB+4qsb57cIuudRRGfwtytv8DdDGufjPLRI95 MYHi3IHE+zkQ6tYCFbOB5HTfStJyBDWh05kT39T+0XrdQkiVodFxX0Nw/bmbWzem4FjR 5zpjg4uGJAn+5G8dND+4BdxAo+OC4ytYQfKYo5L2rq9w3u82tLTrrW+tMMZ/5gChi15/ HdZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DvR5jjAQ32QrpwiKXRFx0nsQpDhgkCSnhCfnlCZrw8c=; b=02E7ADeDhy73uUYkdbiTpHQlQozpZ/rgyIdkk+rUTcCKh5CtIWoQLYhY9DV7+GDrbZ rruE0wPLa7KOBC/eucVHvgjgiAgKKdehgJFNqL2ThyxDxlBIlsLLKnBX30YrDVR4Di63 UQhOSquVH4H9FazYQKoPqzxih3Y1pUighmOs26xVG/FWviAxD5qBwa6121WvrB2/vI/3 Gawx1mjWAcRY9q1kPRGWbk/AZNMVLf9EzTI1Df+GNSNINK1nQ89ewQMXjI3jEE2k9klP ha7q6bILDT2kAiEoGl0Hvs49ddZsC5PqcazhrJajaLX0PkvcsRjw/pCmlqrkIGebr+IS p8Dw== X-Gm-Message-State: ANoB5plwCVbPhTI+4FJa/hgstvv/4P+8AhXxY0tXx2MvfMWG2l/pdl1u O4fC0nh1fCuNls+KMvbTDTQ= X-Google-Smtp-Source: AA0mqf6D82FN1B5B23pjKABFefH7BTG3GceAoR8ZpAUG4D18G+QXjdKVYpNq9NM9NhJrNfj8+fqa6A== X-Received: by 2002:a62:54c2:0:b0:56b:fb4f:3d7c with SMTP id i185-20020a6254c2000000b0056bfb4f3d7cmr34951232pfb.54.1669287432162; Thu, 24 Nov 2022 02:57:12 -0800 (PST) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id c4-20020a17090a674400b002189ab866bfsm2956687pjm.5.2022.11.24.02.57.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 02:57:11 -0800 (PST) Date: Thu, 24 Nov 2022 19:57:04 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Feng Tang Cc: Andrew Morton , Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Vincenzo Frascino , linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 -next 1/2] mm/slb: add is_kmalloc_cache() helper function Message-ID: References: <20221123123159.2325763-1-feng.tang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221123123159.2325763-1-feng.tang@intel.com> ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Wt6hrqGp; spf=pass (imf16.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669287433; a=rsa-sha256; cv=none; b=NDipAykz+RL+M3tl91E25l9brS+twGT/7EUeLUFNGq9ruhsMjNXOOyVCRlBs1YdMu5eQQP qb34X9F7e6/qEkApM3wYNbVf90GMqP7HqV5oRptOjW+/P/E/fOYJXC0cIh/MyjKS7zvjHS oNa5KGhmliFw+AQ5lYxTbYZU1F3kBOE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669287433; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DvR5jjAQ32QrpwiKXRFx0nsQpDhgkCSnhCfnlCZrw8c=; b=7k3yPlccigzQNsWTgildj5qRYOmEF5AfpLdNYdjRXB3YlGItD6djJxCDG1sO+fUSPjfcwW LHX9qaXTV7yQxYzRZg7LJmZKoT7aBIU5T+K+2CUjDp0RVB26/HDiLHewSGyAvE11lxX40q Be3JUL+TZu0xeNUG5XqZOnlA0UgO0wU= X-Stat-Signature: dz7f3gisb91ayyd1ba1ragqada17ez5q X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3BB5418000E Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Wt6hrqGp; spf=pass (imf16.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-HE-Tag: 1669287432-839271 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 23, 2022 at 08:31:58PM +0800, Feng Tang wrote: > commit 6edf2576a6cc ("mm/slub: enable debugging memory wasting of > kmalloc") introduces 'SLAB_KMALLOC' bit specifying whether a > kmem_cache is a kmalloc cache for slab/slub (slob doesn't have > dedicated kmalloc caches). > > Add a helper inline function for other components like kasan to > simplify code. > > Signed-off-by: Feng Tang > --- > changlog: > > since v1: > * don't use macro for the helper (Andrew Morton) > * place the inline function in mm/slb.h to solve data structure > definition issue (Vlastimil Babka) > > mm/slab.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/mm/slab.h b/mm/slab.h > index e3b3231af742..0d72fd62751a 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -325,6 +325,14 @@ static inline slab_flags_t kmem_cache_flags(unsigned int object_size, > } > #endif > > +static inline bool is_kmalloc_cache(struct kmem_cache *s) > +{ > +#ifndef CONFIG_SLOB > + return (s->flags & SLAB_KMALLOC); > +#else > + return false; > +#endif > +} > > /* Legal flag mask for kmem_cache_create(), for various configurations */ > #define SLAB_CORE_FLAGS (SLAB_HWCACHE_ALIGN | SLAB_CACHE_DMA | \ > -- > 2.34.1 With Vlastimil's comment: Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> -- Thanks, Hyeonggon