From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB80AC4332F for ; Mon, 14 Nov 2022 08:30:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 396936B0074; Mon, 14 Nov 2022 03:30:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3459E6B0075; Mon, 14 Nov 2022 03:30:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 234838E0001; Mon, 14 Nov 2022 03:30:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1851C6B0074 for ; Mon, 14 Nov 2022 03:30:18 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E3AE480DCB for ; Mon, 14 Nov 2022 08:30:17 +0000 (UTC) X-FDA: 80131375674.22.B58DA5F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 884D5100007 for ; Mon, 14 Nov 2022 08:30:17 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD71D60F0E; Mon, 14 Nov 2022 08:30:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC080C433C1; Mon, 14 Nov 2022 08:30:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668414615; bh=M5Go57T18KU3kovwfaSoPQkXTIJ9pU/x8zoi9VefwW4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SdH1QQKcLZQv3AKSNRqZgc4tXzBdMXgXKDuK3MoPQQRFpIYn6+O1nQZvg7Lp1GOYn QE742J9xLRn5ra6lGaVDnYoZgTzRjS0XJQSharaM9uVu6TJ//f4uH4suR3r5UAk5PK EjsXAoDr8CJU0bttAruYJ+pnYM1kFvmZR3cBw8CkWNisnUsoXW1ZUF1QcRRiDm7Y3L oMXJbnHupIRPsjq+jbJhGZzXY9uFf9StdS9G4A+jFvbnURqB8ZwRSbqvO+FUa98HIw VRhvftCN3zogKZ7mhH3RYpIiQTD/5vXd1uPM6Tw59jiLpnVXiTCkuHHIHG2JgSWt2/ SIDKXJb6O8rcQ== Date: Mon, 14 Nov 2022 10:30:11 +0200 From: Leon Romanovsky To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann Subject: Re: [PATCH RFC 10/19] RDMA/umem: remove FOLL_FORCE usage Message-ID: References: <20221107161740.144456-1-david@redhat.com> <20221107161740.144456-11-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221107161740.144456-11-david@redhat.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668414617; a=rsa-sha256; cv=none; b=bre6/B+kXni6WEOiO3wc67yiE3kQzkTOAg2U1/fH87ZrAbO/MF92Z/6+9VEgJCq7GVroRf wfze3N2o1sDDQg1y2pSZQaJI2vI/QcpgVBGrJfiudsL0P3jE7CiMM34VH5KmdWoIjl3MP3 aA+TNSM516doslLJt37D/h/UQT9fgik= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SdH1QQKc; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668414617; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NKsU+YStj+KudlHIrMacX0mMEZpbxBs6EK/uJXLJy3g=; b=kzSBZItKVW6kBCbfE2HY5Hwtvsvz2SYgUWkhitUVnk3sJzPc2JUIrZFbdJLsTUHJgwCsE3 BNrPfBto1T6iOzRpWJev44MieVQHsDKtqzsWCZ2DHDX9R5IoE4YmIvX50ZbMjTvF+Vl4fF jdygSPKAM5FEienggm0bcwhZNFAsbvg= X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SdH1QQKc; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org X-Rspamd-Server: rspam02 X-Stat-Signature: abt1ehioxyhhzjtcou3mgmio6renzp1b X-Rspamd-Queue-Id: 884D5100007 X-HE-Tag: 1668414617-579020 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 07, 2022 at 05:17:31PM +0100, David Hildenbrand wrote: > GUP now supports reliable R/O long-term pinning in COW mappings, such > that we break COW early. MAP_SHARED VMAs only use the shared zeropage so > far in one corner case (DAXFS file with holes), which can be ignored > because GUP does not support long-term pinning in fsdax (see > check_vma_flags()). > > Consequently, FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM is no longer required > for reliable R/O long-term pinning: FOLL_LONGTERM is sufficient. So stop > using FOLL_FORCE, which is really only for debugger access. > > Cc: Jason Gunthorpe > Cc: Leon Romanovsky > Signed-off-by: David Hildenbrand > --- > drivers/infiniband/core/umem.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Thanks, Tested-by: Leon Romanovsky # Over mlx4 and mlx5.