From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D62D6C4332F for ; Tue, 15 Nov 2022 08:40:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2615D6B0071; Tue, 15 Nov 2022 03:40:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EA536B0072; Tue, 15 Nov 2022 03:40:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08C296B0073; Tue, 15 Nov 2022 03:40:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E95076B0071 for ; Tue, 15 Nov 2022 03:40:12 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AC6AF8079D for ; Tue, 15 Nov 2022 08:40:12 +0000 (UTC) X-FDA: 80135029464.26.E510D6D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf14.hostedemail.com (Postfix) with ESMTP id 9115A10000F for ; Tue, 15 Nov 2022 08:40:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yuh2AMTeq6XlUMUUyRATLkJw+4BsFLkicyPlBlFhPJo=; b=XfisNEoRqIh8yEGYpWzXgh23Sr buVO6GTrfuC2K2/TOOpv1KkekxkXWTAiVCQfaoiNOvJsxio1npxmNGfsa/4hZcReATm/hc7EK9qt0 QF0y9bxfOoZNBfj05MuG3pmntR+avrCMATKBpT0Kf5mvz9FwLU3+JGlLmVv/3Qo/O/EFFaOnh2gW5 hPsUrkohpPBoOetYrCoyBNzy4i76AmergsP7AarvqCIpZtdVsP4fx7eYyNLGIuu4DypVDMsMIEpU2 IFRd2IqxgT9jEGRT3R3iPM9fC5uIwW0jKei/nNF4mqJz1Iz9OSPQgqt+Snst/KkUKmtZu5kNK43kw YquOyt1A==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ourUF-008zH0-Ix; Tue, 15 Nov 2022 08:40:07 +0000 Date: Tue, 15 Nov 2022 00:40:07 -0800 From: Christoph Hellwig To: Dave Chinner Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/9] mm: export mapping_seek_hole_data() Message-ID: References: <20221115013043.360610-1-david@fromorbit.com> <20221115013043.360610-2-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221115013043.360610-2-david@fromorbit.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668501612; a=rsa-sha256; cv=none; b=gn2sEUlnWfH4493yNQcuuxH29Y04BLfRKEIzywpTK7tKPh2WAKPVBKsVmkd8Cj9DP1jqk8 xEtGMyYRYQwrCBZOfCHnvMMY/FLrVngeeQWTFTBc/fyR8nrIyQ3nsNFUhBjRqOVvWZPkcv 0r9bTmSdC0/mmebkVRX/bLLOV+CidYo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XfisNEoR; spf=none (imf14.hostedemail.com: domain of BATV+c84debcf882b373fc39b+7023+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c84debcf882b373fc39b+7023+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668501612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yuh2AMTeq6XlUMUUyRATLkJw+4BsFLkicyPlBlFhPJo=; b=UnOLkwI7mYQ3XKXSJTkbeXs9BiE4s0RiXYWTUmAckAHYfUPhdyyNcKPU83y47fRa67C1Ot MPjQGkf/r9728+TMhmGvHe77MATbbIm0o1d6sUYoyRRgrIe3Nr0/2eCaV6euktIDdWTUeW uLLuckHq4LPeYu3E+uiYCrXShEIYANI= X-Stat-Signature: b47jcdmgp1bq7xz5jzkfx76ybemdcwr6 X-Rspamd-Queue-Id: 9115A10000F Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XfisNEoR; spf=none (imf14.hostedemail.com: domain of BATV+c84debcf882b373fc39b+7023+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c84debcf882b373fc39b+7023+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1668501610-542477 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 15, 2022 at 12:30:35PM +1100, Dave Chinner wrote: > From: Dave Chinner > > XFS needs this for finding cached dirty data regions when cleaning > up short writes, so it needs to be exported as XFS can be built as a > module. NAK. Even if you use these helpers to make your life a little easier, the main delalloc punch logic belongs into iomap and not XFS, and does not need the exports.