RE: [PATCH Part2 v6 05/49] x86/sev: Add RMP entry lookup helpers

Kalra, Ashish
2022-08-01T21:50:42Z

[AMD Official Use Only - General]

>> I disagree. Running an old kernel on new hardware with a different
>> RMP layout should refuse to use SNP, not read/write garbage and likely
>> corrupt the RMP and/or host memory.

>See my example below.

> And IMO, hiding the non-architectural RMP format in SNP-specific code
> so that we don't have to churn a bunch of call sites that don't _need_
> access to the raw RMP format is a good idea regardless of whether we
> want to be optimistic or pessimistic about future formats.

>I don't think I ever objected to that.

I agree with what Sean is recommending to do.

As I mentioned earlier, in the long term and with respect to future platforms, we are going to add architectural support
to read RMP table entries, so this structure will exist only for older platform support.

Thanks,
Ashish