From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5018C43217 for ; Wed, 16 Nov 2022 20:16:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 153746B0071; Wed, 16 Nov 2022 15:16:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 103B76B0073; Wed, 16 Nov 2022 15:16:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0CCD6B0074; Wed, 16 Nov 2022 15:16:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E50506B0071 for ; Wed, 16 Nov 2022 15:16:56 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C298480B1E for ; Wed, 16 Nov 2022 20:16:56 +0000 (UTC) X-FDA: 80140414032.25.650CD01 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 6F92180011 for ; Wed, 16 Nov 2022 20:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668629815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lJMb3PweKDaHiAjKMFZLERnJkKA8ghZTOfHaWwXAhIc=; b=OSyL7Z+gG/1dUjMJmNfw6SgaLQ/D/oz88Ch7/65QUKMqZ3WXaCXh5xWbOJQjLh+jFgqtzP Umw+E6DBYIbKizbSdoNaw8+lQXTICibBxAYEaB3TmqOlSH7JhcXGcuJmH0mSy3+84MByqH F6Xx3KV6sa4jFzxluJvaSXodEaGgjqY= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-544-7NSrAeO_OEWYa3KUzt3ybw-1; Wed, 16 Nov 2022 15:16:53 -0500 X-MC-Unique: 7NSrAeO_OEWYa3KUzt3ybw-1 Received: by mail-qk1-f198.google.com with SMTP id w13-20020a05620a424d00b006e833c4fb0dso18315399qko.2 for ; Wed, 16 Nov 2022 12:16:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lJMb3PweKDaHiAjKMFZLERnJkKA8ghZTOfHaWwXAhIc=; b=yUIb6G8rMjKBPjpaVlbtHR2UUUfDCAX9FmrHMauBq68bACJaXWItnK5qyo+aVw2yjf 5R2auFhJSIp26baJ+nQ7Mz228FkBCPrlkO88q0njlGZBu+eLecSF3wAYDXUU3wWFNz+i B/t1BxbAorXD9NPQcZc4lDwBanUl4xwnuMuQ8hosF0v6Zmdf6ID80aQFyenj3KjBiIRA 8Brt1pwpauslKlwgwqk2wPrrMSkZuzRUjv/hRVy/L+i6BJjZxANG8wQ+b/NfsDznVPtb 2EsrGTkjXhbQcwa+UgcZQhAadi/RSLSaLhRpTuvQNtCgbg2rJCs8BXxntKu5DxrXFn5C zyMw== X-Gm-Message-State: ANoB5pkAJrOyNPf2RAg987JaaDYT7U8uYcDotJlLfWxq+ps/iMR8Uw/k U+cmmlH6lzI+jMGzWttJ9tRd3MVTG3UeUFFPjqvKo5s/Gga/YKhHxdGSopeXrWMg+7xwq/TQGEX /rPF7s0iVOVE= X-Received: by 2002:a0c:8170:0:b0:4bb:5935:55ca with SMTP id 103-20020a0c8170000000b004bb593555camr22407689qvc.79.1668629812703; Wed, 16 Nov 2022 12:16:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf5aRLGEaHlnWsaZ/VJekIk1mm/UMDqHcXYp/X4E3nS3hDkgOLuv6G5RvAMyDSIkxiDlejByjQ== X-Received: by 2002:a0c:8170:0:b0:4bb:5935:55ca with SMTP id 103-20020a0c8170000000b004bb593555camr22407663qvc.79.1668629812374; Wed, 16 Nov 2022 12:16:52 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id c8-20020ac86608000000b0039d02911555sm9185919qtp.78.2022.11.16.12.16.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 12:16:51 -0800 (PST) Date: Wed, 16 Nov 2022 15:16:50 -0500 From: Peter Xu To: James Houghton Cc: Mike Kravetz , Muchun Song , David Hildenbrand , David Rientjes , Axel Rasmussen , Mina Almasry , Zach O'Keefe , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 37/47] hugetlb: remove huge_pte_lock and huge_pte_lockptr Message-ID: References: <20221021163703.3218176-1-jthoughton@google.com> <20221021163703.3218176-38-jthoughton@google.com> MIME-Version: 1.0 In-Reply-To: <20221021163703.3218176-38-jthoughton@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668629816; a=rsa-sha256; cv=none; b=HG4Fop0lxlsGl2/+L7HFV0jxURgIWIXUicshHO1YiXZifGqTVDp9MLCVkVpITCyg+3qBTm eP+kwsIX7bh/6lVWPJ8mzyo6YK5DBWe+9Wwr058tHPR/KEpMAMU7vNdFlqlyPJ89LjML0k h3/kCaL7ILfTXBKSBCOr/+tNpHrY7t4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OSyL7Z+g; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668629816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lJMb3PweKDaHiAjKMFZLERnJkKA8ghZTOfHaWwXAhIc=; b=LX8kTE15aK18mqvz2FuK3c8Si7wddT4aG2/+u8oI70q4o5q9wF8ceVHOosRzPOAJCnk/CT IYelLLh+XUzohpT9yBJq8Xg/aISo8er7Sut9omjl+wMBeAlk0Kcj1DgOPbYYPbxWlTo/V0 ftzjnysK706t/pP3UBpPxi5JcF+Be9A= Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OSyL7Z+g; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com X-Rspam-User: X-Stat-Signature: tfmr34ctd619u5r76c8sew84azdwhjde X-Rspamd-Queue-Id: 6F92180011 X-Rspamd-Server: rspam11 X-HE-Tag: 1668629816-540204 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 21, 2022 at 04:36:53PM +0000, James Houghton wrote: > They are replaced with hugetlb_pte_lock{,ptr}. All callers that haven't > already been replaced don't get called when using HGM, so we handle them > by populating hugetlb_ptes with the standard, hstate-sized huge PTEs. I didn't yet check the rational at all, but just noticed there's one more of it for ppc code: *** arch/powerpc/mm/pgtable.c: huge_ptep_set_access_flags[264] assert_spin_locked(huge_pte_lockptr(huge_page_shift(h), -- Peter Xu