From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54B3AC4332F for ; Wed, 16 Nov 2022 22:34:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFC4B6B0074; Wed, 16 Nov 2022 17:34:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DAE466B0075; Wed, 16 Nov 2022 17:34:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C75046B0078; Wed, 16 Nov 2022 17:34:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B82E86B0074 for ; Wed, 16 Nov 2022 17:34:18 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 90D361A07CF for ; Wed, 16 Nov 2022 22:34:18 +0000 (UTC) X-FDA: 80140760196.07.9410538 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP id 43F4440012 for ; Wed, 16 Nov 2022 22:34:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TSs/h9541uqf1HTxWzDvsef/ZgrLLRZbCCbFUZGOXH0=; b=Q3lO0FlYjsfHxxN9OkYNI6ATLL Oho2D0cTvZvi7wpxPauyY0zeEq/2JdJ/I3dMCjlnoV5bpZIb/mQAZs3SQDPxR9/qytodi2tKqtjLp fd/83AyWv4ynrD/YvHYfnGvIycxb+bGyWFQG/thfITBYO+k5OV0F5edz1J3IEnjd14m/eSUrReoPf MW7RSDy7yC/J4O5xDNOX5IQmXFNyhqbZLFl8hNXqC6AnyA7fCN/fy9usFD5VRCgT6DGx0kDVMGUOU Yh65IKEryi9JvDX7Qim84wetOYUV9rRnN6Twd9haqVhNUV0oEVvj4stzOmhuFffNOXlmzHhFn9PUP A05/D+Eg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovQyz-008PRr-PD; Wed, 16 Nov 2022 22:34:13 +0000 Date: Wed, 16 Nov 2022 14:34:13 -0800 From: Luis Chamberlain To: "Edgecombe, Rick P" Cc: "song@kernel.org" , "peterz@infradead.org" , "rppt@kernel.org" , "bpf@vger.kernel.org" , "linux-mm@kvack.org" , "hch@lst.de" , "x86@kernel.org" , "akpm@linux-foundation.org" , "Lu, Aaron" Subject: Re: [PATCH bpf-next v2 0/5] execmem_alloc for BPF programs Message-ID: References: <20221107223921.3451913-1-song@kernel.org> <9e59a4e8b6f071cf380b9843cdf1e9160f798255.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668638058; a=rsa-sha256; cv=none; b=F46jmcPJ1VheEMBh4n4z595lawEBHgF9d8x8OKZ8RcNAbBpFRKrZrR9iefY67p78LS4hc2 AEw3U+nH9Bj+k1jn8sZhbWTgam2K2oKXFsmPLolsA7eleS6kEpjUIDJTMgaZzM/M9ZBXs/ DDMqyw4A58zEDAVTTRl3kroWbPRdIhQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Q3lO0FlY; spf=none (imf12.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668638058; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TSs/h9541uqf1HTxWzDvsef/ZgrLLRZbCCbFUZGOXH0=; b=QArVFkNh6HiNlqMmQqG8LyDK2Fd3IG/YF0BlJZ5dfe9LGspiBNHoOxUgB+3zMZ6O5L3VhY szrb5JnCtT1wlhiA2i6KU15sAQP8oTmDb8akunqpXQDwGpigS0PquWoZxAj83kn1ftI2Hk mcqMBUAeA1SL9ZJ5TjLKDcLKk4SGnNw= X-Rspam-User: X-Stat-Signature: tou5ekru644t4mmgpi39o6uorfhqdhyy X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 43F4440012 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Q3lO0FlY; spf=none (imf12.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-HE-Tag: 1668638058-580976 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000039, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 15, 2022 at 09:39:08PM +0000, Edgecombe, Rick P wrote: > On Tue, 2022-11-15 at 13:18 -0800, Luis Chamberlain wrote: > > The main hurdles for modules are: > > > > * x86 needs support for CONFIG_ARCH_WANTS_MODULES_DATA_IN_VMALLOC > > to use this properly > > * in light of lack of support for > > CONFIG_ARCH_WANTS_MODULES_DATA_IN_VMALLOC > > we need a fallback > > * today module_alloc() follows special hanky panky open coded > > semantics for > > special page permissions, a unified way to handle this would be > > ideal instead of expecting everyone to get it right. > > How were you thinking non-text_poke() architectures load their text > into the text region without the fallback method? Fallbacks are needed for sure. I think you spelled out well what would be needed. Luis