From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E124BC4332F for ; Thu, 17 Nov 2022 00:45:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42F726B0072; Wed, 16 Nov 2022 19:45:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E0196B0073; Wed, 16 Nov 2022 19:45:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2815B6B0074; Wed, 16 Nov 2022 19:45:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 192786B0072 for ; Wed, 16 Nov 2022 19:45:25 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DA05A1A0D0F for ; Thu, 17 Nov 2022 00:45:24 +0000 (UTC) X-FDA: 80141090568.24.A29718C Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by imf06.hostedemail.com (Postfix) with ESMTP id 7012B180003 for ; Thu, 17 Nov 2022 00:45:24 +0000 (UTC) Received: by mail-qk1-f172.google.com with SMTP id d7so241162qkk.3 for ; Wed, 16 Nov 2022 16:45:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HEOs2OljVpzFekHebtNmxJNTS1biZDzbDC+7E+gbGXE=; b=NKUDG6/HRBHYArrki2ErKlKAFAloDP3syGXEvUqNJ9D2fVrZim0dI4zYfgnJWEKy+2 eIgPOs+mttvXhYUIJL/UppN4gHtQqcQpWlrONSgHhATtfRfLqa70r2Y5AFUtDhoXumLz QwAO0SpqErl+SpXb2isD+wqK260zhrI3m0OcjGKZmRIuadG54e+ieDR5HURAecTq4gww +4XuPNBvBD2G5dec/bz8Eh9V9EDh1RbiHGn8GIrcO4V8END9r1k5y0xfRAbT/lxmG9Cm d4SXiY9+ZupOQT/Gb+ZePnA6lwtOPkxvxI9tRVsC2WHBPZX7s+xnX8nZsTymxhqmYSZB 7vEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HEOs2OljVpzFekHebtNmxJNTS1biZDzbDC+7E+gbGXE=; b=BhjEGBYDsxM14wHKFzgXlpbNCb5UMvGnEZ5cgt0DyVryNL5/l/NujGWlW9H3tcESLu KOBOLar9BGjwxL1qDhUCETG6EzzPrbyfE6fan/vu+q61VEPT56LKRODBmjsBPvtTGEV0 JW4nSDX9HoqqLBcd/7mcsCefrvR8b5ueU/zGhbUefTVUG01qL/415VN6tlgXMNWL/x59 fN3z+XjQfp4X6troL4ZL26AgZWmLRKRUcCKS7xJP4L/unogdOHJQc3/K8omyocBHAu8x 1DjH0RvAfZXty9khtF3LWfC4wlT+qZzstTc/NEZUxlrSMHhkFH0+zbuzU0s6n9rscFxQ 0T2g== X-Gm-Message-State: ANoB5plMbUFQOfxmBcFuQa2pJduu44AbbgMmR7t/+EO66vb4J14qYqDa wFelc2sMXQumzA82+0kONAYwiE41sP4WHw== X-Google-Smtp-Source: AA0mqf7xjJLeTnaPhhrans4JhE0iVba1LlwPzkyl9vYE07B6pyjsI7ODbIFQEN1WHHyVUFKfNxMUWg== X-Received: by 2002:a05:620a:1455:b0:6ee:80b5:32d3 with SMTP id i21-20020a05620a145500b006ee80b532d3mr22079595qkl.237.1668645923644; Wed, 16 Nov 2022 16:45:23 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-122-23.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.122.23]) by smtp.gmail.com with ESMTPSA id n7-20020ac86747000000b00399ad646794sm9480378qtp.41.2022.11.16.16.45.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 16:45:22 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1ovT1t-0066TN-E8; Wed, 16 Nov 2022 20:45:21 -0400 Date: Wed, 16 Nov 2022 20:45:21 -0400 From: Jason Gunthorpe To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Andrew Morton , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Leon Romanovsky , Leon Romanovsky Subject: Re: [PATCH mm-unstable v1 10/20] RDMA/umem: remove FOLL_FORCE usage Message-ID: References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-11-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221116102659.70287-11-david@redhat.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668645924; a=rsa-sha256; cv=none; b=Jqj9/akvhg9yEmRoOxRekz3FRLDtz8rLRoOpip5XIr58gJUIJ8CmNsw7nZb3c1Qsspk7rI w28anLVDVoMgU57I6S8TS4i2dsb2foKtMpinNWMDAV2VmmK3LErwjObSL/38NYzfstvkHn 2vgMsadxXV67fCmeDP8fXPeLHhpttIY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b="NKUDG6/H"; dmarc=none; spf=pass (imf06.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.172 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668645924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HEOs2OljVpzFekHebtNmxJNTS1biZDzbDC+7E+gbGXE=; b=niNsw8YzYt/I/caYG+HETWw+2NOs6w7nVA5qZq3SuCoa8WWAbcdnVPsUnOPQpdJqcj9nci QKH4HgP0Tw6FDywIG4FV5pn5t0fMinkClHt92y6MqkjVtChMxURMAVPHOePYTaZUTSOoDB JYv6+JPelpdNzd4H9CzhE9ix/u5Z7XE= Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b="NKUDG6/H"; dmarc=none; spf=pass (imf06.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.172 as permitted sender) smtp.mailfrom=jgg@ziepe.ca X-Rspam-User: X-Stat-Signature: 7iwyb5f7hr8mygxeuwq6ta8gfhi3aitn X-Rspamd-Queue-Id: 7012B180003 X-Rspamd-Server: rspam11 X-HE-Tag: 1668645924-753300 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 16, 2022 at 11:26:49AM +0100, David Hildenbrand wrote: > GUP now supports reliable R/O long-term pinning in COW mappings, such > that we break COW early. MAP_SHARED VMAs only use the shared zeropage so > far in one corner case (DAXFS file with holes), which can be ignored > because GUP does not support long-term pinning in fsdax (see > check_vma_flags()). > > Consequently, FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM is no longer required > for reliable R/O long-term pinning: FOLL_LONGTERM is sufficient. So stop > using FOLL_FORCE, which is really only for ptrace access. > > Tested-by: Leon Romanovsky # Over mlx4 and mlx5. > Cc: Jason Gunthorpe > Cc: Leon Romanovsky > Signed-off-by: David Hildenbrand > --- > drivers/infiniband/core/umem.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Jason Gunthorpe Jason