From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BEEBC4332F for ; Tue, 22 Nov 2022 01:46:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 227CC6B0071; Mon, 21 Nov 2022 20:46:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D7E78E0001; Mon, 21 Nov 2022 20:46:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09F586B0074; Mon, 21 Nov 2022 20:46:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EF0916B0071 for ; Mon, 21 Nov 2022 20:46:27 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BCE1140D54 for ; Tue, 22 Nov 2022 01:46:27 +0000 (UTC) X-FDA: 80159388414.19.6237DE3 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf03.hostedemail.com (Postfix) with ESMTP id 62B7A2000A for ; Tue, 22 Nov 2022 01:46:27 +0000 (UTC) Received: by mail-pf1-f170.google.com with SMTP id 140so12987310pfz.6 for ; Mon, 21 Nov 2022 17:46:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SVHrNvmN2aKc4xwWxCNYKIFTFpQYBYiPFTCfwC3xsW8=; b=G/z6TQzB2xX/UeJGfPJ90z8DHKYOhsUZ9iGd6p+kIBndZj/htaZ86BJIYgelduK8na gMmniUO5ITM9E54+jjYQWpDvF40GbAak8BYQTi+uIZQk6dHbtOsBxGm2oT9QdBaopne7 RuZfU2zrSOnAyG1GGRsCsFqEwU882/3KIc5Dk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SVHrNvmN2aKc4xwWxCNYKIFTFpQYBYiPFTCfwC3xsW8=; b=Pil01G2lTcVCbQ0UJ+02AX3PqVB9m4mCtusZcVdBLwVliCYlsc6D/+QgzlrR6wpUMS TeXdqujdLPz+8EVqYnPBWQqUuuw2D6FK/5AAco5f1U10/QUsHp/ng9kysLGCJRUH7Fuw VOo5hUAD65/eIO0Fs1cfSmRAMsdl21rlmlB54RE7BWu6/q/aq6lxG+W8p/WDt6YgAtPg RQBDQwPXMlrnQKL1NMmGWV8x1Ehw1bzi9OWHbTjVkvWc0QtCMUpkDKN5euatzaQE99Zi HdvyLDsZVpFea7HM9Vug4Ai+kwlll9nax0LIBZLsGO0cHs8lvoFSX6h/N+KovhKnVFvi lWeQ== X-Gm-Message-State: ANoB5plQSjlN8srvv3ALJng5dP/o+A13hd/lU1cAzPVZWcPmT1vRS4DK KCwcooAa7wu4hs5/n5ylqBQaKw== X-Google-Smtp-Source: AA0mqf6pZsf3WZs/zHNwvoQGScEpwoTIAQHPQkJRqetfeC0UkOw6KbHhMELosyYGDDGhIPLJpam87g== X-Received: by 2002:a05:6a00:3004:b0:56c:dba2:30b with SMTP id ay4-20020a056a00300400b0056cdba2030bmr23051360pfb.72.1669081586274; Mon, 21 Nov 2022 17:46:26 -0800 (PST) Received: from google.com ([240f:75:7537:3187:e258:71ac:37b7:2d52]) by smtp.gmail.com with ESMTPSA id j5-20020a170902c3c500b0018853416bbcsm10452842plj.7.2022.11.21.17.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 17:46:25 -0800 (PST) Date: Tue, 22 Nov 2022 10:46:20 +0900 From: Sergey Senozhatsky To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v6 2/6] zpool: clean out dead code Message-ID: References: <20221119001536.2086599-1-nphamcs@gmail.com> <20221119001536.2086599-3-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221119001536.2086599-3-nphamcs@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669081587; a=rsa-sha256; cv=none; b=fi/9a4kWN9T/kaKGU8W4+XCg3j/tZ1RhdLqwVuIofRaLn8PUWqMsmqwVKBPa6hSkMUyWEy y0M3NVnNhVnDEcPyW0q7tw4Z5VIGO+KlWhzHJwgaai0qlixFxJg+IMscoIylsL8chJ4bAc JSeOgzGUCv/JFx2OD4bDtmViuDDNBTQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="G/z6TQzB"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669081587; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SVHrNvmN2aKc4xwWxCNYKIFTFpQYBYiPFTCfwC3xsW8=; b=DrlBAbbzywKC+bbHY8XnGLgh5LcIZVkaTwc/fREKlar4BWufoXTRZwZptO/nS9lkwIGXNl CZH0D3asG+gvVbxl9THaVXMVCYtsEapZHV9jyTmrNqFha+b6nRK+ALl2o86m+w9nbAUmIb TSOU7+ZbCQ5FdZ63o57eUtW9dCoBwC4= X-Stat-Signature: d7pqbo99cext7zy33xttqzb8m18xhd4s X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 62B7A2000A Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="G/z6TQzB"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org X-Rspam-User: X-HE-Tag: 1669081587-821268 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/18 16:15), Nhat Pham wrote: > There is a lot of provision for flexibility that isn't actually needed > or used. Zswap (the only zpool user) always passes zpool_ops with an > .evict method set. The backends who reclaim only do so for zswap, so > they can also directly call zpool_ops without indirection or checks. > > Finally, there is no need to check the retries parameters and bail > with -EINVAL in the reclaim function, when that's called just a few > lines below with a hard-coded 8. There is no need to duplicate the > evictable and sleep_mapped attrs from the driver in zpool_ops. > > Signed-off-by: Johannes Weiner > Signed-off-by: Nhat Pham Reviewed-by: Sergey Senozhatsky