From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 541FCC4332F for ; Tue, 22 Nov 2022 01:44:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEAB66B0071; Mon, 21 Nov 2022 20:44:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D9A256B0073; Mon, 21 Nov 2022 20:44:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C60FA6B0074; Mon, 21 Nov 2022 20:44:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B60506B0071 for ; Mon, 21 Nov 2022 20:44:06 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8AA841C62DC for ; Tue, 22 Nov 2022 01:44:06 +0000 (UTC) X-FDA: 80159382492.12.15C80DF Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf01.hostedemail.com (Postfix) with ESMTP id 8C3EA4000E for ; Tue, 22 Nov 2022 01:44:04 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id s196so12804236pgs.3 for ; Mon, 21 Nov 2022 17:44:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bJbRPk6em82xpoccntmsblKFY8v2T94xxvkFkQhcZEs=; b=O8Mq/nJzHTkSiTNcqCAE7zet+qYcGjd5GfVz8p46cpg03BFaLbll7Zn8ndMJRWCciU vmNTs07H5Uw6thSVA1Gdk1Q0qKvePGPC7DO49xFKtGIVIk6PA/Fm3KWF2danUv4BsRgq GDQJWPVNQtcLs7g9bc17T3kJYG5lEJLY9YZvU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bJbRPk6em82xpoccntmsblKFY8v2T94xxvkFkQhcZEs=; b=ervzam8H4ZKJANzItqCFo+7FY68R+oycizbs4u0XBRJU8T72Cba/DbbSah3JKhwzvF NZpnByHHRHLMM7FypIAhul3quiI9tu26ksRl0Ak/rB0ytDhjr3mstBvkt/A68qLz4HQa N8165Ev4c8Qxj1dyTAnhN2FhWkD0IkbJLMfELyGfViwzxpC7vhdkeneSmB+0agxrD26d CC7hb2IVvKjs6tZt6mDWuou6qtID5YKZCSfJr53em+ovGoDUfafyt7PYO8V0xcgbiGxb IH2WosXrZlPFlIWtkXjCSqifDFcIu/zEG6QkHbm0yh36wTEufh240/otN+fAZPtJ2Dmp IJhw== X-Gm-Message-State: ANoB5plmvoqZqX+Sm0lz9iOZ/b2XHkEnpMEvKqPOgxQPs/v/RwYC6BSv TQ/LBp9NZotoW7YPCJLCLXTJYg== X-Google-Smtp-Source: AA0mqf6YrmZSCLzPEKBpexm0WvkR5s8YCvxWTWz2gToQR9TO81EVkxcQin1l0xlBSgvl/gaRJmXZOQ== X-Received: by 2002:a63:1466:0:b0:476:cac7:16ad with SMTP id 38-20020a631466000000b00476cac716admr3423961pgu.128.1669081443573; Mon, 21 Nov 2022 17:44:03 -0800 (PST) Received: from google.com ([240f:75:7537:3187:e258:71ac:37b7:2d52]) by smtp.gmail.com with ESMTPSA id j14-20020a170903024e00b00188a23098aasm10632174plh.69.2022.11.21.17.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 17:44:03 -0800 (PST) Date: Tue, 22 Nov 2022 10:43:58 +0900 From: Sergey Senozhatsky To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v6 1/6] zswap: fix writeback lock ordering for zsmalloc Message-ID: References: <20221119001536.2086599-1-nphamcs@gmail.com> <20221119001536.2086599-2-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221119001536.2086599-2-nphamcs@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669081444; a=rsa-sha256; cv=none; b=6PseAhnuLvNz2ypnvmPifrAKHb+0uEWOJkZqUbMkn1gCmP+6YVV2gcbsEuG4+ZLo8TYbuT +RvHQK575QW11yfmi4Jr0uQ6dlS/DjNvvdqrhFAO2/AE3Q1g+at0+UQykrhFcy4ZXU7FgS f2ql2/pcvWqhjx+dYw3JIfyoWC2LVwg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="O8Mq/nJz"; spf=pass (imf01.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669081444; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bJbRPk6em82xpoccntmsblKFY8v2T94xxvkFkQhcZEs=; b=Zpiel6kpwVDBXqDWsZETqMWwm0hSi+Scp3oBFFw+3zaryzEeXG9Y9D8Y/pqgmkE7g7mFY8 3+4IBruDRDyX/ommn1lxddpF06yjOgbgcfzUSUGXE8GYYCg6Wa2+hGytqkXpdiOfm83BzN iUG/QIAWXskPEtDBmWHC2MmMCiFJ8BQ= X-Rspam-User: X-Rspamd-Queue-Id: 8C3EA4000E Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="O8Mq/nJz"; spf=pass (imf01.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Stat-Signature: eazre6fesqgqqbfhy4kxcxh3t5godb8p X-Rspamd-Server: rspam10 X-HE-Tag: 1669081444-606243 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/18 16:15), Nhat Pham wrote: > @@ -958,7 +958,7 @@ static int zswap_writeback_entry(struct zpool *pool, unsigned long handle) > }; > > if (!zpool_can_sleep_mapped(pool)) { > - tmp = kmalloc(PAGE_SIZE, GFP_ATOMIC); > + tmp = kmalloc(PAGE_SIZE, GFP_KERNEL); > if (!tmp) > return -ENOMEM; > } I guess this chunk is not realted to zsmalloc lock oredering fix. Should it be a separate patch? And feel free to squash my patch, that does the similar thing: https://lore.kernel.org/all/20221122013338.3696079-1-senozhatsky@chromium.org/