From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4C22C43219 for ; Tue, 22 Nov 2022 01:53:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D0556B0071; Mon, 21 Nov 2022 20:53:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 380656B0073; Mon, 21 Nov 2022 20:53:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2967A6B0074; Mon, 21 Nov 2022 20:53:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 18C066B0071 for ; Mon, 21 Nov 2022 20:53:05 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E79B11206CC for ; Tue, 22 Nov 2022 01:53:04 +0000 (UTC) X-FDA: 80159405088.09.669138D Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf12.hostedemail.com (Postfix) with ESMTP id 8D29540008 for ; Tue, 22 Nov 2022 01:53:04 +0000 (UTC) Received: by mail-pg1-f180.google.com with SMTP id h193so12767926pgc.10 for ; Mon, 21 Nov 2022 17:53:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ef/dYlQV746zV7HsmZzIsfpA9DBWh47fHQKVjHWsG88=; b=V6nNGPcFRhv76hz2oLZ/b6dKT4Xqgd4inWcYruCRq3jx5s2Q/qdoUPWg4Z3DMoqEP0 i2/lXnAb1xVNy1Nv2WPPVqzHUNlWWj2RymrXHzL5TBvkz92yBFZAS6ryH7HDMOgBLQDD 5HvnRK8rznhlMEmONhLUbPz5bpTONhZVe1JRw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ef/dYlQV746zV7HsmZzIsfpA9DBWh47fHQKVjHWsG88=; b=Kn5jh7y2QLpv+CcagsaOp8pAA7yo+aQn0oXfln1257X0z4RcQF23wm6ZobcgR26pMa BrxiP34vzvmKqwLn/3qsAZbmo+giJG2WNKjepWRSRT+5o3TN0l1440nqKSvmtaGJq7r9 VooY52LNPfbNLvU9y2A7y6HJE6kipq2TMWfF48AfX1zdk0pPrMEoA1uXPN+N5Du0s6wz J4SXOLufw5LWqyHzGQtMVhKLmEDtLDuNEaL21I3+wAXLYsC5b4Z7iYPrOHa+IaWqsSlT F+e0jpRS0yNmE//NJnn1q2DlG22WuMR0h7ErExSMmP+IdNV1kecI0mjYOMmtM58Il5B8 QUew== X-Gm-Message-State: ANoB5pnS08sh4RX+917EJk8+LVsKkwB5E7X1Y3cr9146w95yDj9985Hi r9Lc29bXkFjQ/lvvLfwgNotB4w== X-Google-Smtp-Source: AA0mqf5GK8otzLcc9t67L1TQtul/q99BZTHqxni4KNOyckphWFo+Ssx3RHdXJ/yWR5TT6Ni6gKblbg== X-Received: by 2002:a65:6d95:0:b0:46f:f482:6920 with SMTP id bc21-20020a656d95000000b0046ff4826920mr1372675pgb.327.1669081983563; Mon, 21 Nov 2022 17:53:03 -0800 (PST) Received: from google.com ([240f:75:7537:3187:e258:71ac:37b7:2d52]) by smtp.gmail.com with ESMTPSA id z29-20020aa7991d000000b0056da63c8515sm9620767pff.91.2022.11.21.17.53.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 17:53:03 -0800 (PST) Date: Tue, 22 Nov 2022 10:52:58 +0900 From: Sergey Senozhatsky To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v6 4/6] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order Message-ID: References: <20221119001536.2086599-1-nphamcs@gmail.com> <20221119001536.2086599-5-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221119001536.2086599-5-nphamcs@gmail.com> ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=V6nNGPcF; spf=pass (imf12.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669081984; a=rsa-sha256; cv=none; b=CfOOEx9cxfa4Mjwvc1Zk+SFlILx5TwGVy2r0K3Rh6swt8G8zGjAU6ZLchyNpoEsXuEM/7i vFwhEDbUSoVMTNTqDkfFvSAYMBfIJjG86HfwUZiWvg07TTcVvx0Pt/aheN0oj8HKK7vxiO yHqlpOcOF7suZuKRkm23UbGE6b6nHMI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669081984; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ef/dYlQV746zV7HsmZzIsfpA9DBWh47fHQKVjHWsG88=; b=8ZRb/393CPOfAWos06OBKcLeqoR5pNzArKobP8PNSMG81qUBF+wyxGb9rAIuLWNYAPA9zK fBun27FH6tNu1X3mTD5GdnA3arpx/jIpSXxZRTyY/F6DIwK51/Mz1lUyHyXfSGxZh6Bu4p FEr46DDiLwjTCLrKDyYp4L5V654941g= X-Rspamd-Queue-Id: 8D29540008 X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=V6nNGPcF; spf=pass (imf12.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam06 X-Stat-Signature: 37nw7fi61z5c54ein56456pri5q5cxjg X-HE-Tag: 1669081984-872867 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/18 16:15), Nhat Pham wrote: [..] > @@ -1249,6 +1267,15 @@ void *zs_map_object(struct zs_pool *pool, unsigned long handle, > obj_to_location(obj, &page, &obj_idx); > zspage = get_zspage(page); > > +#ifdef CONFIG_ZPOOL > + /* Move the zspage to front of pool's LRU */ > + if (mm == ZS_MM_WO) { > + if (!list_empty(&zspage->lru)) > + list_del(&zspage->lru); > + list_add(&zspage->lru, &pool->lru); > + } > +#endif Do we consider pages that were mapped for MM_RO/MM_RW as cold? I wonder why, we use them, so technically they are not exactly "least recently used".